skip flakey tests, remove testdox flag

googleapis · Sep 26, 2024 · 7b6d80c · 7b6d80c
1 parent e319417
commit 7b6d80c
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 7 deletions.
diff --git a/.github/workflows/system-tests.yaml b/.github/workflows/system-tests.yaml
@@ -26,6 +26,6 @@ jobs:
       - name: Install dependencies
         run: composer  --no-interaction --no-ansi --no-progress update
       - name: Run System Tests
-        run: vendor/bin/phpunit -c phpunit-system.xml.dist --testdox --colors=always
+        run: vendor/bin/phpunit -c phpunit-system.xml.dist --colors=always  --exclude-group=flakey
         env:
           GOOGLE_CLOUD_PHP_TESTS_KEY_PATH: ${{ runner.temp }}/service-account.json
diff --git a/Firestore/tests/System/bootstrap.php b/Firestore/tests/System/bootstrap.php
@@ -3,8 +3,8 @@
 use Google\Cloud\Core\Testing\TestHelpers;
 use Google\Cloud\Firestore\Tests\System\FirestoreTestCase;
 
-// TestHelpers::requireKeyfile('GOOGLE_CLOUD_PHP_TESTS_KEY_PATH');
-// TestHelpers::generatedSystemTestBootstrap();
-// TestHelpers::systemTestShutdown(function () {
-//     FirestoreTestCase::tearDownFixtures();
-// });
+TestHelpers::requireKeyfile('GOOGLE_CLOUD_PHP_TESTS_KEY_PATH');
+TestHelpers::generatedSystemTestBootstrap();
+TestHelpers::systemTestShutdown(function () {
+    FirestoreTestCase::tearDownFixtures();
+});
diff --git a/Storage/tests/System/ManageAclTest.php b/Storage/tests/System/ManageAclTest.php
@@ -32,9 +32,14 @@ public function testManageBucketAcl()
         $this->assertAcl(self::$bucket->acl(), $kind);
     }
 
+    /**
+     * This test is marked flakey because it often throws a RateLimitExceeded
+     * error
+     *
+     * @group flakey
+     */
     public function testManageDefaultObjectAcl()
     {
-        $this->markTestSkipped('Skipping flakey test due to exceed rate limits.');
         $kind = 'storage#objectAccessControl';
         $this->assertAcl(self::$bucket->defaultAcl(), $kind);
     }