feat: Add INTERNAL as a retryable error code. (#2248)

googleapis · Aug 14, 2019 · 428d976 · 428d976
1 parent fba8c5a
commit 428d976
Show file tree

Hide file tree

Showing 2 changed files with 36 additions and 30 deletions.
diff --git a/Kms/src/V1/resources/key_management_service_client_config.json b/Kms/src/V1/resources/key_management_service_client_config.json
@@ -2,11 +2,17 @@
   "interfaces": {
     "google.cloud.kms.v1.KeyManagementService": {
       "retry_codes": {
+        "retryable": [
+          "DEADLINE_EXCEEDED",
+          "INTERNAL",
+          "UNAVAILABLE"
+        ],
         "idempotent": [
           "DEADLINE_EXCEEDED",
           "UNAVAILABLE"
         ],
-        "non_idempotent": []
+        "non_idempotent": [],
+        "non_retryable": []
       },
       "retry_params": {
         "default": {
@@ -22,132 +28,132 @@
       "methods": {
         "ListKeyRings": {
           "timeout_millis": 60000,
-          "retry_codes_name": "idempotent",
+          "retry_codes_name": "retryable",
           "retry_params_name": "default"
         },
         "ListImportJobs": {
           "timeout_millis": 60000,
-          "retry_codes_name": "idempotent",
+          "retry_codes_name": "retryable",
           "retry_params_name": "default"
         },
         "ListCryptoKeys": {
           "timeout_millis": 60000,
-          "retry_codes_name": "idempotent",
+          "retry_codes_name": "retryable",
           "retry_params_name": "default"
         },
         "ListCryptoKeyVersions": {
           "timeout_millis": 60000,
-          "retry_codes_name": "idempotent",
+          "retry_codes_name": "retryable",
           "retry_params_name": "default"
         },
         "GetKeyRing": {
           "timeout_millis": 60000,
-          "retry_codes_name": "idempotent",
+          "retry_codes_name": "retryable",
           "retry_params_name": "default"
         },
         "GetImportJob": {
           "timeout_millis": 60000,
-          "retry_codes_name": "idempotent",
+          "retry_codes_name": "retryable",
           "retry_params_name": "default"
         },
         "GetCryptoKey": {
           "timeout_millis": 60000,
-          "retry_codes_name": "idempotent",
+          "retry_codes_name": "retryable",
           "retry_params_name": "default"
         },
         "GetCryptoKeyVersion": {
           "timeout_millis": 60000,
-          "retry_codes_name": "idempotent",
+          "retry_codes_name": "retryable",
           "retry_params_name": "default"
         },
         "CreateKeyRing": {
           "timeout_millis": 60000,
-          "retry_codes_name": "non_idempotent",
+          "retry_codes_name": "retryable",
           "retry_params_name": "default"
         },
         "CreateImportJob": {
           "timeout_millis": 60000,
-          "retry_codes_name": "non_idempotent",
+          "retry_codes_name": "retryable",
           "retry_params_name": "default"
         },
         "CreateCryptoKey": {
           "timeout_millis": 60000,
-          "retry_codes_name": "non_idempotent",
+          "retry_codes_name": "retryable",
           "retry_params_name": "default"
         },
         "CreateCryptoKeyVersion": {
           "timeout_millis": 60000,
-          "retry_codes_name": "non_idempotent",
+          "retry_codes_name": "non_retryable",
           "retry_params_name": "default"
         },
         "ImportCryptoKeyVersion": {
           "timeout_millis": 60000,
-          "retry_codes_name": "non_idempotent",
+          "retry_codes_name": "non_retryable",
           "retry_params_name": "default"
         },
         "UpdateCryptoKey": {
           "timeout_millis": 60000,
-          "retry_codes_name": "non_idempotent",
+          "retry_codes_name": "retryable",
           "retry_params_name": "default"
         },
         "UpdateCryptoKeyVersion": {
           "timeout_millis": 60000,
-          "retry_codes_name": "non_idempotent",
+          "retry_codes_name": "retryable",
           "retry_params_name": "default"
         },
         "Encrypt": {
           "timeout_millis": 60000,
-          "retry_codes_name": "idempotent",
+          "retry_codes_name": "retryable",
           "retry_params_name": "default"
         },
         "Decrypt": {
           "timeout_millis": 60000,
-          "retry_codes_name": "idempotent",
+          "retry_codes_name": "retryable",
           "retry_params_name": "default"
         },
         "UpdateCryptoKeyPrimaryVersion": {
           "timeout_millis": 60000,
-          "retry_codes_name": "non_idempotent",
+          "retry_codes_name": "retryable",
           "retry_params_name": "default"
         },
         "DestroyCryptoKeyVersion": {
           "timeout_millis": 60000,
-          "retry_codes_name": "non_idempotent",
+          "retry_codes_name": "retryable",
           "retry_params_name": "default"
         },
         "RestoreCryptoKeyVersion": {
           "timeout_millis": 60000,
-          "retry_codes_name": "non_idempotent",
+          "retry_codes_name": "retryable",
           "retry_params_name": "default"
         },
         "GetPublicKey": {
           "timeout_millis": 60000,
-          "retry_codes_name": "idempotent",
+          "retry_codes_name": "retryable",
           "retry_params_name": "default"
         },
         "AsymmetricDecrypt": {
           "timeout_millis": 60000,
-          "retry_codes_name": "idempotent",
+          "retry_codes_name": "retryable",
           "retry_params_name": "default"
         },
         "AsymmetricSign": {
           "timeout_millis": 60000,
-          "retry_codes_name": "idempotent",
+          "retry_codes_name": "retryable",
           "retry_params_name": "default"
         },
         "SetIamPolicy": {
           "timeout_millis": 60000,
-          "retry_codes_name": "non_idempotent",
+          "retry_codes_name": "retryable",
           "retry_params_name": "default"
         },
         "GetIamPolicy": {
           "timeout_millis": 60000,
-          "retry_codes_name": "idempotent",
+          "retry_codes_name": "retryable",
           "retry_params_name": "default"
         },
         "TestIamPermissions": {
           "timeout_millis": 60000,
-          "retry_codes_name": "non_idempotent",
+          "retry_codes_name": "retryable",
           "retry_params_name": "default"
         }
       }

diff --git a/Kms/synth.metadata b/Kms/synth.metadata
@@ -1,5 +1,5 @@
 {
-  "updateTime": "2019-08-07T18:01:42.074781Z",
+  "updateTime": "2019-08-14T10:01:11.994295Z",
   "sources": [
     {
       "generator": {
@@ -12,8 +12,8 @@
       "git": {
         "name": "googleapis",
         "remote": "https://github.com/googleapis/googleapis.git",
-        "sha": "3a1b46a6668194a527e532a2c355b404c79b0e6a",
-        "internalRef": "262167956"
+        "sha": "3406d1e899f1f41123b3fa9210ad4bef25c9a720",
+        "internalRef": "263234709"
       }
     }
   ],