Skip to content

Commit

Permalink
chore!: promote Dataform to v2
Browse files Browse the repository at this point in the history
  • Loading branch information
bshaffer committed Dec 17, 2024
1 parent 70dd30d commit 0f3dbd6
Show file tree
Hide file tree
Showing 108 changed files with 1,090 additions and 9,517 deletions.
4 changes: 2 additions & 2 deletions .repo-metadata-full.json
Original file line number Diff line number Diff line change
Expand Up @@ -517,7 +517,7 @@
"Dataform": {
"language": "php",
"distribution_name": "google/cloud-dataform",
"release_level": "preview",
"release_level": "stable",
"client_documentation": "https://cloud.google.com/php/docs/reference/cloud-dataform/latest",
"library_type": "GAPIC_AUTO",
"product_documentation": "https://cloud.google.com/dataform/docs",
Expand Down Expand Up @@ -1599,4 +1599,4 @@
"library_type": "GAPIC_AUTO",
"api_shortname": "workflows"
}
}
}
4 changes: 2 additions & 2 deletions Dataform/.OwlBot.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
deep-copy-regex:
- source: /google/cloud/dataform/v1beta1/.*-php/(.*)
dest: /owl-bot-staging/Dataform/v1beta1/$1
- source: /google/cloud/dataform/(v1beta1)/.*-php/(.*)
dest: /owl-bot-staging/Dataform/$1/$2
api-name: Dataform
41 changes: 4 additions & 37 deletions Dataform/owlbot.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright 2022 Google LLC
# Copyright 2024 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -30,14 +30,7 @@
# Added so that we can pass copy_excludes in the owlbot_main() call
_tracked_paths.add(src)

php.owlbot_main(
src=src,
dest=dest,
copy_excludes=[
src / "**/[A-Z]*_*.php",
src / "**/*GrpcClient.php"
]
)
php.owlbot_main(src=src, dest=dest)

# remove class_alias code
s.replace(
Expand All @@ -48,32 +41,6 @@
+ "\n",
'')

### [START] protoc backwards compatibility fixes

# roll back to private properties.
s.replace(
"src/**/V*/**/*.php",
r"Generated from protobuf field ([^\n]{0,})\n\s{5}\*/\n\s{4}protected \$",
r"""Generated from protobuf field \1
*/
private $""")

# Replace "Unwrapped" with "Value" for method names.
s.replace(
"src/**/V*/**/*.php",
r"public function ([s|g]\w{3,})Unwrapped",
r"public function \1Value"
)

### [END] protoc backwards compatibility fixes

# fix relative cloud.google.com links
s.replace(
"src/**/V*/**/*.php",
r"(.{0,})\]\((/.{0,})\)",
r"\1](https://cloud.google.com\2)"
)

# format generated clients
subprocess.run([
'npm',
Expand All @@ -82,8 +49,8 @@
'--package=@prettier/plugin-php@^0.16',
'--',
'prettier',
'**/Gapic/*',
'**/Client/*',
'--write',
'--parser=php',
'--single-quote',
'--print-width=80'])
'--print-width=120'])
2 changes: 1 addition & 1 deletion Dataform/src/V1beta1/CancelWorkflowInvocationRequest.php

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 0f3dbd6

Please sign in to comment.