Bandaid for protobuf 4761 (#1176)

* Temporary workaround for protobuf extension issue protocolbuffers/protobuf#4761 * Bump gax to 0.36 * Configure comparators for the unit test * Revert back to normal TestCase * Install protobuf extension in the PHP 7.2 test runner * Revert to TestCase
googleapis · Jul 19, 2018 · 84892bf · 84892bf
1 parent 72b8bf1
commit 84892bf
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/composer.json b/composer.json
@@ -5,7 +5,7 @@
     "minimum-stability": "stable",
     "require": {
         "google/cloud-core": "^1.14",
-        "google/gax": "^0.35"
+        "google/gax": "^0.36"
     },
     "require-dev": {
         "phpunit/phpunit": "^4.8|^5.0",

diff --git a/tests/Unit/V1/ImageAnnotatorClientExtensionTest.php b/tests/Unit/V1/ImageAnnotatorClientExtensionTest.php
@@ -115,7 +115,12 @@ public function testAnnotateImageWithImageContext()
         $this->transport->startUnaryCall( Argument::allOf(
                     Argument::type(Call::class),
                     Argument::which('getMethod', 'google.cloud.vision.v1.ImageAnnotator/BatchAnnotateImages'),
-                    Argument::which('getMessage', $expectedMessage)
+                    Argument::that(function($arg) use ($expectedMessage) {
+                        if ($arg->getMessage()->serializeToString() === $expectedMessage->serializeToString()) {
+                            return true;
+                        }
+                        return false;
+                    })
                 ),
                 Argument::type('array')
             )
@@ -160,7 +165,12 @@ public function testDetectionMethod($methodName, $featureType, $image)
                 Argument::allOf(
                     Argument::type(Call::class),
                     Argument::which('getMethod', 'google.cloud.vision.v1.ImageAnnotator/BatchAnnotateImages'),
-                    Argument::which('getMessage', $expectedMessage)
+                    Argument::that(function($arg) use ($expectedMessage) {
+                        if ($arg->getMessage()->serializeToString() === $expectedMessage->serializeToString()) {
+                            return true;
+                        }
+                        return false;
+                    })
                 ),
                 Argument::type('array')
             )