-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: use google-auto-auth #823
core: use google-auto-auth #823
Conversation
/cc @anthmgoogle (working on the auth libraries) @stephenplusplus : Any reason why we couldn't push the commits upstream into google-auth-library? |
google-auth-library is much more complex and lacks documentation. google-auto-auth was just built to simplify it with a more conventional JS approach. I don't think this approach (high-level userland packages that wrap more low-level ones) is anything to worry about. |
Cool - if it's something specific like this, maybe we can get it shoved under the google or GCP github organization...? |
That's fine with me, though seeing two repos that handle authorization in Node under the same org might be a bit confusing to a user. I'm happy to transfer the ownership of the repo though if you don't think that's a concern. |
Eh let's leave it alone for now, and keep it as an idea for discussion On Wed, Aug 26, 2015 at 9:14 AM, Stephen Sawchuk [email protected]
|
SGTM 👍 |
core: use google-auto-auth
feat: added more Environment RPCs feat: added Versions service feat: added Fulfillment service feat: added TextToSpeechSettings. refactor!: helper agentPath becomes projectAgentPath refactor!: helper intentPath becomes projectAgentIntentPath refactor!: helper entityTypePath becomes projectAgentEntityTypePath PiperOrigin-RevId: 372230736 Fixes #822
Fixes #822
This incorporates https://github.com/stephenplusplus/google-auto-auth into our library, replacing
google-auth-library
(kind of; it's wrapped bygoogle-auto-auth
).// cc @ofrobots