Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: use google-auto-auth #823

Merged

Conversation

stephenplusplus
Copy link
Contributor

Fixes #822

This incorporates https://github.com/stephenplusplus/google-auto-auth into our library, replacing google-auth-library (kind of; it's wrapped by google-auto-auth).

// cc @ofrobots

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 26, 2015
@jgeewax
Copy link
Contributor

jgeewax commented Aug 26, 2015

/cc @anthmgoogle (working on the auth libraries)

@stephenplusplus : Any reason why we couldn't push the commits upstream into google-auth-library?

@stephenplusplus
Copy link
Contributor Author

google-auth-library is much more complex and lacks documentation. google-auto-auth was just built to simplify it with a more conventional JS approach. I don't think this approach (high-level userland packages that wrap more low-level ones) is anything to worry about.

@jgeewax
Copy link
Contributor

jgeewax commented Aug 26, 2015

Cool - if it's something specific like this, maybe we can get it shoved under the google or GCP github organization...?

@stephenplusplus
Copy link
Contributor Author

That's fine with me, though seeing two repos that handle authorization in Node under the same org might be a bit confusing to a user. I'm happy to transfer the ownership of the repo though if you don't think that's a concern.

@jgeewax
Copy link
Contributor

jgeewax commented Aug 26, 2015

Eh let's leave it alone for now, and keep it as an idea for discussion
later on...

On Wed, Aug 26, 2015 at 9:14 AM, Stephen Sawchuk [email protected]
wrote:

That's fine with me, though seeing two repos that handle authorization in
Node under the same org might be a bit confusing to a user. I'm happy to
transfer the ownership of the repo though if you don't think that's a
concern.


Reply to this email directly or view it on GitHub
#823 (comment)
.

@stephenplusplus
Copy link
Contributor Author

SGTM 👍

callmehiphop added a commit that referenced this pull request Aug 26, 2015
@callmehiphop callmehiphop merged commit 2b80071 into googleapis:master Aug 26, 2015
sofisl pushed a commit that referenced this pull request Nov 11, 2022
feat: added more Environment RPCs
feat: added Versions service
feat: added Fulfillment service
feat: added TextToSpeechSettings.
refactor!: helper agentPath becomes projectAgentPath
refactor!: helper intentPath becomes projectAgentIntentPath
refactor!: helper entityTypePath becomes projectAgentEntityTypePath
PiperOrigin-RevId: 372230736
Fixes #822
sofisl pushed a commit that referenced this pull request Jan 24, 2023
sofisl pushed a commit that referenced this pull request Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants