Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: [kmsinventory] Pagination feature is introduced for method ListKeyHandles in service Autokey #5690

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

gcf-owl-bot[bot]
Copy link
Contributor

@gcf-owl-bot gcf-owl-bot bot commented Sep 19, 2024

  • Regenerate this pull request now.

feat: Adding a state field for AutokeyConfig

docs: Field service_resolvers in message .google.cloud.kms.v1.EkmConnection is Explicitly is marked as to have field behavior of Optional

docs: A comment for field destroy_scheduled_duration in message .google.cloud.kms.v1.CryptoKey is updated for the default duration
PiperOrigin-RevId: 676068244

Source-Link: googleapis/googleapis@42492c9

Source-Link: https://github.com/googleapis/googleapis-gen/commit/47432180bdfba879fc7f82c4c451181702f25009
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWttcy1pbnZlbnRvcnkvLk93bEJvdC55YW1sIiwiaCI6IjQ3NDMyMTgwYmRmYmE4NzlmYzdmODJjNGM0NTExODE3MDJmMjUwMDkifQ==

… service `Autokey`

feat: Adding a state field for AutokeyConfig

docs: Field service_resolvers in message .google.cloud.kms.v1.EkmConnection is Explicitly is marked as to have field behavior of Optional

docs: A comment for field `destroy_scheduled_duration` in message `.google.cloud.kms.v1.CryptoKey` is updated for the default duration
PiperOrigin-RevId: 676068244

Source-Link: googleapis/googleapis@42492c9

Source-Link: https://github.com/googleapis/googleapis-gen/commit/47432180bdfba879fc7f82c4c451181702f25009
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWttcy1pbnZlbnRvcnkvLk93bEJvdC55YW1sIiwiaCI6IjQ3NDMyMTgwYmRmYmE4NzlmYzdmODJjNGM0NTExODE3MDJmMjUwMDkifQ==
@dpebot
Copy link
Collaborator

dpebot commented Sep 19, 2024

/gcbrun

@gcf-owl-bot gcf-owl-bot bot marked this pull request as ready for review September 19, 2024 00:19
@gcf-owl-bot gcf-owl-bot bot requested review from yoshi-approver and a team as code owners September 19, 2024 00:19
@dpebot
Copy link
Collaborator

dpebot commented Sep 19, 2024

/gcbrun

@sofisl
Copy link
Contributor

sofisl commented Sep 20, 2024

Same as other one, this is genuinely a breaking change so let's wait for Node 18.

@sofisl sofisl added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 20, 2024
@danielbankhead danielbankhead added semver: major Hint for users that this is an API breaking change. next major: breaking change this is a change that we should wait to bundle into the next major version labels Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge Indicates a pull request not ready for merge, due to either quality or timing. next major: breaking change this is a change that we should wait to bundle into the next major version owl-bot-copy semver: major Hint for users that this is an API breaking change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants