Allow explicit set of method on Dataset#save #387

ryanseys · 2015-02-08T06:03:21Z

Should satisfy the needs of #384

stephenplusplus · 2015-02-09T15:13:51Z

The way you implemented this is quite brilliant in its simplicity!

Do you think we should branch out the API to add these methods in? dataset.insert/upsert/etc that would just wrap the longer method: "insert/upsert/etc" call?

ryanseys · 2015-02-09T15:20:32Z

I wasn't sure what was preferred here, so your suggestions are very welcome! This is one less-obvious technique, however if you think more value could come from separate methods, let's do that instead.

stephenplusplus · 2015-02-09T15:23:41Z

My only thought is save is magic, so insert/upsert/etc is declarative. I just think it would be expected that we have those methods. Your implementation is still perfect, we can just add the convenience methods (which we're growing quite a collection of!)

ryanseys · 2015-02-11T22:02:01Z

Should we merge this and then we can open an issue to add the declarative methods?

test/datastore/request.js

+        assert.equal(
+          req.mutation.insert[0].property[0].value.string_value, 'v');
+        assert.equal(req.mutation.update[0].property[0].name, 'k2');
+          assert.equal(


stephenplusplus · 2015-02-12T18:30:49Z

SGTM. Minor formatting comments, then self-merging is cool with me.

Allow explicit set of method on Dataset#save

lib/datastore/request.js

+ *     method: 'insert', // force the method to 'insert'
+ *     data: {
+ *       fullName: 'Andrew Chilton'
+ *     }


* chore: updated samples/package.json [ci skip] * chore: updated CHANGELOG.md [ci skip] * chore: updated package.json Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/4bdc1826-2f69-49f1-a63b-94f99cceb5ee/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@89d431f

BREAKING CHANGE: v3 introduces significant changes to API surface, see: https://cloud.google.com/resource-manager/reference/rest/v3/folders

* chore(main): release 3.0.0 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/4bdc1826-2f69-49f1-a63b-94f99cceb5ee/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@89d431f

* chore: updated samples/package.json [ci skip] * chore: updated CHANGELOG.md [ci skip] * chore: updated package.json Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* fix(docs): describe fallback rest option Use gapic-generator-typescript v2.15.1. PiperOrigin-RevId: 456946341 Source-Link: googleapis/googleapis@88fd18d Source-Link: googleapis/googleapis-gen@accfa37 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYWNjZmEzNzFmNjY3NDM5MzEzMzM1YzY0MDQyYjA2M2MxYzUzMTAyZSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

🤖 I have created a release *beep* *boop* --- ## [3.0.2](googleapis/nodejs-recaptcha-enterprise@v3.0.1...v3.0.2) (2022-06-30) ### Bug Fixes * **docs:** describe fallback rest option ([#387](googleapis/nodejs-recaptcha-enterprise#387)) ([fe11f09](googleapis/nodejs-recaptcha-enterprise@fe11f09)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

* test: use fully qualified request type name in tests PiperOrigin-RevId: 475685359 Source-Link: googleapis/googleapis@7a12973 Source-Link: googleapis/googleapis-gen@370c729 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMzcwYzcyOWUyYmEwNjJhMTY3NDQ5YzI3ODgyYmE1ZjM3OWM1YzM0ZCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/73563d93-aea4-4354-9013-d19800d55cda/targets

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [uuid](https://togithub.com/uuidjs/uuid) | devDependencies | major | [`^7.0.2` -> `^8.0.0`](https://renovatebot.com/diffs/npm/uuid/7.0.3/8.0.0) | --- ### Release Notes <details> <summary>uuidjs/uuid</summary> ### [`v8.0.0`](https://togithub.com/uuidjs/uuid/blob/master/CHANGELOG.md#800-httpsgithubcomuuidjsuuidcomparev703v800-2020-04-29) [Compare Source](https://togithub.com/uuidjs/uuid/compare/v7.0.3...v8.0.0) ##### ⚠ BREAKING CHANGES - For native ECMAScript Module (ESM) usage in Node.js only named exports are exposed, there is no more default export. ```diff -import uuid from 'uuid'; -console.log(uuid.v4()); // -> 'cd6c3b08-0adc-4f4b-a6ef-36087a1c9869' +import { v4 as uuidv4 } from 'uuid'; +uuidv4(); // ⇨ '9b1deb4d-3b7d-4bad-9bdd-2b0d7b3dcb6d' ``` - Deep requiring specific algorithms of this library like `require('uuid/v4')`, which has been deprecated in `uuid@7`, is no longer supported. Instead use the named exports that this module exports. For ECMAScript Modules (ESM): ```diff -import uuidv4 from 'uuid/v4'; +import { v4 as uuidv4 } from 'uuid'; uuidv4(); ``` For CommonJS: ```diff -const uuidv4 = require('uuid/v4'); +const { v4: uuidv4 } = require('uuid'); uuidv4(); ``` ##### Features - native Node.js ES Modules (wrapper approach) ([#423](https://togithub.com/uuidjs/uuid/issues/423)) ([2d9f590](https://togithub.com/uuidjs/uuid/commit/2d9f590ad9701d692625c07ed62f0a0f91227991)), closes [#245](https://togithub.com/uuidjs/uuid/issues/245) [#419](https://togithub.com/uuidjs/uuid/issues/419) [#342](https://togithub.com/uuidjs/uuid/issues/342) - remove deep requires ([#426](https://togithub.com/uuidjs/uuid/issues/426)) ([daf72b8](https://togithub.com/uuidjs/uuid/commit/daf72b84ceb20272a81bb5fbddb05dd95922cbba)) ##### Bug Fixes - add CommonJS syntax example to README quickstart section ([#417](https://togithub.com/uuidjs/uuid/issues/417)) ([e0ec840](https://togithub.com/uuidjs/uuid/commit/e0ec8402c7ad44b7ef0453036c612f5db513fda0)) ##### [7.0.3](https://togithub.com/uuidjs/uuid/compare/v7.0.2...v7.0.3) (2020-03-31) ##### Bug Fixes - make deep require deprecation warning work in browsers ([#409](https://togithub.com/uuidjs/uuid/issues/409)) ([4b71107](https://togithub.com/uuidjs/uuid/commit/4b71107d8c0d2ef56861ede6403fc9dc35a1e6bf)), closes [#408](https://togithub.com/uuidjs/uuid/issues/408) ##### [7.0.2](https://togithub.com/uuidjs/uuid/compare/v7.0.1...v7.0.2) (2020-03-04) ##### Bug Fixes - make access to msCrypto consistent ([#393](https://togithub.com/uuidjs/uuid/issues/393)) ([8bf2a20](https://togithub.com/uuidjs/uuid/commit/8bf2a20f3565df743da7215eebdbada9d2df118c)) - simplify link in deprecation warning ([#391](https://togithub.com/uuidjs/uuid/issues/391)) ([bb2c8e4](https://togithub.com/uuidjs/uuid/commit/bb2c8e4e9f4c5f9c1eaaf3ea59710c633cd90cb7)) - update links to match content in readme ([#386](https://togithub.com/uuidjs/uuid/issues/386)) ([44f2f86](https://togithub.com/uuidjs/uuid/commit/44f2f86e9d2bbf14ee5f0f00f72a3db1292666d4)) ##### [7.0.1](https://togithub.com/uuidjs/uuid/compare/v7.0.0...v7.0.1) (2020-02-25) ##### Bug Fixes - clean up esm builds for node and browser ([#383](https://togithub.com/uuidjs/uuid/issues/383)) ([59e6a49](https://togithub.com/uuidjs/uuid/commit/59e6a49e7ce7b3e8fb0f3ee52b9daae72af467dc)) - provide browser versions independent from module system ([#380](https://togithub.com/uuidjs/uuid/issues/380)) ([4344a22](https://togithub.com/uuidjs/uuid/commit/4344a22e7aed33be8627eeaaf05360f256a21753)), closes [#378](https://togithub.com/uuidjs/uuid/issues/378) </details> --- ### Renovate configuration :date: **Schedule**: "after 9am and before 3pm" (UTC). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/nodejs-dns).

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 8, 2015

ryanseys mentioned this pull request Feb 8, 2015

Expose something finer than just .save() through the datastore abstraction #384

Closed

dhermes mentioned this pull request Feb 8, 2015

Support update/insert in save() googleapis/google-cloud-python#599

Closed

stephenplusplus reviewed Feb 12, 2015
View reviewed changes

test/datastore/request.js

assert.equal(

req.mutation.insert[0].property[0].value.string_value, 'v');

assert.equal(req.mutation.update[0].property[0].name, 'k2');

assert.equal(

This comment was marked as spam.

Sign in to view

Allow explicit set of method on Dataset#save

30bd7be

ryanseys added a commit that referenced this pull request Feb 13, 2015

Merge pull request #387 from ryanseys/datastore-method

e8b17a2

Allow explicit set of method on Dataset#save

ryanseys merged commit e8b17a2 into googleapis:master Feb 13, 2015

ryanseys deleted the datastore-method branch February 13, 2015 00:00

stephenplusplus mentioned this pull request Feb 16, 2015

Add declarative datastore methods #392

Closed

chilts reviewed Feb 16, 2015
View reviewed changes

lib/datastore/request.js

* method: 'insert', // force the method to 'insert'

* data: {

* fullName: 'Andrew Chilton'

* }

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

sofisl mentioned this pull request Sep 15, 2022

migrate code from googleapis/nodejs-redis #3360

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Sep 15, 2022

build: update CI coverage and fix linting issues (#387)

423f815

sofisl mentioned this pull request Oct 11, 2022

migrate code from googleapis/nodejs-language #3395

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Oct 11, 2022

build(tests): fix coveralls and enable build cop (#387)

3e880ed

sofisl mentioned this pull request Oct 12, 2022

migrate code from googleapis/nodejs-bigquery-data-transfer #3399

Merged

4 tasks

sofisl added a commit that referenced this pull request Oct 12, 2022

feat!: migrate to v3 API surface (#387)

1399e57

BREAKING CHANGE: v3 introduces significant changes to API surface, see: https://cloud.google.com/resource-manager/reference/rest/v3/folders

sofisl mentioned this pull request Oct 12, 2022

migrate code from googleapis/nodejs-resource-manager #3402

Merged

4 tasks

release-please bot mentioned this pull request Oct 12, 2022

chore: release main #3403

Closed

sofisl mentioned this pull request Oct 13, 2022

migrate code from googleapis/nodejs-phishing-protection #3406

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Oct 13, 2022

build(tests): fix coveralls and enable build cop (#387)

d7562ef

sofisl mentioned this pull request Nov 10, 2022

migrate code from googleapis/nodejs-translate #3520

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Nov 10, 2022

fix: get autosynth working again (#387)

39ae87a

sofisl mentioned this pull request Nov 10, 2022

migrate code from googleapis/nodejs-text-to-speech #3528

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Nov 10, 2022

chore: update proto namespaces (#387)

52f34d6

This was referenced Nov 11, 2022

migrate code from googleapis/nodejs-asset #3567

Merged

migrate code from googleapis/nodejs-talent #3568

Merged

sofisl pushed a commit that referenced this pull request Nov 11, 2022

docs(node): support "stable"/"preview" release level (#1312) (#387)

3865586

sofisl mentioned this pull request Nov 16, 2022

migrate code from googleapis/nodejs-recaptcha-enterprise #3645

Merged

4 tasks

sofisl mentioned this pull request Nov 30, 2022

migrate code from googleapis/nodejs-datacatalog #3689

Merged

4 tasks

sofisl mentioned this pull request Jan 17, 2023

migrate code from googleapis/nodejs-vision #3860

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Jan 17, 2023

docs: expand documentation on product descriptions (#387)

45e6ecc

sofisl mentioned this pull request Sep 13, 2023

migrate code from googleapis/nodejs-automl #4655

Closed

4 tasks

sofisl mentioned this pull request Sep 14, 2023

migrate code from googleapis/nodejs-automl #4656

Merged

4 tasks

sofisl mentioned this pull request Sep 14, 2023

migrate code from googleapis/nodejs-dns #4657

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow explicit set of method on Dataset#save #387

Allow explicit set of method on Dataset#save #387

ryanseys commented Feb 8, 2015

stephenplusplus commented Feb 9, 2015

ryanseys commented Feb 9, 2015

stephenplusplus commented Feb 9, 2015

ryanseys commented Feb 11, 2015

This comment was marked as spam.

stephenplusplus commented Feb 12, 2015

This comment was marked as spam.

This comment was marked as spam.

Allow explicit set of method on Dataset#save #387

Allow explicit set of method on Dataset#save #387

Conversation

ryanseys commented Feb 8, 2015

stephenplusplus commented Feb 9, 2015

ryanseys commented Feb 9, 2015

stephenplusplus commented Feb 9, 2015

ryanseys commented Feb 11, 2015

This comment was marked as spam.

stephenplusplus commented Feb 12, 2015

This comment was marked as spam.

This comment was marked as spam.