Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Enable requesting numeric enums in "transport=rest" responses for services supporting this (Java, Go, Python, PHP, TypeScript, C#, and Ruby), even if they do not yet turn on REST transport #3660

Merged

Conversation

gcf-owl-bot[bot]
Copy link
Contributor

@gcf-owl-bot gcf-owl-bot bot commented Nov 17, 2022

  • Regenerate this pull request now.

chore: disallow "transport=rest" for services where numeric enums are not confirmed to be supported (except in PHP and Java)
PiperOrigin-RevId: 493113566

Source-Link: googleapis/googleapis@758f0d1

Source-Link: https://github.com/googleapis/googleapis-gen/commit/78bd8f05e1276363eb14eae70e91fe4bc20703ab
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWJpZ3F1ZXJ5LWRhdGF0cmFuc2Zlci8uT3dsQm90LnlhbWwiLCJoIjoiNzhiZDhmMDVlMTI3NjM2M2ViMTRlYWU3MGU5MWZlNGJjMjA3MDNhYiJ9

BEGIN_NESTED_COMMIT
feat: added Location API methods
docs: updated comments

PiperOrigin-RevId: 489094434

Source-Link: googleapis/googleapis@71673d8

Source-Link: https://github.com/googleapis/googleapis-gen/commit/10177232d420006610ae9fb740d9f13efe975cb9
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWJpZ3F1ZXJ5LWRhdGF0cmFuc2Zlci8uT3dsQm90LnlhbWwiLCJoIjoiMTAxNzcyMzJkNDIwMDA2NjEwYWU5ZmI3NDBkOWYxM2VmZTk3NWNiOSJ9
END_NESTED_COMMIT

docs: updated comments

PiperOrigin-RevId: 489094434

Source-Link: googleapis/googleapis@71673d8

Source-Link: googleapis/googleapis-gen@1017723
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWJpZ3F1ZXJ5LWRhdGF0cmFuc2Zlci8uT3dsQm90LnlhbWwiLCJoIjoiMTAxNzcyMzJkNDIwMDA2NjEwYWU5ZmI3NDBkOWYxM2VmZTk3NWNiOSJ9
@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner November 17, 2022 05:00
@snippet-bot
Copy link

snippet-bot bot commented Nov 17, 2022

No region tags are edited in this PR.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@dpebot
Copy link
Collaborator

dpebot commented Nov 17, 2022

/gcbrun

…for services supporting this (Java, Go, Python, PHP, TypeScript, C#, and Ruby), even if they do not yet turn on REST transport

chore: disallow "transport=rest" for services where numeric enums are not confirmed to be supported (except in PHP and Java)
PiperOrigin-RevId: 493113566

Source-Link: googleapis/googleapis@758f0d1

Source-Link: googleapis/googleapis-gen@78bd8f0
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWJpZ3F1ZXJ5LWRhdGF0cmFuc2Zlci8uT3dsQm90LnlhbWwiLCJoIjoiNzhiZDhmMDVlMTI3NjM2M2ViMTRlYWU3MGU5MWZlNGJjMjA3MDNhYiJ9
@gcf-owl-bot gcf-owl-bot bot changed the title feat: added Location API methods chore: Enable requesting numeric enums in "transport=rest" responses for services supporting this (Java, Go, Python, PHP, TypeScript, C#, and Ruby), even if they do not yet turn on REST transport Dec 6, 2022
@dpebot
Copy link
Collaborator

dpebot commented Dec 6, 2022

/gcbrun

@dpebot
Copy link
Collaborator

dpebot commented Dec 6, 2022

/gcbrun

@dpebot
Copy link
Collaborator

dpebot commented Dec 6, 2022

/gcbrun

@dpebot
Copy link
Collaborator

dpebot commented Dec 6, 2022

/gcbrun

@sofisl sofisl merged commit ddbc5a0 into main Dec 6, 2022
@sofisl sofisl deleted the owl-bot-copy-packages-google-cloud-bigquery-datatransfer branch December 6, 2022 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants