Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pubsub: nack overflow messages #2650

Merged
merged 2 commits into from
Oct 5, 2017
Merged

pubsub: nack overflow messages #2650

merged 2 commits into from
Oct 5, 2017

Conversation

callmehiphop
Copy link
Contributor

Closes #2638

@callmehiphop callmehiphop added the api: pubsub Issues related to the Pub/Sub API. label Oct 3, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 3, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 4586452 on callmehiphop:dg--pubsub-flowcontrol-nacks into f2a3c0a on GoogleCloudPlatform:master.

@callmehiphop
Copy link
Contributor Author

paging dr. @stephenplusplus!

@googleapis googleapis deleted a comment from coveralls Oct 5, 2017
@callmehiphop callmehiphop merged commit b3e3fc3 into googleapis:master Oct 5, 2017
@renovate renovate bot mentioned this pull request Feb 20, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephenplusplus stephenplusplus stephenplusplus approved these changes

@lukesneeringer lukesneeringer Awaiting requested review from lukesneeringer

Assignees
No one assigned
Labels
api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@callmehiphop @coveralls @stephenplusplus @googlebot