Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Video Intelligence 0.3.2 #2625

Merged
merged 6 commits into from
Sep 21, 2017
Merged

Video Intelligence 0.3.2 #2625

merged 6 commits into from
Sep 21, 2017

Conversation

lukesneeringer
Copy link
Contributor

@lukesneeringer lukesneeringer commented Sep 21, 2017 •
edited
Loading

This release fixes a bug with long-running operations.

Closes #2622.

@lukesneeringer lukesneeringer self-assigned this Sep 21, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 21, 2017
landrito
landrito approved these changes Sep 21, 2017
View reviewed changes
Copy link
Contributor

@landrito landrito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit. LGTM

packages/video-intelligence/src/index.js Outdated
@@ -27,10 +21,12 @@ var gapic = {
v1beta2: require('./v1beta2'),
};
var gaxGrpc = require('google-gax').grpc();
var googleProtoFiles = require('google-proto-files');

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

stephenplusplus
stephenplusplus previously requested changes Sep 21, 2017
View reviewed changes
packages/video-intelligence/src/index.js Outdated
@@ -13,12 +13,6 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/

/*!

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

packages/video-intelligence/src/index.js Outdated
'google/cloud/videointelligence/v1beta2/video_intelligence.proto')
).google.cloud.videointelligence.v1beta2);
extend(v1beta1Protos, gaxGrpc.loadProto(
path.join(__dirname, '..', 'protos'), 'google/cloud/videointelligence/v1beta1/video_intelligence.proto')

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

packages/video-intelligence/package.json Outdated
@@ -26,10 +26,13 @@
],
"dependencies": {
"extend": "^3.0",
"google-gax": "^0.13.5"
"google-gax": "^0.14.0",
"google-proto-files": "^0.12.0",

This comment was marked as spam.

Sign in to view

packages/video-intelligence/src/v1beta1/video_intelligence_service_client.js
@@ -76,11 +78,19 @@ function VideoIntelligenceServiceClient(gaxGrpc, loadedProtos, opts) {
grpc: gaxGrpc.grpc
}).operationsClient(opts);

var protoFilesRoot = new gax.grpc.GoogleProtoFilesRoot();
protoFilesRoot = protobuf.loadSync(

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

packages/video-intelligence/package.json Outdated
},
"devDependencies": {
"mocha": "^3.2.0"
"mocha": "^3.2.0",
"through2": "^2.0.3"

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 007a1c4 on lukesneeringer:video-0.3.2 into 5690043 on GoogleCloudPlatform:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 8f35a2e on lukesneeringer:video-0.3.2 into 5690043 on GoogleCloudPlatform:master.

@lukesneeringer lukesneeringer merged commit 3d27c83 into googleapis:master Sep 21, 2017
@lukesneeringer lukesneeringer deleted the video-0.3.2 branch September 21, 2017 18:11
sofisl pushed a commit that referenced this pull request Sep 27, 2022
@lukesneeringer
Video Intelligence 0.3.2 (#2625)
567cbd0
@sofisl sofisl mentioned this pull request Sep 27, 2022
Closed
4 tasks
This was referenced Nov 9, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@landrito landrito landrito approved these changes

@stephenplusplus stephenplusplus stephenplusplus left review comments

Assignees

@lukesneeringer lukesneeringer

Labels
api: video-intelligence cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lukesneeringer @coveralls @stephenplusplus @landrito @googlebot