logging-winston: make winston a peerDependency #2453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users of this library need to depend on winston directly. There are scenarios where the user, or other libraries may depend on a semver incompatible version of winston. Not only does it end up installing an unnecessary copy of winston; it may also lead to our transport not being visible in `winston.transports` that the user has visibility to.
googlebot
added
the
cla: yes
|
This is breaking, so this should bump up the logging-winston module to 0.5.0. |
|
Need a release now? |
|
Hold off for #2454. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users of this library need to depend on winston directly. There are
scenarios where the user, or other libraries may depend on a semver
incompatible version of winston. Not only does it end up installing an
unnecessary copy of winston; it may also lead to our transport not
being visible in
winston.transportsthat the user has visibility to.