DLP library (GAPIC-only) #2323

lukesneeringer · 2017-05-21T18:37:20Z

@ace-n Here is the DLP library to write samples against.

@swcloud Can you add the protos to the common protos package? Coordinate that with @stephenplusplus (who will teach you how to do it).

We also need a README. We can autogen one once googleapis/gapic-generator#1240 is merged.

swcloud · 2017-05-22T06:19:32Z

@lukesneeringer Do we know if the gapic-only client library is able to handle 'lint', 'unit test', 'snippet test' and 'system test'. I think these are needed in order to pass CI build. At least we need to ignore if they cannot pass.

packages/dlp/package.json

@@ -0,0 +1,40 @@
+{
+  "repository": "GoogleCloudPlatform/google-cloud-node",
+  "name": "dlp",


packages/dlp/package.json

+  ],
+  "dependencies": {
+    "google-proto-files": "^0.12.0",
+    "google-gax": "^0.12.2",


packages/dlp/src/index.js

@@ -0,0 +1,51 @@
+/*
+ * Copyright 2016 Google Inc. All rights reserved.


packages/dlp/src/index.js

+}
+
+module.exports = dlp_v2beta1;
+module.exports.v2beta1 = dlp_v2beta1;


packages/dlp/src/index.js

+ *   The customized config to build the call settings. See
+ *   {@link gax.constructSettings} for the format.
+ */
+function dlp_v2beta1(opts) {


packages/dlp/src/index.js

+ * Create an dlpServiceClient with additional helpers for common
+ * tasks.
+ *
+ * @param {Object=} opts - The optional parameters.


packages/dlp/src/v2beta1/dlp_service_client.js

+];
+
+/**
+ * The DLP API is a service that allows clients


swcloud · 2017-05-22T17:30:37Z

@landrito Please review @stephenplusplus's comments so that we can add those to the auto-generated code.

landrito · 2017-05-22T17:33:02Z

Looking!

swcloud · 2017-05-23T01:09:41Z

@lukesneeringer Confirmed that dlp proto files are already in google-proto-files package.

lukesneeringer · 2017-05-23T19:41:30Z

@lukesneeringer Do we know if the gapic-only client library is able to handle 'lint', 'unit test', 'snippet test' and 'system test'. I think these are needed in order to pass CI build. At least we need to ignore if they cannot pass.

Unit tests should pass.

I configured the linter to ignore auto-generated files. If we are failing on the linter, we need to double-check that and make sure they are being ignored.

Not sure about snippet and system tests. I am not aware of those being generated for GAPICs.

packages/dlp/package.json

+  "description": "DLP API client for Node.js",
+  "main": "src/index.js",
+  "files": [
+    "src"


packages/dlp/package.json

+    "extend": "^3.0.0"
+  },
+  "devDependencies": {
+    "mocha": "3.2.0",


packages/dlp/package.json

+    "through2": "2.0.3"
+  },
+  "scripts": {
+    "test": "mocha"


stephenplusplus · 2017-05-23T20:20:02Z

Can we generate a README for this like in #2327?

landrito · 2017-05-23T20:23:10Z

@stephenplusplus I'll add these changes to the generator soon.

packages/dlp/src/v2beta1/dlp_service_client.js

+    return new DlpServiceClientBuilder(gaxGrpc);
+  }
+
+  var dlpServiceClient = require('grpc-google-privacy-dlp-v2beta1').client;


ace-n

See @stephenplusplus comment here.

landrito · 2017-05-25T20:41:48Z

Regenerated with all the toolkit fixes!

packages/dlp/package.json

-  "name": "dlp",
-  "version": "0.0.0",
+  "name": "@google-cloud/dlp",
+  "version": "0.7.1",


packages/dlp/package.json

  "author": "Google Inc",
  "description": "DLP API client for Node.js",
+  "url": "https://github.com/googleapis/googleapis",


packages/dlp/package.json

@@ -22,16 +26,17 @@
    "DLP API"
  ],
  "dependencies": {
-    "google-proto-files": "^0.12.0",
-    "google-gax": "^0.12.2",
+    "google-proto-files": "^0.8.6",


packages/dlp/README.md

+
+### Installation
+```
+$ npm install @google-cloud/dlp


packages/dlp/README.md

+In order to use this library, you first need to go through the following steps:
+
+1. [Select or create a Cloud Platform project.](https://console.cloud.google.com/project)
+2. [Enable the dlp api.](https://console.cloud.google.com/apis/api/dlp)


scripts/docs/config.js

@@ -63,6 +63,9 @@ module.exports = {
    datastore: {
      title: 'Cloud Datastore'
    },
+    dlp: {


scripts/helpers.js

@@ -239,6 +239,7 @@ Module.prototype.runSystemTests = function() {
  var modulesExcludedFromSystemTests = [
    'common',
    'common-grpc',
+    'dlp',


packages/dlp/test/gapic-v2beta1.js

+      client.createInspectOperation(request, function(err, response) {
+        assert.ifError(err);
+        assert.deepStrictEqual(response, expectedResponse);
+        done();


Found lint errors.

stephenplusplus · 2017-06-01T01:07:21Z

Some linting errors: https://ci.appveyor.com/project/GoogleCloudPlatform/google-cloud-node/build/1.0.1850/job/j9m6jw0u2wiy346o

$ npm run lint
packages\dlp\test\test-v2beta1.js: line 25, col 3, Missing "use strict" statement.
packages\dlp\test\test-v2beta1.js: line 62, col 52, 'response' is defined but never used.
packages\dlp\test\test-v2beta1.js: line 111, col 51, 'response' is defined but never used.
packages\dlp\test\test-v2beta1.js: line 170, col 24, 'responses' is defined but never used.
packages\dlp\test\test-v2beta1.js: line 184, col 55, Strings must use singlequote.
packages\dlp\test\test-v2beta1.js: line 208, col 55, Strings must use singlequote.
packages\dlp\test\test-v2beta1.js: line 216, col 57, 'response' is defined but never used.
packages\dlp\test\test-v2beta1.js: line 261, col 51, 'response' is defined but never used.
packages\dlp\test\test-v2beta1.js: line 302, col 56, 'response' is defined but never used.
packages\dlp\test\test-v2beta1.js: line 313, col 3, Missing "use strict" statement.
packages\dlp\test\test-v2beta1.js: line 326, col 3, Missing "use strict" statement.
packages\dlp\test\test-v2beta1.js: line 332, col 26, Missing semicolon.

stephenplusplus · 2017-06-01T01:08:39Z

I believe there is a pattern matching expression set to exclude files prefixed with "gapic-". That's what the test file was formerly called, but it is now "test-". If we switch it back, it should be good.

lukesneeringer · 2017-06-01T16:54:43Z

I believe there is a pattern matching expression set to exclude files prefixed with "gapic-". That's what the test file was formerly called, but it is now "test-". If we switch it back, it should be good.

Yeah, I had been renaming that manually (for the precise reason of being able to do a precise exclusion). @landrito, any chance we could change that in toolkit?

* Fix the long running operation method * fix lint error

packages/dlp/test/test-v2beta1.js

@@ -0,0 +1,341 @@
+/*


This reverts commit 3213175.

packages/dlp/test/gapic_v2beta1.js

@@ -0,0 +1,341 @@
+/*


coveralls · 2017-06-02T22:51:51Z

Coverage remained the same at 99.925% when pulling 554e361 on dlp into d152416 on master.

DLP library (GAPIC-only)

7121b38

lukesneeringer self-assigned this May 21, 2017

lukesneeringer requested review from stephenplusplus, ace-n and swcloud May 21, 2017 18:37

googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 21, 2017

stephenplusplus reviewed May 22, 2017

View reviewed changes

packages/dlp/src/v2beta1/dlp_service_client.js

];

/**

* The DLP API is a service that allows clients

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

swcloud requested a review from landrito May 22, 2017 17:29

ace-n approved these changes May 23, 2017

View reviewed changes

stephenplusplus reviewed May 23, 2017

View reviewed changes

packages/dlp/package.json Outdated

"description": "DLP API client for Node.js",

"main": "src/index.js",

"files": [

"src"

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

stephenplusplus reviewed May 23, 2017

View reviewed changes

packages/dlp/package.json Outdated

"extend": "^3.0.0"

},

"devDependencies": {

"mocha": "3.2.0",

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

stephenplusplus reviewed May 23, 2017

View reviewed changes

packages/dlp/package.json Outdated

"through2": "2.0.3"

},

"scripts": {

"test": "mocha"

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

stephenplusplus reviewed May 23, 2017

View reviewed changes

packages/dlp/src/v2beta1/dlp_service_client.js Outdated

return new DlpServiceClientBuilder(gaxGrpc);

}

var dlpServiceClient = require('grpc-google-privacy-dlp-v2beta1').client;

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

ace-n suggested changes May 23, 2017

View reviewed changes

New autogen.

8b6f34a

This was referenced May 24, 2017

NodeJS: Use correct casing for partial veneers googleapis/gapic-generator#1295

Merged

NodeJS: Update partial veneer surface to add api documentation. googleapis/gapic-generator#1296

Merged

Regen

950d332

stephenplusplus suggested changes May 25, 2017

View reviewed changes

This was referenced May 25, 2017

NodeJS: bump generated dlp version googleapis/googleapis#357

Merged

NodeJS: Metadata updates. googleapis/gapic-generator#1298

Merged

googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label May 26, 2017

stephenplusplus reviewed May 26, 2017

View reviewed changes

scripts/docs/config.js

@@ -63,6 +63,9 @@ module.exports = {

datastore: {

title: 'Cloud Datastore'

},

dlp: {

This comment was marked as spam.

Sign in to view

stephenplusplus reviewed May 26, 2017

View reviewed changes

scripts/helpers.js

@@ -239,6 +239,7 @@ Module.prototype.runSystemTests = function() {

var modulesExcludedFromSystemTests = [

'common',

'common-grpc',

'dlp',

This comment was marked as spam.

Sign in to view

stephenplusplus reviewed May 26, 2017

View reviewed changes

packages/dlp/test/gapic-v2beta1.js Outdated

client.createInspectOperation(request, function(err, response) {

assert.ifError(err);

assert.deepStrictEqual(response, expectedResponse);

done();

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Fix the long running operation method (#2346)

9c2a6ad

stephenplusplus previously approved these changes Jun 1, 2017

View reviewed changes

Dlp (#2347)

3213175

* Fix the long running operation method * fix lint error

stephenplusplus reviewed Jun 2, 2017

View reviewed changes

packages/dlp/test/test-v2beta1.js Outdated

@@ -0,0 +1,341 @@

/*

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

swcloud added 2 commits June 1, 2017 18:21

Revert "Dlp (#2347)" (#2348)

5d44259

This reverts commit 3213175.

fix git mistake

d880a56

stephenplusplus reviewed Jun 2, 2017

View reviewed changes

stephenplusplus added the dlp label Jun 2, 2017

swcloud removed the cla: no This human has *not* signed the Contributor License Agreement. label Jun 2, 2017

rename gapic_v2beta1.js to gapic-v2beta1.js

554e361

googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Jun 2, 2017

swcloud removed the cla: no This human has *not* signed the Contributor License Agreement. label Jun 2, 2017

stephenplusplus merged commit ba25793 into master Jun 4, 2017

stephenplusplus deleted the dlp branch June 4, 2017 17:30

This was referenced Jul 5, 2017

Update dependency @google-cloud/datastore to version 1.0.7 Platane/velib-paris#24

Merged

Update dependency @google-cloud/storage to version 1.2.0 Platane/velib-paris#25

Merged

stephenplusplus added api: dlp Issues related to the Sensitive Data Protection API. and removed dlp labels Aug 18, 2017

sofisl mentioned this pull request Jan 10, 2023

migrate code from googleapis/nodejs-dlp #3837

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Jan 10, 2023

DLP library (GAPIC-only) (#2323)

a482870

mikolajroszak mentioned this pull request May 7, 2024

[Snyk] Upgrade yargs from 13.3.2 to 17.7.2 mikolajroszak/google-cloud-node#6

Open

		@@ -0,0 +1,51 @@
		/*
		* Copyright 2016 Google Inc. All rights reserved.

DLP library (GAPIC-only) #2323

DLP library (GAPIC-only) #2323

Conversation

lukesneeringer commented May 21, 2017

swcloud commented May 22, 2017

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

swcloud commented May 22, 2017

landrito commented May 22, 2017

swcloud commented May 23, 2017

lukesneeringer commented May 23, 2017

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

stephenplusplus commented May 23, 2017

landrito commented May 23, 2017

This comment was marked as spam.

This comment was marked as spam.

ace-n left a comment

Choose a reason for hiding this comment

landrito commented May 25, 2017

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

stephenplusplus commented Jun 1, 2017

stephenplusplus commented Jun 1, 2017

lukesneeringer commented Jun 1, 2017 • edited Loading

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

coveralls commented Jun 2, 2017

lukesneeringer commented Jun 1, 2017 •

edited

Loading