Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vision: Add 'gccl' header. #2228

Merged
merged 2 commits into from
Apr 17, 2017
Merged

Conversation

landrito
Copy link
Contributor

@landrito landrito commented Apr 17, 2017

Updates #2225

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 17, 2017
@stephenplusplus stephenplusplus added the api: vision Issues related to the Cloud Vision API. label Apr 17, 2017
Copy link
Contributor

@stephenplusplus stephenplusplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@landrito landrito mentioned this pull request Apr 17, 2017
@landrito
Copy link
Contributor Author

Will do!

@stephenplusplus
Copy link
Contributor

One of the tests wasn't happy:


  1) Vision instantiation should create a gax api client:

      AssertionError: { projectId: 'project-id',
  libName: 'gccl',
  libVersion: '0.11.1' } === { projectId: 'project-id' }
      + expected - actual

       {
      -  "libName": "gccl"
      -  "libVersion": "0.11.1"
         "projectId": "project-id"
       }
      
      at Object.imageAnnotatorClient (test/index.js:117:20)
      at new Vision (src/index.js:69:25)
      at Context.<anonymous> (test/index.js:123:20)

https://circleci.com/gh/GoogleCloudPlatform/google-cloud-node/812?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

@landrito
Copy link
Contributor Author

Fixed.

@stephenplusplus stephenplusplus merged commit c0a3e41 into googleapis:master Apr 17, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 70970b9 on landrito:vision into 1d1f491 on GoogleCloudPlatform:master.

sofisl pushed a commit that referenced this pull request Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: vision Issues related to the Cloud Vision API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants