fix(connection): set token expiration date for GCE #213

stephenplusplus · 2014-09-17T00:50:58Z

A response from the GCE metadata server responds with data in a
different format from that of the GAPIToken() request. Instead of
looking for a property that doesn't exist token_expires, we now
calculate the expiration timestamp from expires_in.

For more, see Authenticating from Google Compute Engine.

Fixes #212

ryanseys · 2014-09-17T04:01:21Z

Can you please add a test?

stephenplusplus · 2014-09-17T15:26:58Z

Good thinking. Added 👍

A response from the GCE metadata server responds with data in a different format from that of the GAPIToken() request. Instead of looking for a property that doesn't exist `token_expires`, we now calculate the expiration timestamp from `expires_in`. For more, see [Authenticating from Google Compute Engine][auth]. [auth]:https://developers.google.com/compute/docs/authentication#applications Fixes googleapis#212

test/common/connection.js

+        gceConn.fetchToken();
+      });
+
+      it('should build token from the metadata server response', function() {


lib/common/connection.js

@@ -165,7 +165,7 @@ Connection.prototype.fetchToken = function(callback) {
        callback(err);
        return;
      }
-      var exp = new Date(body.token_expires * 1000);
+      var exp = new Date(Date.now() + body.expires_in * 1000);


silvolu · 2014-09-23T17:55:46Z

Yes, I think we should re-request the token, and the approach you suggest is definitely better. We should catch 401s "Invalid credentials" and refetch the token, as described here.

stephenplusplus · 2014-09-23T17:56:41Z

Cool. I'll send a separate PR for that.

silvolu · 2014-09-23T17:58:37Z

SGTM. Merging this one.

ryanseys · 2014-09-23T18:14:31Z

SGTM. Merge it up.

fix(connection): set token expiration date for GCE

* chore: release 2.10.0 * 🦉 Updates from OwlBot Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* feat!: Update library to use Node 12 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Olivier Bourgeois <[email protected]>

This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/8d5e906d-0de4-4e28-b374-7d5fd4a1ce62/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@1c92077

* feat: support version reporting API PiperOrigin-RevId: 393476621 Source-Link: googleapis/googleapis@e9da6f8 Source-Link: googleapis/googleapis-gen@acd7bed * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* test: use fully qualified request type name in tests PiperOrigin-RevId: 475685359 Source-Link: googleapis/googleapis@7a12973 Source-Link: googleapis/googleapis-gen@370c729 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMzcwYzcyOWUyYmEwNjJhMTY3NDQ5YzI3ODgyYmE1ZjM3OWM1YzM0ZCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Update .repo-metadata.json as required by go/library-data-integrity

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [webpack](https://togithub.com/webpack/webpack) | devDependencies | major | [`^4.41.2` -> `^5.0.0`](https://renovatebot.com/diffs/npm/webpack/4.44.2/5.1.0) | --- ### Release Notes <details> <summary>webpack/webpack</summary> ### [`v5.1.0`](https://togithub.com/webpack/webpack/releases/v5.1.0) [Compare Source](https://togithub.com/webpack/webpack/compare/v5.0.0...v5.1.0) ### Features - expose `webpack` property from `Compiler` - expose `cleverMerge`, `EntryOptionPlugin`, `DynamicEntryPlugin` ### Bugfixes - missing `require("..").xxx` in try-catch produces a warning instead of an error now - handle reexports in concatenated modules correctly when they are side-effect-free - fix incorrect deprecation message for ModuleTemplate.hooks.hash ### [`v5.0.0`](https://togithub.com/webpack/webpack/releases/v5.0.0) [Compare Source](https://togithub.com/webpack/webpack/compare/v4.44.2...v5.0.0) [Announcement and changelog](https://webpack.js.org/blog/2020-10-10-webpack-5-release/) </details> --- ### Renovate configuration :date: **Schedule**: "after 9am and before 3pm" (UTC). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-recaptcha-enterprise).

This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/9b1f5306-e1f1-4834-baa7-c436ccd06c13/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@5451633

* build: check dead links on Kokoro * recursive crawl local links * fix dead timestamp links

Note: normally removing an annotation is a breaking change. However, the annotation here is invalid as it doesn't refer to a string field. Any generator which actually tried to use it in a meaningful way would either generate invalid code or fail to generate at all. Therefore removing it can't break anything. PiperOrigin-RevId: 404455880 Source-Link: googleapis/googleapis@dc83df8 Source-Link: googleapis/googleapis-gen@f0d78f4 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZjBkNzhmNDk3OTc5YjBkN2Q2YjkzNTg3ZDkwNGM4NDY0NTEyODUzZSJ9

beriberikix added the in progress label Sep 17, 2014

stephenplusplus force-pushed the gce-token branch 2 times, most recently from 8be5e2d to ec5f537 Compare September 17, 2014 00:59

stephenplusplus force-pushed the gce-token branch from ec5f537 to 9ab8488 Compare September 17, 2014 15:26

stephenplusplus force-pushed the gce-token branch from 9ab8488 to 2eb9903 Compare September 17, 2014 22:36

stephenplusplus reviewed Sep 17, 2014
View reviewed changes

test/common/connection.js

gceConn.fetchToken();

});

it('should build token from the metadata server response', function() {

This comment was marked as spam.

Sign in to view

ryanseys mentioned this pull request Sep 19, 2014

fix(connection) changed token expiration calculation - issue #212 #230

Closed

stephenplusplus added ready for review and removed in progress labels Sep 19, 2014

silvolu reviewed Sep 23, 2014
View reviewed changes

silvolu added a commit that referenced this pull request Sep 23, 2014

Merge pull request #213 from stephenplusplus/gce-token

23abd11

fix(connection): set token expiration date for GCE

silvolu merged commit 23abd11 into googleapis:master Sep 23, 2014

beriberikix removed the ready for review label Sep 23, 2014

snyk-bot mentioned this pull request Jan 31, 2020

[Snyk] Fix for 1 vulnerabilities enterstudio/google-cloud-node#73

Open

snyk-bot mentioned this pull request Aug 16, 2020

[Snyk] Security upgrade gcs-resumable-upload from 0.7.7 to 2.1.1 enterstudio/google-cloud-node#103

Open

sofisl mentioned this pull request Sep 15, 2022

migrate code from googleapis/nodejs-redis #3360

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Sep 15, 2022

chore: update pull request template (#213)

c8b8f80

sofisl mentioned this pull request Sep 16, 2022

migrate code from googleapis/nodejs-os-login #3366

Closed

4 tasks

sofisl pushed a commit that referenced this pull request Sep 16, 2022

chore(deps): update linters (#213)

70a6547

sofisl pushed a commit that referenced this pull request Oct 5, 2022

chore(deps): update linters (#213)

b027e0b

sofisl mentioned this pull request Oct 5, 2022

migrate code from googleapis/nodejs-os-login #3388

Closed

4 tasks

sofisl pushed a commit that referenced this pull request Oct 5, 2022

chore(deps): update linters (#213)

7882575

sofisl mentioned this pull request Oct 8, 2022

migrate code from googleapis/nodejs-os-login #3389

Closed

4 tasks

This was referenced Nov 11, 2022

migrate code from googleapis/nodejs-grafeas #3551

Merged

migrate code from googleapis/nodejs-secret-manager #3553

Merged

migrate code from googleapis/nodejs-document-ai #3559

Merged

This was referenced Nov 11, 2022

migrate code from googleapis/nodejs-os-config #3560

Merged

migrate code from googleapis/nodejs-analytics-data #3562

Merged

sofisl added a commit that referenced this pull request Nov 11, 2022

build!: update library to use Node 12 (#213)

321f4f0

* feat!: Update library to use Node 12 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

sofisl pushed a commit that referenced this pull request Nov 11, 2022

chore: release 2.2.0 (#213)

36e9cb0

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Olivier Bourgeois <[email protected]>

This was referenced Nov 11, 2022

migrate code from googleapis/nodejs-cloudbuild #3566

Merged

migrate code from googleapis/nodejs-talent #3568

Merged

This was referenced Nov 11, 2022

migrate code from googleapis/nodejs-game-servers #3569

Merged

migrate code from googleapis/nodejs-video-transcoder #3571

Merged

sofisl mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-analytics-admin #3600

Merged

4 tasks

sofisl mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-dialogflow-cx #3602

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Nov 11, 2022

chore: add api_shortname and library_type to repo metadata (#213)

c63796f

Update .repo-metadata.json as required by go/library-data-integrity

sofisl mentioned this pull request Nov 16, 2022

migrate code from googleapis/nodejs-recaptcha-enterprise #3645

Merged

4 tasks

sofisl mentioned this pull request Nov 30, 2022

migrate code from googleapis/nodejs-datacatalog #3689

Merged

4 tasks

sofisl mentioned this pull request Jan 10, 2023

migrate code from googleapis/nodejs-dlp #3837

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Jan 10, 2023

build: check broken links in generated docs (#213)

04401bd

* build: check dead links on Kokoro * recursive crawl local links * fix dead timestamp links

sofisl mentioned this pull request Jan 17, 2023

migrate code from googleapis/nodejs-vision #3860

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Jan 17, 2023

chore(deps): update dependency eslint-plugin-prettier to v3 (#213)

6763ddc

sofisl mentioned this pull request Jan 26, 2023

migrate code from googleapis/nodejs-ai-platform #3892

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(connection): set token expiration date for GCE #213

fix(connection): set token expiration date for GCE #213

stephenplusplus commented Sep 17, 2014

ryanseys commented Sep 17, 2014

stephenplusplus commented Sep 17, 2014

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

silvolu commented Sep 23, 2014

stephenplusplus commented Sep 23, 2014

silvolu commented Sep 23, 2014

ryanseys commented Sep 23, 2014

fix(connection): set token expiration date for GCE #213

fix(connection): set token expiration date for GCE #213

Conversation

stephenplusplus commented Sep 17, 2014

ryanseys commented Sep 17, 2014

stephenplusplus commented Sep 17, 2014

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

silvolu commented Sep 23, 2014

stephenplusplus commented Sep 23, 2014

silvolu commented Sep 23, 2014

ryanseys commented Sep 23, 2014