Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vision: revert friendly names to API names #1858

Merged
merged 3 commits into from
Dec 5, 2016

Conversation

stephenplusplus
Copy link
Contributor

@stephenplusplus stephenplusplus commented Dec 5, 2016

Fixes #1857

This reverts our friendly/ambiguous re-mapping of API terminology.

Old Us New Us (same as API)
blurry blurred
dark underExposed
hat headwear
happy joy
sad sorrow
mad anger
surprised surprise

@stephenplusplus stephenplusplus added the api: vision Issues related to the Cloud Vision API. label Dec 5, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 5, 2016
joy: faceAnnotation.joyLikelihood,
sorrow: faceAnnotation.sorrowLikelihood,
surprise: faceAnnotation.surpriseLikelihood,
underExposed: faceAnnotation.underExposedLikelihood

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

@@ -1486,6 +1466,37 @@ describe('Vision', function() {
});
});

describe('gteLikelihood_', function() {

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

@callmehiphop callmehiphop merged commit ac87e18 into googleapis:master Dec 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: vision Issues related to the Cloud Vision API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants