Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compute: implement machineType #1441

Closed
wants to merge 7 commits into from
Closed

compute: implement machineType #1441

wants to merge 7 commits into from

Conversation

ashleyschuett
Copy link
Contributor

@ashleyschuett ashleyschuett commented Jul 19, 2016 •
edited by stephenplusplus
Loading

For #1073

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 19, 2016
@stephenplusplus
Copy link
Contributor

Thank you so much!

@stephenplusplus stephenplusplus added the api: compute Issues related to the Compute Engine API. label Jul 19, 2016
Gormartsen
Gormartsen reviewed Jul 20, 2016
View reviewed changes
system-test/compute.js
it('should get a list of machineTypes in stream mode', function(done) {
var resultsMatched = 0;

compute.getZones()

This comment was marked as spam.

Sign in to view

@stephenplusplus
Copy link
Contributor

PR'd the PR for some small stuff: https://github.com/containership/gcloud-node/pull/3

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Jul 21, 2016
@stephenplusplus stephenplusplus added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jul 21, 2016
@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Jul 21, 2016
@stephenplusplus stephenplusplus added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jul 21, 2016
@coveralls
Copy link

coveralls commented Jul 21, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 22f573a on containership:machine-type into 6cbbc37 on GoogleCloudPlatform:master.

@stephenplusplus
Copy link
Contributor

Yay, Travis is happy! This PR is good to go, however we're in a small code freeze as we prepare for the modularization shift introduced in #1431. After that lands, I'll do the converting to the new type and send yet another PR to your fork.

@stephenplusplus
Copy link
Contributor

Merged via 0f46879 -- thanks again!

@snyk-bot snyk-bot mentioned this pull request Sep 15, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: compute Issues related to the Compute Engine API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ashleyschuett @stephenplusplus @coveralls @Gormartsen @googlebot @authtestprod