Incorrect missing project ID error URL

[bamapookie]

The URL in the error message does not actually take you to the authentication documentation. Fixed in the fork.

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please let us know the company's name.

[bamapookie]

I signed it.

On Fri, Jul 1, 2016 at 2:28 PM googlebot [email protected] wrote:

Thanks for your pull request. It looks like this may be your first
contribution to a Google open source project. Before we can look at your
pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/
https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll

verify. Thanks.

• If you've already signed a CLA, it's possible we don't have your
  GitHub username or you're using a different email address. Check your
  existing CLA data https://cla.developers.google.com/clas and verify
  that your email is set on your git commits
  https://help.github.com/articles/setting-your-email-in-git/.
• If you signed the CLA as a corporation, please let us know the
  company's name.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#1405 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AB1fPgg1bK8U2qxoytqNul88V0I3m1_Lks5qRVxZgaJpZM4JDYP1
.

[googlebot]

CLAs look good, thanks!

[stephenplusplus]

Thank you for finding this. This is kinda silly, but we have an 80 char rule, so if you don't mind, can you make these changes?

var extend = require('extend');
+ var format = require('string-format-obj');
var googleAuth = require('google-auto-auth');

...

var errorMessage = format([
  'Sorry, we cannot connect to Google Cloud Services without a project ID.',
  'You may specify one with an environment variable named "GCLOUD_PROJECT".',
  'See {baseUrl}/{path} for a detailed guide on creating an authenticated',
  'connection.'
].join(' '), {
  baseUrl: 'https://googlecloudplatform.github.io/gcloud-node/#',
  path: '/docs/guides/authentication'
});

var missingProjectIdError = new Error(errorMessage);

[bamapookie]

Thanks, @stephenplusplus. I was wondering how I was going to make that URL fit. :)

[stephenplusplus]

Awesome, thanks :) And sorry again, but I forgot that we have this test this is going to fail now. That will need the same update. I'm pretty confident that should be it!

[coveralls]

Coverage remained the same at 100.0% when pulling c33c032 on bamapookie:patch-1 into 61b27cb on GoogleCloudPlatform:master.

[stephenplusplus]

Perfect, thank you very much! 💃