datastore: add query.run #1280
Merged
datastore: add query.run #1280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenplusplus
added
api: datastore
googlebot
added
the
cla: yes
|
@callmehiphop ptal! |
| * var query = datastore.createQuery('Person') | ||
| * .hasAncestor(datastore.key(['Person', 1234])) | ||
| * .hasAncestor(datastore.key(['Person', 'Dave'])) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Fixed the docs issue + realized query.run didn't take an |
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1266
To Dos
Previously, a query has only been created through
{module:datastore#createQuery}. But since addingrunon the Query object, we need a reference to the parent object. The only thing that made this a bit tricky was running a query inside of a transaction. That's why this PR has to introduce{module:transaction#createQuery}.