Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation that labels for logging entry has to be STRING #1241

Merged
merged 1 commit into from
Apr 18, 2016

Conversation

faithseed
Copy link
Contributor

The doc says string for instance_id

var resource = {
  type: 'gce_instance',
  labels: {
    zone: 'global',
    instance_id: 3
  }
};

yet in practice, you will hit the following if you pass an int. You will get the following error. This fixes the doc to reflect the correct usage of this API.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 18, 2016
@faithseed
Copy link
Contributor Author

@stephenplusplus please review this change.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling bf2a2f2 on faithseed:faithseed/docs into 5199cad on GoogleCloudPlatform:master.

@stephenplusplus stephenplusplus merged commit 24fbcdc into googleapis:master Apr 18, 2016
@stephenplusplus
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging Issues related to the Cloud Logging API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants