-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compute: implement autoscaler #1137
compute: implement autoscaler #1137
Conversation
5efac05
to
12d00b9
Compare
12d00b9
to
eaefbca
Compare
@@ -439,6 +439,126 @@ Compute.prototype.getAddresses = function(options, callback) { | |||
}; | |||
|
|||
/** | |||
* Get a list of autoscalers. For a detailed description of this method's | |||
* options, see [API reference](https://cloud.google.com/compute/docs/reference/v1/autoscalers/aggregatedList). |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
eaefbca
to
ad61314
Compare
Fixed those things! |
Locally I'm getting an error when testing the docs on
When running against Other than those errors and a few documentation nitpicks, this LGTM! |
My gosh, gRPC is haunting us. I'll try to get that error on 0.12.7. |
If you strictly run |
Nope! |
Although it is still hanging on something |
Please check all that apply: v0.12.7
v5.6.0
As you probably guessed, none of the above happens for me locally. There's obviously something going on, but I don't really know where to start to find it. |
Just for reference, found the origin of the status code error: https://github.com/grpc/grpc/blob/72724bce84b4bc027ce8dd3f7508b9216788434b/src/node/ext/call_credentials.cc#L176 |
If you run the same tests prior to this commit, will you get the same errors? |
I pushed a commit to see if anything improves. Travis is never happy, so I'm not expecting it to win him over. But maybe it'll help what you're getting locally. If it does, I'll send a different PR with that change. |
I don't, I'm somehow magically all green when I run against master. |
It makes no sense, man!! |
I just pulled your latest commit! It helped, lol. |
That's awesome. The only thing I can't line up is why this PR revealed the problem. Oh well, as long as it works for us all, that's all that matters. I'll just add a test for it and we can merge it in with this PR. We talked about it most here anyway, so finding it later, this PR would help. |
SGTM.. I'm a little lost on what's going on, but maybe we should open a new issue for investigating gRPC stuff since it has been giving us weird/random errors. |
5c46a89
to
407fb8f
Compare
Yeah, we can leave #1140 open as a place to log issues that might relate to gRPC. I think this is ready for a merge! |
compute: implement autoscaler
For #1073
Fixes #1152
Implements Autoscaler support.
To Dos
Creating an autoscaler...