core: filter out duplicate error messages #1055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
callmehiphop
added
type: bug
googlebot
added
the
cla: yes
|
To answer your earlier question, I guess this is why this whole idea was kinda weird. Maybe we should just revert the change and only special-case the error messages for Datastore? That's where we saw the vagueness originally. |
|
I think it's still useful, it was really only behaving oddly in Storage, but if you'd rather special-case Datastore, that's cool with me too. |
| @@ -81,13 +81,19 @@ var ApiError = createErrorClass('ApiError', function(errorBody) { | |||
|
|
|||
| if (errorBody.errors && errorBody.errors.length === 1) { | |||
| messages.push(errorBody.errors[0].message); | |||
| } else if (errorBody.response.body) { | |||
| } else if (errorBody.response && errorBody.response.body) { | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
I'm cool with keeping the feature if you see it's useful. Let's see what happens! |
installed array-uniq as dependency
|
Cool. Pretty sure the answer is yes, but did you confirm the system tests are happy now? |
|
Sure did! |
stephenplusplus
added a commit
that referenced
this pull request
Jan 7, 2016
core: filter out duplicate error messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In certain cases we are seeing duplicate error messages. This change will filter out any duplicates to avoid error messages like
Not Found - Not Found.