core: fix unit test stream errors #1028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
So just to clarify, if a spec file requires the use of duplexify, we need to wait to require it after mockery has been enabled? |
|
Actually, after the file using it has been required. |
|
Got it, thanks! That should be a fun "gotcha" for the future, maybe we should look into a mockery alternative. |
callmehiphop
added a commit
that referenced
this pull request
Dec 18, 2015
core: fix unit test stream errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our tests have been bombing lately after a transient dependency made a simple perf change: nodejs/readable-stream@670ddf3
It's loaded through
duplexify, but I'm not sure why it's causing our tests to fail. It's definitely related to being combined withmockery, but I can't pin down exactly... how.But, this PR fixes it.