-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
introduce Translate API #1023
introduce Translate API #1023
Conversation
0d3ac92
to
12d1d4a
Compare
@callmehiphop PTAQL. This one's pretty small. I just want to be sure I'm not doing anything too crazy before locking it up with the unit tests. |
* } | ||
* }); | ||
*/ | ||
Translate.prototype.translate = function(input, language, callback) { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
@stephenplusplus LGTM :) unit test away! |
Thanks for the review! |
var gcloud = require('gcloud'); | ||
|
||
var translate = gcloud.translate({ | ||
key: 'API Key' |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
/cc @ilsung Does Translate work with service account credentials (ie, keyfile.json) ? |
Tests added: stephenplusplus@1ebcde0 |
1ebcde0
to
a72427a
Compare
Marking as blocked until we hear from @ilsung about authenticating with a service account keyfile. (Thanks in advance for your help!) |
a72427a
to
027a4ba
Compare
Sorry for the delay -- No, the Translate API does not support service account creds since it doesn't use OAuth. A key is required. |
Thanks for clearing that up. @callmehiphop if this LGTY, merge away. |
🍰 |
Fixes #977
To Dos
Preview