pubsub: assure topic names are properly used in API requests #1008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenplusplus
added
type: bug
googlebot
added
the
cla: yes
stephenplusplus
force-pushed
the
spp--pubsub-1005
branch
from
012e025
to
c1bfd64
Compare
callmehiphop
added a commit
that referenced
this pull request
Dec 8, 2015
pubsub: assure topic names are properly used in API requests
sofisl
pushed a commit
that referenced
this pull request
Nov 11, 2022
Fixes #1008 Source-Link: googleapis/synthtool@b0535a7 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:bbb8dd6576ac58830a07fc17e9511ae898be44f2219d3344449b125df9854441 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
sofisl
pushed a commit
that referenced
this pull request
Nov 11, 2022
Fixes #1008 Source-Link: googleapis/synthtool@b0535a7 Post-Processor: gcr.io/repo-automation-bots/owlbot-nodejs:latest@sha256:bbb8dd6576ac58830a07fc17e9511ae898be44f2219d3344449b125df9854441 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: kelsk <[email protected]>
sofisl
pushed a commit
that referenced
this pull request
Jan 26, 2023
Fixes #1008 Source-Link: googleapis/synthtool@b0535a7 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:bbb8dd6576ac58830a07fc17e9511ae898be44f2219d3344449b125df9854441 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1005
Fixes #1006
Thanks to @chrishiestand for catching this bug.
We weren't considering that topic names come from two places:
projects/{id}/topics/{id}){id})In either case, the
Topicconstructor comes up with their correct names in each format. But what it wasn't doing was passing the correct version (short format) toServiceObject, which meant in some cases, the full format was being injected into a request URL where the short format was required.