Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pubsub: reused subscriptions should not rely on API response for data #997

Closed
stephenplusplus opened this issue Dec 6, 2015 · 3 comments
Closed

pubsub: reused subscriptions should not rely on API response for data #997

stephenplusplus opened this issue Dec 6, 2015 · 3 comments
Assignees
@yoshi-automation
Labels
api: pubsub Issues related to the Pub/Sub API. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@stephenplusplus
Copy link
Contributor

at line 471 in pubsub/index.js you should use resp.name || subName (if the status is 409 and reuseExisting is true i got The name of a subscription is required. error).

Reported by @leibale.
@stephenplusplus stephenplusplus added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. api: pubsub Issues related to the Pub/Sub API. labels Dec 6, 2015
@stephenplusplus stephenplusplus changed the title you should use resp.name || subName (if the status is 409 and reuseExisting is true i got The name of a subscription is required. error). pubsub: reused subscriptions should not rely on API response for data Dec 6, 2015
@stephenplusplus stephenplusplus mentioned this issue Dec 7, 2015
Merged
@leibale
Copy link
Contributor

leibale commented Dec 7, 2015

??

@stephenplusplus
Copy link
Contributor Author

@leibale This was fixed and merged in #999.

@leibale
Copy link
Contributor

leibale commented Dec 7, 2015

sorry, i didn't see it the phone.
thanks :)

@sofisl sofisl mentioned this issue Jan 17, 2023
Merged
4 tasks
sofisl pushed a commit that referenced this issue Jan 17, 2023
@gcf-owl-bot
chore: remove unused imports (#997)
ede8cc0 
- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 436756904

Source-Link: googleapis/googleapis@6fb9df7

Source-Link: googleapis/googleapis-gen@b707d98
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjcwN2Q5ODljNGRmNzY5YTMxY2I5OTU2OTIwYTAyYjEwYTE4M2YxNSJ9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yoshi-automation yoshi-automation

Labels
api: pubsub Issues related to the Pub/Sub API. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@stephenplusplus @leibale @yoshi-automation