Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Travis release jobs fail on second pass #882

Closed
callmehiphop opened this issue Sep 21, 2015 · 3 comments
Closed

Travis release jobs fail on second pass #882

callmehiphop opened this issue Sep 21, 2015 · 3 comments
Assignees
@stephenplusplus
Labels
type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@callmehiphop
Copy link
Contributor

Now that we're supporting multiple node versions via CI, we need to update our release scripts. When and if the second pass finishes (0.12), it will fail at creating a new folder for the documentation JSON, because it already exists from the previous pass (4.x).
@callmehiphop callmehiphop added the type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. label Sep 21, 2015
@stephenplusplus
Copy link
Contributor

It would be great to run our after hook only after all tests pass, since technically, we don't know if our code is good until they do. I found something a week or so ago that could help. Do you remember the link by chance?

@callmehiphop
Copy link
Contributor Author

I think it was https://github.com/alrra/travis-after-all ?

@stephenplusplus stephenplusplus mentioned this issue Sep 24, 2015
Merged
@stephenplusplus
Copy link
Contributor

Fixed by #893

@sofisl sofisl mentioned this issue Nov 10, 2022
Merged
4 tasks
sofisl added a commit that referenced this issue Nov 10, 2022
@renovate-bot @sofisl
chore(deps): update dependency jsdoc to v4 (#882)
4774d81 
Co-authored-by: sofisl <[email protected]>
@sofisl sofisl mentioned this issue Jan 17, 2023
Merged
4 tasks
sofisl pushed a commit that referenced this issue Jan 17, 2023
@renovate-bot
samples(deps): update dependency pureimage to ^0.3.0 (#882)
31f36a4
sofisl pushed a commit that referenced this issue Jan 24, 2023
@summer-ji-eng
fix: flaky system test (#882)
dc3c7f5
sofisl pushed a commit that referenced this issue Jan 24, 2023
@release-please
chore(main): release 4.10.2 (#883)
1aeb871 
🤖 I have created a release *beep* *boop*
---


### [4.10.2](googleapis/nodejs-speech@v4.10.1...v4.10.2) (2022-05-02)


### Bug Fixes

* flaky system test ([#882](googleapis/nodejs-speech#882)) ([e837b64](googleapis/nodejs-speech@e837b64))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
sofisl pushed a commit that referenced this issue Jan 25, 2023
@summer-ji-eng
fix: flaky system test (#882)
a1bcee5
sofisl pushed a commit that referenced this issue Jan 25, 2023
@release-please
chore(main): release 4.10.2 (#883)
150f2a9 
🤖 I have created a release *beep* *boop*
---


### [4.10.2](googleapis/nodejs-speech@v4.10.1...v4.10.2) (2022-05-02)


### Bug Fixes

* flaky system test ([#882](googleapis/nodejs-speech#882)) ([e837b64](googleapis/nodejs-speech@e837b64))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stephenplusplus stephenplusplus

Labels
type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stephenplusplus @callmehiphop