Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on google-auto-auth and use google-auth-library #832

Closed
anthmgoogle opened this issue Aug 28, 2015 · 3 comments
Closed
Assignees
Labels
core status: blocked Resolving the issue is dependent on other work.

Comments

@anthmgoogle
Copy link

google-auth-library is where auth-related functionality should go. Add whatever features are required from google-auto-auth to it, and switch the dependency back to google-auth-library-nodejs.

@stephenplusplus
Copy link
Contributor

google-auto-auth uses google-auth-library-nodejs -- auto-auth doesn't do anything other than make auth-library easier to use and adds convenience methods (like getCredentials and getToken).

I only made it into its own module to restrict gcloud from taking on more responsibility than it needs. I also needed to use it from another module: https://github.com/stephenplusplus/gce-images (that is in turn used by gcloud).

I would like to switch back to auth-library and deprecate auto-auth, but is it possible to wait to see if googleapis/google-auth-library-nodejs#54, googleapis/google-auth-library-nodejs#55, and googleapis/google-auth-library-nodejs#56 re-shape the library to make it easier for us to consume first?

@stephenplusplus
Copy link
Contributor

Sorry, I missed the second part saying just what I was asking for in my reply. Hard to believe I couldn't read two sentences properly... I'll make an issue to get me a pair of glasses.

@stephenplusplus stephenplusplus changed the title Remove dependency on auth-auth and use google-auth-library Remove dependency on google-auto-auth and use google-auth-library Sep 17, 2015
@stephenplusplus stephenplusplus added the status: blocked Resolving the issue is dependent on other work. label Sep 17, 2015
@stephenplusplus
Copy link
Contributor

I think this issue can be tracked on google-auth-library (googleapis/google-auth-library-nodejs#54, googleapis/google-auth-library-nodejs#55, googleapis/google-auth-library-nodejs#56). We'll be aware if and when changes are made there and happily use google-auth-library as our dependency here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core status: blocked Resolving the issue is dependent on other work.
Projects
None yet
Development

No branches or pull requests

2 participants