storage: Support for folders

[pierre-b]

Hi,

Is it possible to upload a file into a folder ?

Thanks

[cristiano-belloni]

Hi @pierre-b,
what happens if you do yourBucket.file('myFolderName/myFileName')? It should just work.

[pierre-b]

Yes @janesconference it works with the createWriteStream function, but not with the bucket.upload one:

bucket.upload(sourcePath, options, function(error, file) {
});

[cristiano-belloni]

Never tried it, so take it with a grain of salt, but you can try:

bucket.upload(encodeURIComponent('myFolderName/myFileName'), options, function(error, file) { });

[pierre-b]

I think it should be added to the upload() by default, like in S3.

[ryanseys]

I agree. Did you try that and it worked?

[stephenplusplus]

@pierre-b can you paste the code you used to upload the file, as well as what version of gcloud you're using?

[stephenplusplus]

To elaborate more, upload can be called a few different ways, but the most simple is probably:

myBucket.upload("/Users/stephen/Desktop/photo.jpg", function (err, file) {})

In this case, I didn't specify anything about the destination file, only that I want one to be created based on the file at "/Users/stephen/Desktop/photo.jpg". The upload method will detect the file name as being "photo.jpg", and will drop it in your bucket with the same name and the contents at the given file path.

upload doesn't treat your local file system's hierarchy as being identical to your bucket's hierarchy, so it needs to be told explicitly where you wish the file to end up:

myBucket.upload("/Users/stephen/Desktop/photo.jpg", {
  destination: myBucket.file("my-photos/photo.jpg")
}, function (err, file) {})

Now the file should end up inside a directory called "my-photos", named "photo.jpg". If you were using it this way, and it's not working, that's a bug we need to squash.

[ryanseys]

Can confirm that using the destination option and providing a file object like suggested above will correctly upload the file into a folder. @pierre-b Can you confirm this also works for you?

[pierre-b]

Using v0.11.0 the following doesn't work too, the file is not saved in the folder:

myBucket.upload("/Users/stephen/Desktop/photo.jpg", {
  destination: myBucket.file("my-photos/photo.jpg")
}, function (err, file) {})

[cristiano-belloni]

This is working for me on v0.12.0,

return resourceBucket.upload(
        local,
        {
            destination: remote,
            metadata: { contentType: contentType }
        }, function (err, file) {
            if (cb) {
                cb(err, file);
            }
        });

Where local is my local file name ( ie: '/mylocalpath/myfile' ) and remote is my remote file path ( ie: 'remotepath/myfile' ), both without any encoding.

[stephenplusplus]

Going to close as all signs point to this working. If you still can't get it working, feel free to re-open with more details. If you have ideas for how we can improve the documentation or API to make a better experience for others, those are always welcome as well.

[Marak]

There is some issue either here or in github.com/pkgcloud/pkgcloud which is causing encodeURIComponent related issue on downloading files.

Seems that the outgoing URI isn't being encoded automatically?

Don't have much time to dig into it now, but solution was to use encodeURIComponent on outgoing path for downloading file inside folder. Uploading seemed to have encoding / decoding working correctly.

Will update if I ever get more information. Patch is holding here.

[stephenplusplus]

If the request is going through pkgcloud, that means it's using gcloud­@0.10. We're currently on 0.32. Here's the issue which asks for gcloud to be updated: pkgcloud/pkgcloud#452, but the maintainers have some issues with doing it.

In the past, we have missed a few encodeURIComponents, and it's possible 0.10 was before we caught them.