-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add process to build docs #125
Comments
#127 -
Let's talk about this one :) It sounds nice to be able to accept a PR of source code changes, and have the docs generated. This is actually pretty doable, but with side effects. If someone changes source code, sends a PR, the tests pass, and we merge it, we would want to
This doesn't feel too great, since we're letting a robot create a commit and push to master! Travis will do whatever we say every time a PR is sent, and every time a commit is merged into master. It doesn't seem that we can do different things from different triggers. So, if someone changes source code, sends in a PR, the tests pass, but we don't merge it... Uh oh! Travis just kept on running, generated the docs, and pushed to master & gh-pages. #127 currently has Travis push the So, that's the state of the task now. If you have any ideas for workarounds or know of other solutions, let me know. |
Sorry, I made a great job in being unclear on the second point, what I meant was pushing the docs after a merge into master that affects the docs, which is what you did :) We might move the docs step from Travis to the CI that we use to run the build that includes the regression tests, but this looks very good for now, thanks! Going through all the PRs now. |
Can we use PRs here too? i.e. A script will detect that docs are behind master (or latest tag), build docs, and auto create PR for updated docs. We then merge the PR manually. I prefer latest tag so we don't spam the PR/issues list & our inboxes. Thoughts? Off-topic: Similar approach could be used for google/google-api-nodejs-client regeneration of APIs. |
I'm not sure we want an additional PR. |
Fixed in #127. |
... chore: update gapic-generator-ruby to the latest commit chore: release gapic-generator-typescript 1.5.0 Committer: @miraleung PiperOrigin-RevId: 380641501 Source-Link: googleapis/googleapis@076f7e9 Source-Link: googleapis/googleapis-gen@27e4c88
🤖 I have created a release \*beep\* \*boop\* --- ### [1.4.3](https://www.github.com/googleapis/nodejs-memcache/compare/v1.4.2...v1.4.3) (2021-06-22) ### Bug Fixes * make request optional in all cases ([#125](https://www.github.com/googleapis/nodejs-memcache/issues/125)) ([3b296ba](https://www.github.com/googleapis/nodejs-memcache/commit/3b296ba1e2598054ed391979b616ddf03f0b89f4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/9f0ce149-63bd-4aad-917d-44f82c8912a6/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@ba9918c
PiperOrigin-RevId: 377915759 Source-Link: googleapis/googleapis@e3fcbab Source-Link: googleapis/googleapis-gen@29b972d
🤖 I have created a release \*beep\* \*boop\* --- ## [2.10.0](https://www.github.com/googleapis/nodejs-dialogflow-cx/compare/v2.9.0...v2.10.0) (2021-06-17) ### Features * **v3:** support sentiment analysis in bot testing ([#125](https://www.github.com/googleapis/nodejs-dialogflow-cx/issues/125)) ([d6d7684](https://www.github.com/googleapis/nodejs-dialogflow-cx/commit/d6d7684692ec3790ec5a4284cb206a4c26f4a1ab)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
* chore(main): release 2.1.1 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Benjamin E. Coe <[email protected]>
fix: use google-gax v3.3.0 Source-Link: googleapis/synthtool@c73d112 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:b15a6f06cc06dcffa11e1bebdf1a74b6775a134aac24a0f86f51ddf728eb373e
🤖 I have created a release *beep* *boop* --- ## [2.0.3](https://togithub.com/googleapis/nodejs-org-policy/compare/v2.0.2...v2.0.3) (2022-11-11) ### Bug Fixes * Allow passing gax instance to client constructor ([#126](https://togithub.com/googleapis/nodejs-org-policy/issues/126)) ([c7147d4](https://togithub.com/googleapis/nodejs-org-policy/commit/c7147d40a9ed114ec42997d49c2f5dfcff948aad)) * **deps:** Use google-gax v3.5.2 ([#134](https://togithub.com/googleapis/nodejs-org-policy/issues/134)) ([0f1bfb0](https://togithub.com/googleapis/nodejs-org-policy/commit/0f1bfb0007ade736c2ec91f32ff187c80b2d6761)) * Do not import the whole google-gax from proto JS ([#1553](https://togithub.com/googleapis/nodejs-org-policy/issues/1553)) ([#125](https://togithub.com/googleapis/nodejs-org-policy/issues/125)) ([068b0a5](https://togithub.com/googleapis/nodejs-org-policy/commit/068b0a55fe805cedab9e66f62071c8be56f465ed)) * Preserve default values in x-goog-request-params header ([#128](https://togithub.com/googleapis/nodejs-org-policy/issues/128)) ([3f80014](https://togithub.com/googleapis/nodejs-org-policy/commit/3f80014a3c75311555df6cfde8470ae1f72a686f)) * Regenerated protos JS and TS definitions ([#137](https://togithub.com/googleapis/nodejs-org-policy/issues/137)) ([1606459](https://togithub.com/googleapis/nodejs-org-policy/commit/1606459c847f2ed945dccc8e43d57d273fac7ea9)) * use google-gax v3.3.0 ([068b0a5](https://togithub.com/googleapis/nodejs-org-policy/commit/068b0a55fe805cedab9e66f62071c8be56f465ed)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
🤖 I have created a release \*beep\* \*boop\* --- ## [1.8.0](https://www.github.com/googleapis/nodejs-datacatalog/compare/v1.7.0...v1.8.0) (2020-03-06) ### Features * deferred client initialization ([#127](https://www.github.com/googleapis/nodejs-datacatalog/issues/127)) ([1640d4d](https://www.github.com/googleapis/nodejs-datacatalog/commit/1640d4d8fe1a9adbff9719399e5e2fff95bbb4b5)) * export protos in src/index.ts ([86933a1](https://www.github.com/googleapis/nodejs-datacatalog/commit/86933a113549c33a5283e7bf438ce0229b74155b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Benjamin E. Coe <[email protected]>
The text was updated successfully, but these errors were encountered: