build: check broken links in generated docs (#301)

* build: check dead links on Kokoro * recursive crawl local links * fix missing namespace * fix doc_timestamp.js dead links
googleapis · Jan 9, 2019 · e83f7ea · e83f7ea
1 parent cb17d38
commit e83f7ea
Show file tree

Hide file tree

Showing 6 changed files with 21 additions and 15 deletions.
diff --git a/packages/google-cloud-vision/.jsdoc.js b/packages/google-cloud-vision/.jsdoc.js
@@ -20,7 +20,7 @@ module.exports = {
   opts: {
     readme: './README.md',
     package: './package.json',
-    template: './node_modules/ink-docstrap/template',
+    template: './node_modules/jsdoc-baseline',
     recurse: true,
     verbose: true,
     destination: './docs/'

diff --git a/packages/google-cloud-vision/package.json b/packages/google-cloud-vision/package.json
@@ -54,7 +54,7 @@
     "eslint-config-prettier": "^3.0.0",
     "eslint-plugin-node": "^8.0.0",
     "eslint-plugin-prettier": "^3.0.0",
-    "ink-docstrap": "^1.3.2",
+    "jsdoc-baseline": "git+https://github.com/hegemonic/jsdoc-baseline.git",
     "intelli-espower-loader": "^1.0.1",
     "jsdoc": "^3.5.5",
     "mocha": "^5.2.0",

diff --git a/packages/google-cloud-vision/src/index.js b/packages/google-cloud-vision/src/index.js
@@ -13,19 +13,19 @@
 // limitations under the License.
 
 /**
- * @namespace google
+ * @namespace google.cloud.vision.v1
  */
 /**
- * @namespace google.cloud
+ * @namespace google.cloud.vision.v1p1beta1
  */
 /**
- * @namespace google.cloud.vision
+ * @namespace google.cloud.vision.v1p2beta1
  */
 /**
- * @namespace google.cloud.vision.v1
+ * @namespace google.cloud.vision.v1p3beta1
  */
 /**
- * @namespace google.cloud.vision.v1p1beta1
+ * @namespace google.longrunning
  */
 /**
  * @namespace google.protobuf

diff --git a/packages/google-cloud-vision/src/v1/doc/google/protobuf/doc_timestamp.js b/packages/google-cloud-vision/src/v1/doc/google/protobuf/doc_timestamp.js
@@ -87,13 +87,11 @@
  * 01:30 UTC on January 15, 2017.
  *
  * In JavaScript, one can convert a Date object to this format using the
- * standard [toISOString()](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date/toISOString]
+ * standard [toISOString()](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date/toISOString)
  * method. In Python, a standard `datetime.datetime` object can be converted
  * to this format using [`strftime`](https://docs.python.org/2/library/time.html#time.strftime)
  * with the time format spec '%Y-%m-%dT%H:%M:%S.%fZ'. Likewise, in Java, one
- * can use the Joda Time's [`ISODateTimeFormat.dateTime()`](https://cloud.google.com
- * http://www.joda.org/joda-time/apidocs/org/joda/time/format/ISODateTimeFormat.html#dateTime--
- * ) to obtain a formatter capable of generating timestamps in this format.
+ * can use the Joda Time's [`ISODateTimeFormat.dateTime()`](https://www.joda.org/joda-time/apidocs/org/joda/time/format/ISODateTimeFormat.html#dateTime--) to obtain a formatter capable of generating timestamps in this format.
  *
  * @property {number} seconds
  *   Represents seconds of UTC time since Unix epoch

diff --git a/packages/google-cloud-vision/src/v1p3beta1/doc/google/protobuf/doc_timestamp.js b/packages/google-cloud-vision/src/v1p3beta1/doc/google/protobuf/doc_timestamp.js
@@ -87,13 +87,11 @@
  * 01:30 UTC on January 15, 2017.
  *
  * In JavaScript, one can convert a Date object to this format using the
- * standard [toISOString()](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date/toISOString]
+ * standard [toISOString()](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date/toISOString)
  * method. In Python, a standard `datetime.datetime` object can be converted
  * to this format using [`strftime`](https://docs.python.org/2/library/time.html#time.strftime)
  * with the time format spec '%Y-%m-%dT%H:%M:%S.%fZ'. Likewise, in Java, one
- * can use the Joda Time's [`ISODateTimeFormat.dateTime()`](https://cloud.google.com
- * http://www.joda.org/joda-time/apidocs/org/joda/time/format/ISODateTimeFormat.html#dateTime--
- * ) to obtain a formatter capable of generating timestamps in this format.
+ * can use the Joda Time's [`ISODateTimeFormat.dateTime()`](https://www.joda.org/joda-time/apidocs/org/joda/time/format/ISODateTimeFormat.html#dateTime--) to obtain a formatter capable of generating timestamps in this format.
  *
  * @property {number} seconds
  *   Represents seconds of UTC time since Unix epoch

diff --git a/packages/google-cloud-vision/synth.py b/packages/google-cloud-vision/synth.py
@@ -33,6 +33,16 @@
 templates = common_templates.node_library()
 s.copy(templates)
 
+# [START fix-dead-link]
+s.replace('**/doc/google/protobuf/doc_timestamp.js',
+        'https:\/\/cloud\.google\.com[\s\*]*http:\/\/(.*)[\s\*]*\)',
+        r"https://\1)")
+
+s.replace('**/doc/google/protobuf/doc_timestamp.js',
+        'toISOString\]',
+        'toISOString)')
+# [END fix-dead-link]
+
 # Node.js specific cleanup
 subprocess.run(['npm', 'install'])
 subprocess.run(['npm', 'run', 'fix'])