add unit tests

googleapis · Mar 10, 2015 · c0ce479 · c0ce479
1 parent 5616626
commit c0ce479
Show file tree

Hide file tree

Showing 2 changed files with 334 additions and 8 deletions.
diff --git a/lib/storage/bucket.js b/lib/storage/bucket.js
@@ -489,7 +489,7 @@ Bucket.prototype.makePublic = function(options, callback) {
       return;
     }
 
-    if (options.files) {
+    if (options.includeFiles) {
       options.public = true;
       self.makeAllFilesPublicPrivate_(options, callback);
       return;
@@ -766,16 +766,16 @@ Bucket.prototype.makeAllFilesPublicPrivate_ = function(options, callback) {
 
   var MAX_PARALLEL_LIMIT = 10;
   var errors = [];
-  var filesProcessed = [];
+  var updatedFiles = [];
 
   // Start processing files, iteratively fetching more as necessary.
   processFiles({}, function (err) {
     if (err || errors.length > 0) {
-      callback(err || errors, filesProcessed);
+      callback(err || errors, updatedFiles);
       return;
     }
 
-    callback(null, filesProcessed);
+    callback(null, updatedFiles);
   });
 
   function processFiles(query, callback) {
@@ -785,7 +785,7 @@ Bucket.prototype.makeAllFilesPublicPrivate_ = function(options, callback) {
         return;
       }
 
-      // Iterate through each file and make it public/private.
+      // Iterate through each file and make it public or private.
       async.eachLimit(files, MAX_PARALLEL_LIMIT, processFile, function(err) {
         if (err) {
           callback(err);
@@ -821,7 +821,7 @@ Bucket.prototype.makeAllFilesPublicPrivate_ = function(options, callback) {
         return;
       }
 
-      filesProcessed.push(file);
+      updatedFiles.push(file);
       callback();
     }
   }