Enable no-var in eslint (#198)

packages/google-cloud-vision/.eslintrc.yml

@@ -11,3 +11,4 @@ rules:
   block-scoped-var: error
   eqeqeq: error
   no-warning-comments: warn
+  no-var: error

packages/google-cloud-vision/src/helpers.js

@@ -102,7 +102,7 @@ let _coerceRequest = (request, callback) => {
  * @returns {function} The function that, when called, will call annotateImage
  *   asking for the single feature annotation.
  */
-var _createSingleFeatureMethod = featureValue => {
+let _createSingleFeatureMethod = featureValue => {
   return function(annotateImageRequest, callOptions, callback) {
     // Sanity check: If we got a string or buffer, we need this to be
     // in object form now, so we can tack on the features list.
@@ -152,7 +152,7 @@ var _createSingleFeatureMethod = featureValue => {
  *   onto the pure GAPIC.
  */
 module.exports = apiVersion => {
-  var methods = {};
+  let methods = {};
 
   /**
    * Annotate a single image with the requested features.
@@ -236,7 +236,7 @@ module.exports = apiVersion => {
 
         // We are guaranteed to only have one response element, since we
         // only sent one image.
-        var response = r.responses[0];
+        let response = r.responses[0];
 
         // Fire the callback if applicable.
         return callback(undefined, response);

packages/google-cloud-vision/system-test/image_annotator_smoke_test.js

@@ -18,31 +18,31 @@ describe('ImageAnnotatorSmokeTest', () => {
   it('successfully makes a call to the service', done => {
     const vision = require('../src');
 
-    var client = new vision.v1p3beta1.ImageAnnotatorClient({
+    let client = new vision.v1p3beta1.ImageAnnotatorClient({
       // optional auth parameters.
     });
 
-    var gcsImageUri = 'gs://gapic-toolkit/President_Barack_Obama.jpg';
-    var source = {
+    let gcsImageUri = 'gs://gapic-toolkit/President_Barack_Obama.jpg';
+    let source = {
       gcsImageUri: gcsImageUri,
     };
-    var image = {
+    let image = {
       source: source,
     };
-    var type = 'FACE_DETECTION';
-    var featuresElement = {
+    let type = 'FACE_DETECTION';
+    let featuresElement = {
       type: type,
     };
-    var features = [featuresElement];
-    var requestsElement = {
+    let features = [featuresElement];
+    let requestsElement = {
       image: image,
       features: features,
     };
-    var requests = [requestsElement];
+    let requests = [requestsElement];
     client
       .batchAnnotateImages({requests: requests})
       .then(responses => {
-        var response = responses[0];
+        let response = responses[0];
         console.log(response);
       })
       .then(done)

packages/google-cloud-vision/system-test/vision-v1p2beta1.js

@@ -18,31 +18,31 @@ describe('ImageAnnotatorSmokeTest', () => {
   it('successfully makes a call to the service', done => {
     const vision = require('../src');
 
-    var client = new vision.v1p2beta1.ImageAnnotatorClient({
+    let client = new vision.v1p2beta1.ImageAnnotatorClient({
       // optional auth parameters.
     });
 
-    var gcsImageUri = 'gs://gapic-toolkit/President_Barack_Obama.jpg';
-    var source = {
+    let gcsImageUri = 'gs://gapic-toolkit/President_Barack_Obama.jpg';
+    let source = {
       gcsImageUri: gcsImageUri,
     };
-    var image = {
+    let image = {
       source: source,
     };
-    var type = 'FACE_DETECTION';
-    var featuresElement = {
+    let type = 'FACE_DETECTION';
+    let featuresElement = {
       type: type,
     };
-    var features = [featuresElement];
-    var requestsElement = {
+    let features = [featuresElement];
+    let requestsElement = {
       image: image,
       features: features,
     };
-    var requests = [requestsElement];
+    let requests = [requestsElement];
     client
       .batchAnnotateImages({requests: requests})
       .then(responses => {
-        var response = responses[0];
+        let response = responses[0];
         console.log(response);
       })
       .then(done)

packages/google-cloud-vision/system-test/vision.js

@@ -80,30 +80,30 @@ describe('Vision', function() {
   });
 
   it('should detect from a URL', () => {
-    var url = 'https://upload.wikimedia.org/wikipedia/commons/5/51/Google.png';
+    let url = 'https://upload.wikimedia.org/wikipedia/commons/5/51/Google.png';
     return client.logoDetection(url).then(responses => {
-      var response = responses[0];
+      let response = responses[0];
       assert.deepStrictEqual(response.logoAnnotations[0].description, 'Google');
     });
   });
 
   it('should detect from a filename', () => {
     return client.logoDetection(IMAGES.logo).then(responses => {
-      var response = responses[0];
+      let response = responses[0];
       assert.deepStrictEqual(response.logoAnnotations[0].description, 'Google');
     });
   });
 
   it('should detect from a Buffer', () => {
-    var buffer = fs.readFileSync(IMAGES.logo);
+    let buffer = fs.readFileSync(IMAGES.logo);
     return client.logoDetection(buffer).then(responses => {
-      var response = responses[0];
+      let response = responses[0];
       assert.deepStrictEqual(response.logoAnnotations[0].description, 'Google');
     });
   });
 
   describe('single image', () => {
-    var TYPES = [
+    let TYPES = [
       {type: 'FACE_DETECTION'},
       {type: 'LABEL_DETECTION'},
       {type: 'SAFE_SEARCH_DETECTION'},
@@ -115,7 +115,7 @@ describe('Vision', function() {
           image: {source: {filename: IMAGES.rushmore}},
         })
         .then(responses => {
-          var response = responses[0];
+          let response = responses[0];
           assert(response.faceAnnotations.length >= 1);
           assert(response.labelAnnotations.length >= 1);
           assert(response.safeSearchAnnotation !== null);

packages/google-cloud-vision/test/helpers.test.js

@@ -193,7 +193,7 @@ describe('Vision helper methods', () => {
 
       // Ensure that the annotateImage method arrifies the request and
       // passes it through to the batch annotation method.
-      var request = {
+      let request = {
         image: {content: Buffer.from('bogus==')},
         features: {type: ['LOGO_DETECTION']},
       };