Merge pull request #330 from pilwon/patch-1

Bug fix: pubsub message's data and label fields missing in publishRaw().
googleapis · Dec 15, 2014 · af986b7 · af986b7
2 parents 4293636 + f97caca
commit af986b7
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/lib/pubsub/topic.js b/lib/pubsub/topic.js
@@ -131,8 +131,11 @@ Topic.prototype.publishRaw = function(message, callback) {
   if (!util.is(message.data, 'string') && !util.is(message.data, 'buffer')) {
     message.data = new Buffer(JSON.stringify(message.data)).toString('base64');
   }
-  message.topic = this.name;
-  this.makeReq_('POST', 'topics/publish', null, message, callback);
+  var body = {
+    message: message,
+    topic: this.name
+  };
+  this.makeReq_('POST', 'topics/publish', null, body, callback);
 };
 
 /**

diff --git a/test/pubsub/topic.js b/test/pubsub/topic.js
@@ -150,7 +150,7 @@ describe('Topic', function() {
 
       it('should stringify non-strings & non-buffers', function(done) {
         topic.makeReq_ = function(method, path, qs, body) {
-          assert.deepEqual(body.data, messageObjDecoded);
+          assert.deepEqual(body.message.data, messageObjDecoded);
           done();
         };
         topic.publishRaw({ data: messageObj }, assert.ifError);
@@ -160,7 +160,7 @@ describe('Topic', function() {
         topic.makeReq_ = function(method, path, qs, body) {
           assert.equal(method, 'POST');
           assert.equal(path, 'topics/publish');
-          assert.deepEqual(body.message, messageRaw.message);
+          assert.deepEqual(body.message.data, messageRaw.data);
           done();
         };
         topic.publishRaw(messageRaw, assert.ifError);