Enable gts fix (#98)

googleapis · Sep 6, 2018 · 8457257 · 8457257
1 parent 9ebae03
commit 8457257
Show file tree

Hide file tree

Showing 12 changed files with 753 additions and 812 deletions.
diff --git a/packages/google-cloud-dns/README.md b/packages/google-cloud-dns/README.md
@@ -64,7 +64,7 @@ Google APIs Client Libraries, in [Client Libraries Explained][explained].
 
 ```javascript
 // Imports the Google Cloud client library
-const DNS = require('@google-cloud/dns');
+const {DNS} = require('@google-cloud/dns');
 
 // Your Google Cloud Platform project ID
 const projectId = 'YOUR_PROJECT_ID';

diff --git a/packages/google-cloud-dns/package.json b/packages/google-cloud-dns/package.json
@@ -44,7 +44,7 @@
   "scripts": {
     "docs": "jsdoc -c .jsdoc.js",
     "generate-scaffolding": "repo-tools generate all && repo-tools generate lib_samples_readme -l samples/ --config ../.cloud-repo-tools.json",
-    "lint": "echo lint not enabled 👻 # gts check && eslint samples/",
+    "lint": "gts check && eslint samples/",
     "test": "nyc mocha build/test",
     "samples-test": "cd samples/ && npm link ../ && npm test && cd ../",
     "presystem-test": "npm run compile",
@@ -81,6 +81,8 @@
     "@types/mocha": "^5.2.5",
     "@types/node": "^10.9.4",
     "@types/proxyquire": "^1.3.28",
+    "@types/request": "^2.47.1",
+    "@types/tmp": "0.0.33",
     "@types/uuid": "^3.4.4",
     "async": "^2.6.1",
     "codecov": "^3.0.2",

diff --git a/packages/google-cloud-dns/samples/quickstart.js b/packages/google-cloud-dns/samples/quickstart.js
@@ -17,7 +17,7 @@
 
 // [START dns_quickstart]
 // Imports the Google Cloud client library
-const DNS = require('@google-cloud/dns');
+const {DNS} = require('@google-cloud/dns');
 
 // Your Google Cloud Platform project ID
 const projectId = 'YOUR_PROJECT_ID';

diff --git a/packages/google-cloud-dns/src/change.ts b/packages/google-cloud-dns/src/change.ts
@@ -27,13 +27,13 @@ import {promisifyAll} from '@google-cloud/promisify';
  * @param {string} id ID of the change.
  *
  * @example
- * const DNS = require('@google-cloud/dns');
+ * const {DNS} = require('@google-cloud/dns');
  * const dns = new DNS();
  * const zone = dns.zone('zone-id');
  * const change = zone.change('change-id');
  */
 export class Change extends ServiceObject {
-  constructor(zone, id) {
+  constructor(zone, id?) {
     const methods = {
       /**
        * @typedef {array} ChangeExistsResponse
@@ -52,7 +52,7 @@ export class Change extends ServiceObject {
        * @returns {Promise<ChangeExistsResponse>}
        *
        * @example
-       * const DNS = require('@google-cloud/dns');
+       * const {DNS} = require('@google-cloud/dns');
        * const dns = new DNS();
        * const zone = dns.zone('zone-id');
        * const change = zone.change('change-id');
@@ -81,10 +81,10 @@ export class Change extends ServiceObject {
       /**
        * Get a change if it exists.
        *
-       * You may optionally use this to "get or create" an object by providing an
-       * object with `autoCreate` set to `true`. Any extra configuration that is
-       * normally required for the `create` method must be contained within this
-       * object as well.
+       * You may optionally use this to "get or create" an object by providing
+       * an object with `autoCreate` set to `true`. Any extra configuration that
+       * is normally required for the `create` method must be contained within
+       * this object as well.
        *
        * @method Change#get
        * @param {options} [options] Configuration object.
@@ -94,7 +94,7 @@ export class Change extends ServiceObject {
        * @returns {Promise<GetChangeResponse>}
        *
        * @example
-       * const DNS = require('@google-cloud/dns');
+       * const {DNS} = require('@google-cloud/dns');
        * const dns = new DNS();
        * const zone = dns.zone('zone-id');
        * const change = zone.change('change-id');
@@ -133,7 +133,7 @@ export class Change extends ServiceObject {
        * @returns {Promise<GetChangeMetadataResponse>}
        *
        * @example
-       * const DNS = require('@google-cloud/dns');
+       * const {DNS} = require('@google-cloud/dns');
        * const dns = new DNS();
        * const zone = dns.zone('zone-id');
        * const change = zone.change('change-id');
@@ -180,6 +180,7 @@ export class Change extends ServiceObject {
        */
       id,
       methods,
+      // tslint:disable-next-line:no-any
       requestModule: teenyRequest as any,
     });
   }
@@ -192,7 +193,7 @@ export class Change extends ServiceObject {
    * @returns {Promise<CreateChangeResponse>}
    *
    * @example
-   * const DNS = require('@google-cloud/dns');
+   * const {DNS} = require('@google-cloud/dns');
    * const dns = new DNS();
    * const zone = dns.zone('zone-id');
    * const change = zone.change('change-id');
@@ -218,6 +219,7 @@ export class Change extends ServiceObject {
    * });
    */
   create(config, callback?) {
+    // tslint:disable-next-line:no-any
     (this.parent as any).createChange(config, (err, change, apiResponse) => {
       if (err) {
         callback(err, null, apiResponse);