Update CI config (#22)

googleapis · Oct 2, 2018 · 29d6ebb · 29d6ebb
1 parent 155ebeb
commit 29d6ebb
Show file tree

Hide file tree

Showing 7 changed files with 85 additions and 85 deletions.
diff --git a/packages/google-cloud-asset/.circleci/config.yml b/packages/google-cloud-asset/.circleci/config.yml
@@ -68,8 +68,6 @@ jobs:
           environment:
             NPM_CONFIG_PREFIX: /home/node/.npm-global
       - run: npm test
-      - run: node_modules/.bin/codecov
-
   node8:
     docker:
       - image: 'node:8'

diff --git a/packages/google-cloud-asset/codecov.yaml b/packages/google-cloud-asset/codecov.yaml
@@ -0,0 +1,4 @@
+---
+codecov:
+  ci:
+    - source.cloud.google.com
diff --git a/packages/google-cloud-asset/protos/google/cloud/asset/v1beta1/asset_service.proto b/packages/google-cloud-asset/protos/google/cloud/asset/v1beta1/asset_service.proto
@@ -32,9 +32,9 @@ option php_namespace = "Google\\Cloud\\Asset\\V1beta1";
 
 // Asset service definition.
 service AssetService {
-  // Exports assets with time and resource types to a given Google Cloud Storage
+  // Exports assets with time and resource types to a given Cloud Storage
   // location. The output format is newline-delimited JSON.
-  // This API implements the [google.longrunning.Operation][google.longrunning.Operation] API allowing users
+  // This API implements the [google.longrunning.Operation][google.longrunning.Operation] API allowing you
   // to keep track of the export.
   rpc ExportAssets(ExportAssetsRequest) returns (google.longrunning.Operation) {
     option (google.api.http) = {
@@ -47,26 +47,26 @@ service AssetService {
     };
   }
 
-  // Batch gets assets update history that overlaps a time window.
+  // Batch gets the update history of assets that overlap a time window.
   // For RESOURCE content, this API outputs history with asset in both
   // non-delete or deleted status.
-  // For IAM_POLICY content, this API only outputs history when asset and its
-  // attached IAM POLICY both exist. So there may be gaps in the output history.
+  // For IAM_POLICY content, this API outputs history when the asset and its
+  // attached IAM POLICY both exist. This can create gaps in the output history.
   rpc BatchGetAssetsHistory(BatchGetAssetsHistoryRequest) returns (BatchGetAssetsHistoryResponse) {
     option (google.api.http) = {
       get: "/v1beta1/{parent=projects/*}:batchGetAssetsHistory"
       additional_bindings {
-        get: "/v1beta1/{parent=organizations/*}:batchGetAssetHistory"
+        get: "/v1beta1/{parent=organizations/*}:batchGetAssetsHistory"
       }
     };
   }
 }
 
 // Export asset request.
 message ExportAssetsRequest {
-  // Required. The relative name of the root asset. Can only be an organization
-  // number (such as "organizations/123"), or a project id (such as
-  // "projects/my-project-id") or a project number (such as "projects/12345").
+  // Required. The relative name of the root asset. This can only be an organization
+  // number (such as "organizations/123"), a project ID (such as
+  // "projects/my-project-id"), or a project number (such as "projects/12345").
   string parent = 1;
 
   // Timestamp to take an asset snapshot. This can only be set to a timestamp in
@@ -76,7 +76,7 @@ message ExportAssetsRequest {
   // results.
   google.protobuf.Timestamp read_time = 2;
 
-  // A list of asset types of which to take a snapshot for. Example:
+  // A list of asset types of which to take a snapshot for. For example:
   // "google.compute.disk". If specified, only matching assets will be returned.
   repeated string asset_types = 3;
 
@@ -104,14 +104,14 @@ message ExportAssetsResponse {
 // Batch get assets history request.
 message BatchGetAssetsHistoryRequest {
   // Required. The relative name of the root asset. It can only be an
-  // organization number (such as "organizations/123"), or a project id (such as
-  // "projects/my-project-id")"or a project number (such as "projects/12345").
+  // organization number (such as "organizations/123"), a project ID (such as
+  // "projects/my-project-id")", or a project number (such as "projects/12345").
   string parent = 1;
 
-  // A list of the full names of the assets. See:
-  // https://cloud.google.com/apis/design/resource_names#full_resource_name
-  // Example:
-  // "//compute.googleapis.com/projects/my_project_123/zones/zone1/instances/instance1".
+  // A list of the full names of the assets. For example:
+  // `//compute.googleapis.com/projects/my_project_123/zones/zone1/instances/instance1`.
+  // See [Resource Names](https://cloud.google.com/apis/design/resource_names#full_resource_name)
+  // for more info.
   //
   // The request becomes a no-op if the asset name list is empty, and the max
   // size of the asset name list is 100 in one request.
@@ -136,17 +136,16 @@ message BatchGetAssetsHistoryResponse {
 message OutputConfig {
   // Asset export destination.
   oneof destination {
-    // Destination on Google Cloud Storage (GCS).
+    // Destination on Cloud Storage.
     GcsDestination gcs_destination = 1;
   }
 }
 
-// A Google Cloud Storage (GCS) location.
+// A Cloud Storage location.
 message GcsDestination {
-  // The path of the GCS objects. It's the same path that is used by gsutil, for
-  // example: "gs://bucket_name/object_path". See:
-  // https://cloud.google.com/storage/docs/viewing-editing-metadata for more
-  // information.
+  // The path of the Cloud Storage objects. It's the same path that is used by
+  //  gsutil. For example: "gs://bucket_name/object_path". See [Viewing and Editing Object Metadata](https://cloud.google.com/storage/docs/viewing-editing-metadata)
+  // for more information.
   string uri = 1;
 }
 

diff --git a/packages/google-cloud-asset/protos/google/cloud/asset/v1beta1/assets.proto b/packages/google-cloud-asset/protos/google/cloud/asset/v1beta1/assets.proto
@@ -54,13 +54,12 @@ message TimeWindow {
   google.protobuf.Timestamp end_time = 2;
 }
 
-// Cloud asset. This include all Google Cloud Platform resources, as well as
-// IAM policies and other non-GCP assets.
+// Cloud asset. This includes all Google Cloud Platform resources,
+// Cloud IAM policies, and other non-GCP assets.
 message Asset {
-  // The full name of the asset. See:
-  // https://cloud.google.com/apis/design/resource_names#full_resource_name
-  // Example:
-  // "//compute.googleapis.com/projects/my_project_123/zones/zone1/instances/instance1".
+  // The full name of the asset. For example: `//compute.googleapis.com/projects/my_project_123/zones/zone1/instances/instance1`.
+  // See [Resource Names](https://cloud.google.com/apis/design/resource_names#full_resource_name)
+  // for more information.
   string name = 1;
 
   // Type of the asset. Example: "google.compute.disk".
@@ -69,8 +68,8 @@ message Asset {
   // Representation of the resource.
   Resource resource = 3;
 
-  // Representation of the actual IAM policy set on a cloud resource. For each
-  // resource, there must be at most one IAM policy set on it.
+  // Representation of the actual Cloud IAM policy set on a cloud resource. For each
+  // resource, there must be at most one Cloud IAM policy set on it.
   google.iam.v1.Policy iam_policy = 4;
 }
 
@@ -80,8 +79,8 @@ message Resource {
   string version = 1;
 
   // The URL of the discovery document containing the resource's JSON schema.
-  // Example:
-  // "https://www.googleapis.com/discovery/v1/apis/compute/v1/rest".
+  // For example:
+  // `"https://www.googleapis.com/discovery/v1/apis/compute/v1/rest"`.
   // It will be left unspecified for resources without a discovery-based API,
   // such as Cloud Bigtable.
   string discovery_document_uri = 2;
@@ -98,12 +97,13 @@ message Resource {
   // It will be left unspecified for resources without a REST API.
   string resource_url = 4;
 
-  // The full name of the immediate parent of this resource. See:
-  // https://cloud.google.com/apis/design/resource_names#full_resource_name
+  // The full name of the immediate parent of this resource. See
+  // [Resource Names](https://cloud.google.com/apis/design/resource_names#full_resource_name)
+  // for more information.
   //
-  // For GCP assets, it is the parent resource defined in the IAM policy
-  // hierarchy: https://cloud.google.com/iam/docs/overview#policy_hierarchy.
-  // Example: "//cloudresourcemanager.googleapis.com/projects/my_project_123".
+  // For GCP assets, it is the parent resource defined in the [Cloud IAM policy
+  // hierarchy](https://cloud.google.com/iam/docs/overview#policy_hierarchy).
+  // For example: `"//cloudresourcemanager.googleapis.com/projects/my_project_123"`.
   //
   // For third-party assets, it is up to the users to define.
   string parent = 5;

diff --git a/packages/google-cloud-asset/src/v1beta1/asset_service_client.js b/packages/google-cloud-asset/src/v1beta1/asset_service_client.js
@@ -212,17 +212,17 @@ class AssetServiceClient {
   // -------------------
 
   /**
-   * Exports assets with time and resource types to a given Google Cloud Storage
+   * Exports assets with time and resource types to a given Cloud Storage
    * location. The output format is newline-delimited JSON.
-   * This API implements the google.longrunning.Operation API allowing users
+   * This API implements the google.longrunning.Operation API allowing you
    * to keep track of the export.
    *
    * @param {Object} request
    *   The request object that will be sent.
    * @param {string} request.parent
-   *   Required. The relative name of the root asset. Can only be an organization
-   *   number (such as "organizations/123"), or a project id (such as
-   *   "projects/my-project-id") or a project number (such as "projects/12345").
+   *   Required. The relative name of the root asset. This can only be an organization
+   *   number (such as "organizations/123"), a project ID (such as
+   *   "projects/my-project-id"), or a project number (such as "projects/12345").
    * @param {Object} request.outputConfig
    *   Required. Output configuration indicating where the results will be output
    *   to. All results will be in newline delimited JSON format.
@@ -237,7 +237,7 @@ class AssetServiceClient {
    *
    *   This object should have the same structure as [Timestamp]{@link google.protobuf.Timestamp}
    * @param {string[]} [request.assetTypes]
-   *   A list of asset types of which to take a snapshot for. Example:
+   *   A list of asset types of which to take a snapshot for. For example:
    *   "google.compute.disk". If specified, only matching assets will be returned.
    * @param {number} [request.contentType]
    *   Asset content type. If not specified, no content but the asset name will be
@@ -338,18 +338,18 @@ class AssetServiceClient {
   }
 
   /**
-   * Batch gets assets update history that overlaps a time window.
+   * Batch gets the update history of assets that overlap a time window.
    * For RESOURCE content, this API outputs history with asset in both
    * non-delete or deleted status.
-   * For IAM_POLICY content, this API only outputs history when asset and its
-   * attached IAM POLICY both exist. So there may be gaps in the output history.
+   * For IAM_POLICY content, this API outputs history when the asset and its
+   * attached IAM POLICY both exist. This can create gaps in the output history.
    *
    * @param {Object} request
    *   The request object that will be sent.
    * @param {string} request.parent
    *   Required. The relative name of the root asset. It can only be an
-   *   organization number (such as "organizations/123"), or a project id (such as
-   *   "projects/my-project-id")"or a project number (such as "projects/12345").
+   *   organization number (such as "organizations/123"), a project ID (such as
+   *   "projects/my-project-id")", or a project number (such as "projects/12345").
    * @param {number} request.contentType
    *   Required. The content type.
    *
@@ -361,10 +361,10 @@ class AssetServiceClient {
    *
    *   This object should have the same structure as [TimeWindow]{@link google.cloud.asset.v1beta1.TimeWindow}
    * @param {string[]} [request.assetNames]
-   *   A list of the full names of the assets. See:
-   *   https://cloud.google.com/apis/design/resource_names#full_resource_name
-   *   Example:
-   *   "//compute.googleapis.com/projects/my_project_123/zones/zone1/instances/instance1".
+   *   A list of the full names of the assets. For example:
+   *   `//compute.googleapis.com/projects/my_project_123/zones/zone1/instances/instance1`.
+   *   See [Resource Names](https://cloud.google.com/apis/design/resource_names#full_resource_name)
+   *   for more info.
    *
    *   The request becomes a no-op if the asset name list is empty, and the max
    *   size of the asset name list is 100 in one request.

diff --git a/packages/google-cloud-asset/src/v1beta1/doc/google/cloud/asset/v1beta1/doc_asset_service.js b/packages/google-cloud-asset/src/v1beta1/doc/google/cloud/asset/v1beta1/doc_asset_service.js
@@ -19,9 +19,9 @@
  * Export asset request.
  *
  * @property {string} parent
- *   Required. The relative name of the root asset. Can only be an organization
- *   number (such as "organizations/123"), or a project id (such as
- *   "projects/my-project-id") or a project number (such as "projects/12345").
+ *   Required. The relative name of the root asset. This can only be an organization
+ *   number (such as "organizations/123"), a project ID (such as
+ *   "projects/my-project-id"), or a project number (such as "projects/12345").
  *
  * @property {Object} readTime
  *   Timestamp to take an asset snapshot. This can only be set to a timestamp in
@@ -33,7 +33,7 @@
  *   This object should have the same structure as [Timestamp]{@link google.protobuf.Timestamp}
  *
  * @property {string[]} assetTypes
- *   A list of asset types of which to take a snapshot for. Example:
+ *   A list of asset types of which to take a snapshot for. For example:
  *   "google.compute.disk". If specified, only matching assets will be returned.
  *
  * @property {number} contentType
@@ -85,14 +85,14 @@ const ExportAssetsResponse = {
  *
  * @property {string} parent
  *   Required. The relative name of the root asset. It can only be an
- *   organization number (such as "organizations/123"), or a project id (such as
- *   "projects/my-project-id")"or a project number (such as "projects/12345").
+ *   organization number (such as "organizations/123"), a project ID (such as
+ *   "projects/my-project-id")", or a project number (such as "projects/12345").
  *
  * @property {string[]} assetNames
- *   A list of the full names of the assets. See:
- *   https://cloud.google.com/apis/design/resource_names#full_resource_name
- *   Example:
- *   "//compute.googleapis.com/projects/my_project_123/zones/zone1/instances/instance1".
+ *   A list of the full names of the assets. For example:
+ *   `//compute.googleapis.com/projects/my_project_123/zones/zone1/instances/instance1`.
+ *   See [Resource Names](https://cloud.google.com/apis/design/resource_names#full_resource_name)
+ *   for more info.
  *
  *   The request becomes a no-op if the asset name list is empty, and the max
  *   size of the asset name list is 100 in one request.
@@ -137,7 +137,7 @@ const BatchGetAssetsHistoryResponse = {
  * Output configuration for export assets destination.
  *
  * @property {Object} gcsDestination
- *   Destination on Google Cloud Storage (GCS).
+ *   Destination on Cloud Storage.
  *
  *   This object should have the same structure as [GcsDestination]{@link google.cloud.asset.v1beta1.GcsDestination}
  *
@@ -150,13 +150,12 @@ const OutputConfig = {
 };
 
 /**
- * A Google Cloud Storage (GCS) location.
+ * A Cloud Storage location.
  *
  * @property {string} uri
- *   The path of the GCS objects. It's the same path that is used by gsutil, for
- *   example: "gs://bucket_name/object_path". See:
- *   https://cloud.google.com/storage/docs/viewing-editing-metadata for more
- *   information.
+ *   The path of the Cloud Storage objects. It's the same path that is used by
+ *    gsutil. For example: "gs://bucket_name/object_path". See [Viewing and Editing Object Metadata](https://cloud.google.com/storage/docs/viewing-editing-metadata)
+ *   for more information.
  *
  * @typedef GcsDestination
  * @memberof google.cloud.asset.v1beta1

diff --git a/packages/google-cloud-asset/src/v1beta1/doc/google/cloud/asset/v1beta1/doc_assets.js b/packages/google-cloud-asset/src/v1beta1/doc/google/cloud/asset/v1beta1/doc_assets.js
@@ -63,14 +63,13 @@ const TimeWindow = {
 };
 
 /**
- * Cloud asset. This include all Google Cloud Platform resources, as well as
- * IAM policies and other non-GCP assets.
+ * Cloud asset. This includes all Google Cloud Platform resources,
+ * Cloud IAM policies, and other non-GCP assets.
  *
  * @property {string} name
- *   The full name of the asset. See:
- *   https://cloud.google.com/apis/design/resource_names#full_resource_name
- *   Example:
- *   "//compute.googleapis.com/projects/my_project_123/zones/zone1/instances/instance1".
+ *   The full name of the asset. For example: `//compute.googleapis.com/projects/my_project_123/zones/zone1/instances/instance1`.
+ *   See [Resource Names](https://cloud.google.com/apis/design/resource_names#full_resource_name)
+ *   for more information.
  *
  * @property {string} assetType
  *   Type of the asset. Example: "google.compute.disk".
@@ -81,8 +80,8 @@ const TimeWindow = {
  *   This object should have the same structure as [Resource]{@link google.cloud.asset.v1beta1.Resource}
  *
  * @property {Object} iamPolicy
- *   Representation of the actual IAM policy set on a cloud resource. For each
- *   resource, there must be at most one IAM policy set on it.
+ *   Representation of the actual Cloud IAM policy set on a cloud resource. For each
+ *   resource, there must be at most one Cloud IAM policy set on it.
  *
  *   This object should have the same structure as [Policy]{@link google.iam.v1.Policy}
  *
@@ -102,8 +101,8 @@ const Asset = {
  *
  * @property {string} discoveryDocumentUri
  *   The URL of the discovery document containing the resource's JSON schema.
- *   Example:
- *   "https://www.googleapis.com/discovery/v1/apis/compute/v1/rest".
+ *   For example:
+ *   `"https://www.googleapis.com/discovery/v1/apis/compute/v1/rest"`.
  *   It will be left unspecified for resources without a discovery-based API,
  *   such as Cloud Bigtable.
  *
@@ -120,12 +119,13 @@ const Asset = {
  *   It will be left unspecified for resources without a REST API.
  *
  * @property {string} parent
- *   The full name of the immediate parent of this resource. See:
- *   https://cloud.google.com/apis/design/resource_names#full_resource_name
+ *   The full name of the immediate parent of this resource. See
+ *   [Resource Names](https://cloud.google.com/apis/design/resource_names#full_resource_name)
+ *   for more information.
  *
- *   For GCP assets, it is the parent resource defined in the IAM policy
- *   hierarchy: https://cloud.google.com/iam/docs/overview#policy_hierarchy.
- *   Example: "//cloudresourcemanager.googleapis.com/projects/my_project_123".
+ *   For GCP assets, it is the parent resource defined in the [Cloud IAM policy
+ *   hierarchy](https://cloud.google.com/iam/docs/overview#policy_hierarchy).
+ *   For example: `"//cloudresourcemanager.googleapis.com/projects/my_project_123"`.
  *
  *   For third-party assets, it is up to the users to define.
  *