Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make DNS batch get zone/changerequest return null for NOT_FOUND #953

Merged
merged 1 commit into from
Apr 22, 2016

Conversation

mziccard
Copy link
Contributor

This fixes #949: DnsBatch.getZone and DnsBatch.getChangeRequest now return null for NOT_FOUND. This PR also adds more tests.

@mziccard mziccard added the api: dns Issues related to the Cloud DNS API. label Apr 22, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 22, 2016
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.006%) to 85.731% when pulling dfbfeeb on mziccard:fix-dns-batch into 0a6c6f7 on GoogleCloudPlatform:master.

return null;
}
// the zone does not exist, so throw an exception
if (serviceException.code() == HTTP_NOT_FOUND

This comment was marked as spam.

@aozarov
Copy link
Contributor

aozarov commented Apr 22, 2016

LGTM

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.001%) to 85.736% when pulling 7d9f33d on mziccard:fix-dns-batch into 0a6c6f7 on GoogleCloudPlatform:master.

@mziccard mziccard merged commit 121783a into googleapis:master Apr 22, 2016
github-actions bot pushed a commit that referenced this pull request Jun 21, 2022
…rm to v2.9.7 (#953)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.cloud:google-cloud-aiplatform](https://togithub.com/googleapis/java-) | `2.9.6` -> `2.9.7` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-aiplatform/2.9.7/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-aiplatform/2.9.7/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-aiplatform/2.9.7/compatibility-slim/2.9.6)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-aiplatform/2.9.7/confidence-slim/2.9.6)](https://docs.renovatebot.com/merge-confidence/) |

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-aiplatform).
github-actions bot pushed a commit that referenced this pull request Jul 6, 2022
🤖 I have created a release *beep* *boop*
---


### Updating meta-information for bleeding-edge SNAPSHOT release.

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot pushed a commit that referenced this pull request Aug 9, 2022
🤖 I have created a release *beep* *boop*
---


### Updating meta-information for bleeding-edge SNAPSHOT release.

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot pushed a commit that referenced this pull request Aug 9, 2022
…953)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.cloud:google-cloud-core](https://togithub.com/googleapis/java-core) | `2.8.7` -> `2.8.8` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.8/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.8/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.8/compatibility-slim/2.8.7)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.8/confidence-slim/2.8.7)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>googleapis/java-core</summary>

### [`v2.8.8`](https://togithub.com/googleapis/java-core/blob/HEAD/CHANGELOG.md#&#8203;288-httpsgithubcomgoogleapisjava-corecomparev287v288-2022-08-04)

[Compare Source](https://togithub.com/googleapis/java-core/compare/v2.8.7...v2.8.8)

##### Dependencies

-   update dependency com.google.errorprone:error_prone_annotations to v2.15.0 ([#&#8203;897](https://togithub.com/googleapis/java-core/issues/897)) ([29e4fc9](https://togithub.com/googleapis/java-core/commit/29e4fc93d5d4d50f7de85eae7a8150314cca6f43))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-video-intelligence).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xNDMuMSIsInVwZGF0ZWRJblZlciI6IjMyLjE0My4xIn0=-->
github-actions bot pushed a commit that referenced this pull request Aug 9, 2022
🤖 I have created a release *beep* *boop*
---


## [2.2.3](googleapis/java-video-intelligence@v2.2.2...v2.2.3) (2022-08-09)


### Dependencies

* update dependency com.google.cloud:google-cloud-core to v2.8.3 ([#943](googleapis/java-video-intelligence#943)) ([5ae4738](googleapis/java-video-intelligence@5ae4738))
* update dependency com.google.cloud:google-cloud-core to v2.8.4 ([#944](googleapis/java-video-intelligence#944)) ([ca5c408](googleapis/java-video-intelligence@ca5c408))
* update dependency com.google.cloud:google-cloud-core to v2.8.5 ([#945](googleapis/java-video-intelligence#945)) ([25d50af](googleapis/java-video-intelligence@25d50af))
* update dependency com.google.cloud:google-cloud-core to v2.8.6 ([#950](googleapis/java-video-intelligence#950)) ([f0fa63d](googleapis/java-video-intelligence@f0fa63d))
* update dependency com.google.cloud:google-cloud-core to v2.8.7 ([#951](googleapis/java-video-intelligence#951)) ([32dfcc0](googleapis/java-video-intelligence@32dfcc0))
* update dependency com.google.cloud:google-cloud-core to v2.8.8 ([#953](googleapis/java-video-intelligence#953)) ([097d337](googleapis/java-video-intelligence@097d337))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v3 ([#946](googleapis/java-video-intelligence#946)) ([0b16401](googleapis/java-video-intelligence@0b16401))
* update dependency com.google.cloud:google-cloud-storage to v2.10.0 ([#949](googleapis/java-video-intelligence#949)) ([38fe68e](googleapis/java-video-intelligence@38fe68e))
* update dependency com.google.cloud:google-cloud-storage to v2.11.0 ([#952](googleapis/java-video-intelligence#952)) ([493c449](googleapis/java-video-intelligence@493c449))
* update dependency com.google.cloud:google-cloud-storage to v2.11.1 ([#954](googleapis/java-video-intelligence#954)) ([9d5a62b](googleapis/java-video-intelligence@9d5a62b))
* update dependency com.google.cloud:google-cloud-storage to v2.11.2 ([#955](googleapis/java-video-intelligence#955)) ([02e5b47](googleapis/java-video-intelligence@02e5b47))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot pushed a commit that referenced this pull request Sep 15, 2022
🤖 I have created a release *beep* *boop*
---


### Updating meta-information for bleeding-edge SNAPSHOT release.

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot pushed a commit that referenced this pull request Sep 30, 2022
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [markupsafe](https://palletsprojects.com/p/markupsafe/) ([changelog](https://markupsafe.palletsprojects.com/changes/)) | `==2.0.1` -> `==2.1.1` | [![age](https://badges.renovateapi.com/packages/pypi/markupsafe/2.1.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/markupsafe/2.1.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/markupsafe/2.1.1/compatibility-slim/2.0.1)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/markupsafe/2.1.1/confidence-slim/2.0.1)](https://docs.renovatebot.com/merge-confidence/) |

---

### ⚠ Dependency Lookup Warnings ⚠

Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information.

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-monitoring).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yMDguMiIsInVwZGF0ZWRJblZlciI6IjMyLjIwOC4yIn0=-->
github-actions bot pushed a commit that referenced this pull request Oct 4, 2022
🤖 I have created a release *beep* *boop*
---


## [2.4.8](https://togithub.com/googleapis/java-containeranalysis/compare/v2.4.7...v2.4.8) (2022-10-03)


### Dependencies

* Update dependency cachetools to v5 ([#963](https://togithub.com/googleapis/java-containeranalysis/issues/963)) ([f8084b8](https://togithub.com/googleapis/java-containeranalysis/commit/f8084b8ca525fdb265e997894465e4e3a784bd68))
* Update dependency certifi to v2022.9.24 ([#947](https://togithub.com/googleapis/java-containeranalysis/issues/947)) ([2a0becd](https://togithub.com/googleapis/java-containeranalysis/commit/2a0becd99be8825e299a44d4d2946f9c4587aeea))
* Update dependency charset-normalizer to v2.1.1 ([#952](https://togithub.com/googleapis/java-containeranalysis/issues/952)) ([4ac4198](https://togithub.com/googleapis/java-containeranalysis/commit/4ac4198b02c38816cc5279203370e9bcf10ca320))
* Update dependency click to v8.1.3 ([#953](https://togithub.com/googleapis/java-containeranalysis/issues/953)) ([7f2cd56](https://togithub.com/googleapis/java-containeranalysis/commit/7f2cd5655f49d6d2db4519b9096d2800d76eb58a))
* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.4 ([#967](https://togithub.com/googleapis/java-containeranalysis/issues/967)) ([44d2acd](https://togithub.com/googleapis/java-containeranalysis/commit/44d2acd1775a20bb678312c063b6edf914dbbc00))
* Update dependency gcp-releasetool to v1.8.8 ([#948](https://togithub.com/googleapis/java-containeranalysis/issues/948)) ([932e614](https://togithub.com/googleapis/java-containeranalysis/commit/932e61468598c1b521806bdd85492aa79c3a5037))
* Update dependency google-api-core to v2.10.1 ([#954](https://togithub.com/googleapis/java-containeranalysis/issues/954)) ([4e0b27c](https://togithub.com/googleapis/java-containeranalysis/commit/4e0b27c3e94b142658a7042b5b66eb85cf07339b))
* Update dependency google-auth to v2.11.1 ([#949](https://togithub.com/googleapis/java-containeranalysis/issues/949)) ([3436e5c](https://togithub.com/googleapis/java-containeranalysis/commit/3436e5c480fd441d9d6544e33f776fa039f5ee7b))
* Update dependency google-cloud-core to v2.3.2 ([#950](https://togithub.com/googleapis/java-containeranalysis/issues/950)) ([cf1a882](https://togithub.com/googleapis/java-containeranalysis/commit/cf1a8823d431d5dfe0a373ee4e9fe25c255e720d))
* Update dependency google-cloud-storage to v2.5.0 ([#955](https://togithub.com/googleapis/java-containeranalysis/issues/955)) ([ff75df9](https://togithub.com/googleapis/java-containeranalysis/commit/ff75df994404a2fc67cac7680d9f7c27c4a53b3f))
* Update dependency google-crc32c to v1.5.0 ([#956](https://togithub.com/googleapis/java-containeranalysis/issues/956)) ([e5d6c21](https://togithub.com/googleapis/java-containeranalysis/commit/e5d6c21d66d4ab2395f27825c19a5b6b6c404baa))
* Update dependency googleapis-common-protos to v1.56.4 ([#951](https://togithub.com/googleapis/java-containeranalysis/issues/951)) ([c0a937f](https://togithub.com/googleapis/java-containeranalysis/commit/c0a937f7dfe786a226361a2a5a7f32a04164c5b6))
* Update dependency markupsafe to v2.1.1 ([#957](https://togithub.com/googleapis/java-containeranalysis/issues/957)) ([8ca520d](https://togithub.com/googleapis/java-containeranalysis/commit/8ca520decf514a494e27cd5b98e2fb427b110c19))
* Update dependency protobuf to v3.20.2 ([#958](https://togithub.com/googleapis/java-containeranalysis/issues/958)) ([e9a5588](https://togithub.com/googleapis/java-containeranalysis/commit/e9a5588dc5bed8d22a2d9b5790005726ca4609f8))
* Update dependency protobuf to v4 ([#964](https://togithub.com/googleapis/java-containeranalysis/issues/964)) ([94ee22e](https://togithub.com/googleapis/java-containeranalysis/commit/94ee22e5cc71f82ffb6f36ba717a6302a725de02))
* Update dependency requests to v2.28.1 ([#960](https://togithub.com/googleapis/java-containeranalysis/issues/960)) ([cb05cff](https://togithub.com/googleapis/java-containeranalysis/commit/cb05cffbe25c60c6f30d46511307031f4cfdc413))
* Update dependency typing-extensions to v4.3.0 ([#961](https://togithub.com/googleapis/java-containeranalysis/issues/961)) ([cf68902](https://togithub.com/googleapis/java-containeranalysis/commit/cf68902904d7a42f8b7d401c2dcf1f357b64bf6c))
* Update dependency zipp to v3.8.1 ([#962](https://togithub.com/googleapis/java-containeranalysis/issues/962)) ([e71d9d1](https://togithub.com/googleapis/java-containeranalysis/commit/e71d9d17af2e6d524029c6490ad4a75efcfbb4f5))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
github-actions bot pushed a commit that referenced this pull request Oct 5, 2022
suztomo pushed a commit that referenced this pull request Feb 1, 2023
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [jinja2](https://palletsprojects.com/p/jinja/) ([changelog](https://jinja.palletsprojects.com/changes/)) | `==3.0.3` -> `==3.1.2` | [![age](https://badges.renovateapi.com/packages/pypi/jinja2/3.1.2/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/jinja2/3.1.2/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/jinja2/3.1.2/compatibility-slim/3.0.3)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/jinja2/3.1.2/confidence-slim/3.0.3)](https://docs.renovatebot.com/merge-confidence/) |

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-core).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yMDguMiIsInVwZGF0ZWRJblZlciI6IjMyLjIwOC4yIn0=-->
suztomo pushed a commit that referenced this pull request Feb 1, 2023
🤖 I have created a release *beep* *boop*
---


## [2.8.17](googleapis/java-core@v2.8.16...v2.8.17) (2022-09-28)


### Dependencies

* Update dependency cachetools to v5 ([#943](googleapis/java-core#943)) ([1406c09](googleapis/java-core@1406c09))
* Update dependency certifi to v2022.9.24 ([#934](googleapis/java-core#934)) ([b6e1904](googleapis/java-core@b6e1904))
* Update dependency charset-normalizer to v2.1.1 ([#938](googleapis/java-core#938)) ([ac43d61](googleapis/java-core@ac43d61))
* Update dependency click to v8.1.3 ([#946](googleapis/java-core#946)) ([05fe31f](googleapis/java-core@05fe31f))
* Update dependency com.google.api.grpc:proto-google-common-protos to v2.9.4 ([#945](googleapis/java-core#945)) ([3ebff6f](googleapis/java-core@3ebff6f))
* Update dependency gcp-releasetool to v1.8.8 ([#935](googleapis/java-core#935)) ([0f99ae1](googleapis/java-core@0f99ae1))
* Update dependency google-api-core to v2.10.1 ([#947](googleapis/java-core#947)) ([dedddfe](googleapis/java-core@dedddfe))
* Update dependency google-auth to v2.12.0 ([#948](googleapis/java-core#948)) ([67e53aa](googleapis/java-core@67e53aa))
* Update dependency google-cloud-core to v2.3.2 ([#936](googleapis/java-core#936)) ([a0d2e3e](googleapis/java-core@a0d2e3e))
* Update dependency google-cloud-storage to v2.5.0 ([#949](googleapis/java-core#949)) ([6edc6e3](googleapis/java-core@6edc6e3))
* Update dependency google-crc32c to v1.5.0 ([#950](googleapis/java-core#950)) ([0dda0a2](googleapis/java-core@0dda0a2))
* Update dependency googleapis-common-protos to v1.56.4 ([#937](googleapis/java-core#937)) ([b22a2b1](googleapis/java-core@b22a2b1))
* Update dependency importlib-metadata to v4.12.0 ([#951](googleapis/java-core#951)) ([6abe579](googleapis/java-core@6abe579))
* Update dependency jeepney to v0.8.0 ([#952](googleapis/java-core#952)) ([6a392e8](googleapis/java-core@6a392e8))
* Update dependency jinja2 to v3.1.2 ([#953](googleapis/java-core#953)) ([18a54a7](googleapis/java-core@18a54a7))
* Update dependency keyring to v23.9.3 ([#954](googleapis/java-core#954)) ([5ceabaa](googleapis/java-core@5ceabaa))
* Update dependency markupsafe to v2.1.1 ([#955](googleapis/java-core#955)) ([f64e9bf](googleapis/java-core@f64e9bf))
* Update dependency protobuf to v3.20.2 ([#956](googleapis/java-core#956)) ([fb1aea6](googleapis/java-core@fb1aea6))
* Update dependency protobuf to v4 ([#944](googleapis/java-core#944)) ([6b02535](googleapis/java-core@6b02535))
* Update dependency pyjwt to v2.5.0 ([#939](googleapis/java-core#939)) ([cc8ba46](googleapis/java-core@cc8ba46))
* Update dependency requests to v2.28.1 ([#940](googleapis/java-core#940)) ([ec195e3](googleapis/java-core@ec195e3))
* Update dependency typing-extensions to v4.3.0 ([#941](googleapis/java-core#941)) ([4c414e9](googleapis/java-core@4c414e9))
* Update dependency zipp to v3.8.1 ([#942](googleapis/java-core#942)) ([6dfb0d8](googleapis/java-core@6dfb0d8))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: dns Issues related to the Cloud DNS API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DNS batch getZone do not return null for NOT FOUND
4 participants