Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: [container] clarified wording around the NodePoolUpdateStrategy default behavior #9046

Merged
merged 6 commits into from
Feb 2, 2023
Merged

docs: [container] clarified wording around the NodePoolUpdateStrategy default behavior #9046

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f9b07d4
docs: clarified wording around the NodePoolUpdateStrategy default beh…
gcf-owl-bot[bot] Jan 27, 2023
0fdb674
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Jan 27, 2023
8f98f0f
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Jan 27, 2023
e6bc6e7
Merge branch 'owl-bot-copy-java-container' of https://github.com/goog…
gcf-owl-bot[bot] Jan 27, 2023
001d8a4
docs: clarified wording around the NodePoolUpdateStrategy default beh…
gcf-owl-bot[bot] Jan 27, 2023
2a699fb
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Jan 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
6 changes: 3 additions & 3 deletions java-container/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,20 +19,20 @@ If you are using Maven, add this to your pom.xml file:
<dependency>
<groupId>com.google.cloud</groupId>
<artifactId>google-cloud-container</artifactId>
<version>2.11.0</version>
<version>2.12.0</version>
</dependency>
```

If you are using Gradle without BOM, add this to your dependencies:

```Groovy
implementation 'com.google.cloud:google-cloud-container:2.11.0'
implementation 'com.google.cloud:google-cloud-container:2.12.0'
```

If you are using SBT, add this to your dependencies:

```Scala
libraryDependencies += "com.google.cloud" % "google-cloud-container" % "2.11.0"
libraryDependencies += "com.google.cloud" % "google-cloud-container" % "2.12.0"
```

## Authentication
Expand Down
8 changes: 4 additions & 4 deletions ...r/proto-google-cloud-container-v1/src/main/java/com/google/container/v1/AddonsConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ public com.google.container.v1.HorizontalPodAutoscaling getHorizontalPodAutoscal
* </code>
*
* @deprecated google.container.v1.AddonsConfig.kubernetes_dashboard is deprecated. See
* google/container/v1/cluster_service.proto;l=1092
* google/container/v1/cluster_service.proto;l=1094
* @return Whether the kubernetesDashboard field is set.
*/
@java.lang.Override
Expand All @@ -216,7 +216,7 @@ public boolean hasKubernetesDashboard() {
* </code>
*
* @deprecated google.container.v1.AddonsConfig.kubernetes_dashboard is deprecated. See
* google/container/v1/cluster_service.proto;l=1092
* google/container/v1/cluster_service.proto;l=1094
* @return The kubernetesDashboard.
*/
@java.lang.Override
Expand Down Expand Up @@ -1717,7 +1717,7 @@ public Builder clearHorizontalPodAutoscaling() {
* </code>
*
* @deprecated google.container.v1.AddonsConfig.kubernetes_dashboard is deprecated. See
* google/container/v1/cluster_service.proto;l=1092
* google/container/v1/cluster_service.proto;l=1094
* @return Whether the kubernetesDashboard field is set.
*/
@java.lang.Deprecated
Expand All @@ -1739,7 +1739,7 @@ public boolean hasKubernetesDashboard() {
* </code>
*
* @deprecated google.container.v1.AddonsConfig.kubernetes_dashboard is deprecated. See
* google/container/v1/cluster_service.proto;l=1092
* google/container/v1/cluster_service.proto;l=1094
* @return The kubernetesDashboard.
*/
@java.lang.Deprecated
Expand Down
4 changes: 2 additions & 2 deletions ...oogle-cloud-container-v1/src/main/java/com/google/container/v1/AddonsConfigOrBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ public interface AddonsConfigOrBuilder
* </code>
*
* @deprecated google.container.v1.AddonsConfig.kubernetes_dashboard is deprecated. See
* google/container/v1/cluster_service.proto;l=1092
* google/container/v1/cluster_service.proto;l=1094
* @return Whether the kubernetesDashboard field is set.
*/
@java.lang.Deprecated
Expand All @@ -137,7 +137,7 @@ public interface AddonsConfigOrBuilder
* </code>
*
* @deprecated google.container.v1.AddonsConfig.kubernetes_dashboard is deprecated. See
* google/container/v1/cluster_service.proto;l=1092
* google/container/v1/cluster_service.proto;l=1094
* @return The kubernetesDashboard.
*/
@java.lang.Deprecated
Expand Down
42 changes: 28 additions & 14 deletions ...-container-v1/src/main/java/com/google/container/v1/AutoprovisioningNodePoolDefaults.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,7 @@ public com.google.container.v1.NodeManagementOrBuilder getManagementOrBuilder()
* <code>string min_cpu_platform = 5 [deprecated = true];</code>
*
* @deprecated google.container.v1.AutoprovisioningNodePoolDefaults.min_cpu_platform is
* deprecated. See google/container/v1/cluster_service.proto;l=3504
* deprecated. See google/container/v1/cluster_service.proto;l=3508
* @return The minCpuPlatform.
*/
@java.lang.Override
Expand Down Expand Up @@ -350,7 +350,7 @@ public java.lang.String getMinCpuPlatform() {
* <code>string min_cpu_platform = 5 [deprecated = true];</code>
*
* @deprecated google.container.v1.AutoprovisioningNodePoolDefaults.min_cpu_platform is
* deprecated. See google/container/v1/cluster_service.proto;l=3504
* deprecated. See google/container/v1/cluster_service.proto;l=3508
* @return The bytes for minCpuPlatform.
*/
@java.lang.Override
Expand Down Expand Up @@ -562,7 +562,9 @@ public com.google.protobuf.ByteString getBootDiskKmsKeyBytes() {
*
*
* <pre>
* The image type to use for NAP created node.
* The image type to use for NAP created node. Please see
* https://cloud.google.com/kubernetes-engine/docs/concepts/node-images for
* available image types.
* </pre>
*
* <code>string image_type = 10;</code>
Expand All @@ -585,7 +587,9 @@ public java.lang.String getImageType() {
*
*
* <pre>
* The image type to use for NAP created node.
* The image type to use for NAP created node. Please see
* https://cloud.google.com/kubernetes-engine/docs/concepts/node-images for
* available image types.
* </pre>
*
* <code>string image_type = 10;</code>
Expand Down Expand Up @@ -1875,7 +1879,7 @@ public com.google.container.v1.NodeManagementOrBuilder getManagementOrBuilder()
* <code>string min_cpu_platform = 5 [deprecated = true];</code>
*
* @deprecated google.container.v1.AutoprovisioningNodePoolDefaults.min_cpu_platform is
* deprecated. See google/container/v1/cluster_service.proto;l=3504
* deprecated. See google/container/v1/cluster_service.proto;l=3508
* @return The minCpuPlatform.
*/
@java.lang.Deprecated
Expand Down Expand Up @@ -1911,7 +1915,7 @@ public java.lang.String getMinCpuPlatform() {
* <code>string min_cpu_platform = 5 [deprecated = true];</code>
*
* @deprecated google.container.v1.AutoprovisioningNodePoolDefaults.min_cpu_platform is
* deprecated. See google/container/v1/cluster_service.proto;l=3504
* deprecated. See google/container/v1/cluster_service.proto;l=3508
* @return The bytes for minCpuPlatform.
*/
@java.lang.Deprecated
Expand Down Expand Up @@ -1947,7 +1951,7 @@ public com.google.protobuf.ByteString getMinCpuPlatformBytes() {
* <code>string min_cpu_platform = 5 [deprecated = true];</code>
*
* @deprecated google.container.v1.AutoprovisioningNodePoolDefaults.min_cpu_platform is
* deprecated. See google/container/v1/cluster_service.proto;l=3504
* deprecated. See google/container/v1/cluster_service.proto;l=3508
* @param value The minCpuPlatform to set.
* @return This builder for chaining.
*/
Expand Down Expand Up @@ -1982,7 +1986,7 @@ public Builder setMinCpuPlatform(java.lang.String value) {
* <code>string min_cpu_platform = 5 [deprecated = true];</code>
*
* @deprecated google.container.v1.AutoprovisioningNodePoolDefaults.min_cpu_platform is
* deprecated. See google/container/v1/cluster_service.proto;l=3504
* deprecated. See google/container/v1/cluster_service.proto;l=3508
* @return This builder for chaining.
*/
@java.lang.Deprecated
Expand Down Expand Up @@ -2013,7 +2017,7 @@ public Builder clearMinCpuPlatform() {
* <code>string min_cpu_platform = 5 [deprecated = true];</code>
*
* @deprecated google.container.v1.AutoprovisioningNodePoolDefaults.min_cpu_platform is
* deprecated. See google/container/v1/cluster_service.proto;l=3504
* deprecated. See google/container/v1/cluster_service.proto;l=3508
* @param value The bytes for minCpuPlatform to set.
* @return This builder for chaining.
*/
Expand Down Expand Up @@ -2528,7 +2532,9 @@ public Builder setBootDiskKmsKeyBytes(com.google.protobuf.ByteString value) {
*
*
* <pre>
* The image type to use for NAP created node.
* The image type to use for NAP created node. Please see
* https://cloud.google.com/kubernetes-engine/docs/concepts/node-images for
* available image types.
* </pre>
*
* <code>string image_type = 10;</code>
Expand All @@ -2550,7 +2556,9 @@ public java.lang.String getImageType() {
*
*
* <pre>
* The image type to use for NAP created node.
* The image type to use for NAP created node. Please see
* https://cloud.google.com/kubernetes-engine/docs/concepts/node-images for
* available image types.
* </pre>
*
* <code>string image_type = 10;</code>
Expand All @@ -2572,7 +2580,9 @@ public com.google.protobuf.ByteString getImageTypeBytes() {
*
*
* <pre>
* The image type to use for NAP created node.
* The image type to use for NAP created node. Please see
* https://cloud.google.com/kubernetes-engine/docs/concepts/node-images for
* available image types.
* </pre>
*
* <code>string image_type = 10;</code>
Expand All @@ -2593,7 +2603,9 @@ public Builder setImageType(java.lang.String value) {
*
*
* <pre>
* The image type to use for NAP created node.
* The image type to use for NAP created node. Please see
* https://cloud.google.com/kubernetes-engine/docs/concepts/node-images for
* available image types.
* </pre>
*
* <code>string image_type = 10;</code>
Expand All @@ -2610,7 +2622,9 @@ public Builder clearImageType() {
*
*
* <pre>
* The image type to use for NAP created node.
* The image type to use for NAP created node. Please see
* https://cloud.google.com/kubernetes-engine/docs/concepts/node-images for
* available image types.
* </pre>
*
* <code>string image_type = 10;</code>
Expand Down
12 changes: 8 additions & 4 deletions ...r-v1/src/main/java/com/google/container/v1/AutoprovisioningNodePoolDefaultsOrBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ public interface AutoprovisioningNodePoolDefaultsOrBuilder
* <code>string min_cpu_platform = 5 [deprecated = true];</code>
*
* @deprecated google.container.v1.AutoprovisioningNodePoolDefaults.min_cpu_platform is
* deprecated. See google/container/v1/cluster_service.proto;l=3504
* deprecated. See google/container/v1/cluster_service.proto;l=3508
* @return The minCpuPlatform.
*/
@java.lang.Deprecated
Expand All @@ -216,7 +216,7 @@ public interface AutoprovisioningNodePoolDefaultsOrBuilder
* <code>string min_cpu_platform = 5 [deprecated = true];</code>
*
* @deprecated google.container.v1.AutoprovisioningNodePoolDefaults.min_cpu_platform is
* deprecated. See google/container/v1/cluster_service.proto;l=3504
* deprecated. See google/container/v1/cluster_service.proto;l=3508
* @return The bytes for minCpuPlatform.
*/
@java.lang.Deprecated
Expand Down Expand Up @@ -340,7 +340,9 @@ public interface AutoprovisioningNodePoolDefaultsOrBuilder
*
*
* <pre>
* The image type to use for NAP created node.
* The image type to use for NAP created node. Please see
* https://cloud.google.com/kubernetes-engine/docs/concepts/node-images for
* available image types.
* </pre>
*
* <code>string image_type = 10;</code>
Expand All @@ -352,7 +354,9 @@ public interface AutoprovisioningNodePoolDefaultsOrBuilder
*
*
* <pre>
* The image type to use for NAP created node.
* The image type to use for NAP created node. Please see
* https://cloud.google.com/kubernetes-engine/docs/concepts/node-images for
* available image types.
* </pre>
*
* <code>string image_type = 10;</code>
Expand Down
8 changes: 4 additions & 4 deletions ...-google-cloud-container-v1/src/main/java/com/google/container/v1/BinaryAuthorization.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,7 @@ private EvaluationMode(int value) {
* <code>bool enabled = 1 [deprecated = true];</code>
*
* @deprecated google.container.v1.BinaryAuthorization.enabled is deprecated. See
* google/container/v1/cluster_service.proto;l=1327
* google/container/v1/cluster_service.proto;l=1329
* @return The enabled.
*/
@java.lang.Override
Expand Down Expand Up @@ -668,7 +668,7 @@ public Builder mergeFrom(
* <code>bool enabled = 1 [deprecated = true];</code>
*
* @deprecated google.container.v1.BinaryAuthorization.enabled is deprecated. See
* google/container/v1/cluster_service.proto;l=1327
* google/container/v1/cluster_service.proto;l=1329
* @return The enabled.
*/
@java.lang.Override
Expand All @@ -688,7 +688,7 @@ public boolean getEnabled() {
* <code>bool enabled = 1 [deprecated = true];</code>
*
* @deprecated google.container.v1.BinaryAuthorization.enabled is deprecated. See
* google/container/v1/cluster_service.proto;l=1327
* google/container/v1/cluster_service.proto;l=1329
* @param value The enabled to set.
* @return This builder for chaining.
*/
Expand All @@ -712,7 +712,7 @@ public Builder setEnabled(boolean value) {
* <code>bool enabled = 1 [deprecated = true];</code>
*
* @deprecated google.container.v1.BinaryAuthorization.enabled is deprecated. See
* google/container/v1/cluster_service.proto;l=1327
* google/container/v1/cluster_service.proto;l=1329
* @return This builder for chaining.
*/
@java.lang.Deprecated
Expand Down
2 changes: 1 addition & 1 deletion ...loud-container-v1/src/main/java/com/google/container/v1/BinaryAuthorizationOrBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ public interface BinaryAuthorizationOrBuilder
* <code>bool enabled = 1 [deprecated = true];</code>
*
* @deprecated google.container.v1.BinaryAuthorization.enabled is deprecated. See
* google/container/v1/cluster_service.proto;l=1327
* google/container/v1/cluster_service.proto;l=1329
* @return The enabled.
*/
@java.lang.Deprecated
Expand Down
Loading