Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Set parent pom to be google-cloud-java #8848

Merged
merged 1 commit into from
Nov 29, 2022
Merged

chore: Set parent pom to be google-cloud-java #8848

merged 1 commit into from
Nov 29, 2022

Conversation

lqiu96
Copy link
Contributor

@lqiu96 lqiu96 commented Nov 29, 2022

No description provided.

@lqiu96 lqiu96 mentioned this pull request Nov 29, 2022
Merged
@ddixit14
Copy link
Contributor

@suztomo This PR will fix the annotations. set_parent_pom.sh will now make sure that google-cloud-jar-parent and google-cloud-pom-parent will have google-cloud-java as key in the annotation wherever it is declared as a parent.
For gapic-libraries-bom, we are using the file itself for regeneration (in generate_gapic_bom.sh), and it already has google-cloud-java in the annotation. We are not editing this portion of the file while regeneration so it should be good.
Thank you @lqiu96.

@lqiu96 lqiu96 merged commit 0f71f52 into main Nov 29, 2022
@lqiu96 lqiu96 deleted the main-update_parent_pom_script branch November 29, 2022 16:15
@suztomo
Copy link
Member

suztomo commented Nov 29, 2022

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meltsufin meltsufin meltsufin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lqiu96 @ddixit14 @suztomo @meltsufin