deps: Updating gapic-bom, jar & pom-parent versions. #8827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
diff/ root-pom and diff/ gapic-bom tests failing. Running apply_current_versions script to fix it. |
|
All checks passing now. |
suztomo
reviewed
Nov 21, 2022
versions.txt
Outdated
Comment on lines
5
to
6
| google-cloud-jar-parent:1.0.0:1.1.0-SNAPSHOT | ||
| google-cloud-pom-parent:1.0.0:1.1.0-SNAPSHOT |
There was a problem hiding this comment.
Can you consolidate the keys into one? Google-cloud-java sounds good. Do not change artifactIDs.
ddixit14
changed the title
suztomo
approved these changes
Nov 21, 2022
Merged
alicejli
pushed a commit
that referenced
this pull request
Nov 28, 2022
* deps: Updating gapic-bom, jar & pom parent versions. * chore: updating poms * chore: updating key
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps the versions for
gapic-libraries-bom,google-cloud-jar-parentandgoogle-cloud-pom-parentto 1.1.0 for next release.Also consolidated the key for these three artifacts as
google-cloud-java. So from now onwards, these three artifacts should always be on the same version.