Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [servicemanagement] Enable requesting numeric enums in "transport=rest" responses for services supporting this (Java, Go, Python, PHP, TypeScript, C#, and Ruby), even if they do not yet turn on REST transport #8785

Merged
merged 2 commits into from
Dec 6, 2022

Conversation

gcf-owl-bot[bot]
Copy link
Contributor

@gcf-owl-bot gcf-owl-bot bot commented Nov 15, 2022

  • Regenerate this pull request now.

chore: disallow "transport=rest" for services where numeric enums are not confirmed to be supported (except in PHP and Java)
PiperOrigin-RevId: 493113566

Source-Link: googleapis/googleapis@758f0d1

Source-Link: https://github.com/googleapis/googleapis-gen/commit/78bd8f05e1276363eb14eae70e91fe4bc20703ab
Copy-Tag: eyJwIjoiamF2YS1zZXJ2aWNlLW1hbmFnZW1lbnQvLk93bEJvdC55YW1sIiwiaCI6Ijc4YmQ4ZjA1ZTEyNzYzNjNlYjE0ZWFlNzBlOTFmZTRiYzIwNzAzYWIifQ==

feat: added google.api.Service.publishing and client libraries settings
feat: added google.api.JwtLocation.cookie
feat: new fields in enum google.api.ErrorReason
fix: deprecate google.api.Endpoint.aliases
fix: deprecate google.api.BackendRule.min_deadline
docs: minor updates to comments

PiperOrigin-RevId: 488484261

Source-Link: googleapis/googleapis@bd9aa78

Source-Link: https://github.com/googleapis/googleapis-gen/commit/019a6095f9c08c339a15b88088bf9625c2cd1de0
Copy-Tag: eyJwIjoiamF2YS1zZXJ2aWNlLW1hbmFnZW1lbnQvLk93bEJvdC55YW1sIiwiaCI6IjAxOWE2MDk1ZjljMDhjMzM5YTE1Yjg4MDg4YmY5NjI1YzJjZDFkZTAifQ==

@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Nov 15, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 15, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 15, 2022
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Nov 15, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 15, 2022
@yoshi-kokoro yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Nov 15, 2022
@gcf-owl-bot
Copy link
Contributor Author

gcf-owl-bot bot commented Nov 16, 2022

Owl bot is regenerating pull request 8785...
Build name: MDVmZTYzM2QtMjNjZC00YjQ4LTk5MDEtOTNlMDBhYzg3NWJk

@gcf-owl-bot gcf-owl-bot bot force-pushed the owl-bot-copy-java-service-management branch from 58c358e to ae80636 Compare November 16, 2022 21:15
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Nov 16, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 16, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 16, 2022
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Nov 16, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 16, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 16, 2022
@gcf-owl-bot
Copy link
Contributor Author

gcf-owl-bot bot commented Nov 18, 2022

Owl bot is regenerating pull request 8785...
Build name: NWU2ODE0ZDktNWE1Zi00ZWJhLWIxODktYTExZjU3M2I1NjQz

@gcf-owl-bot gcf-owl-bot bot force-pushed the owl-bot-copy-java-service-management branch from f4bbb31 to cd8ff5a Compare November 18, 2022 19:53
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Nov 18, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 18, 2022
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 18, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 18, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 18, 2022
@diegomarquezp
Copy link
Contributor

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.10.1:testCompile (default-testCompile) on project google-cloud-service-management: Compilation failure: Compilation failure:
[ERROR] /tmpfs/src/github/google-cloud-java/java-service-management/google-cloud-service-management/src/test/java/com/google/cloud/api/servicemanagement/v1/ServiceManagerClientHttpJsonTest.java:[36,22] cannot find symbol
[ERROR]   symbol:   class Publishing
[ERROR]   location: package com.google.api

@lqiu96
Copy link
Contributor

lqiu96 commented Nov 21, 2022

@blakeli0 I took a look at the protos and I don't think this is an issue with the protos in this module: (https://github.com/googleapis/googleapis/blob/b6b751420f6b055d9445e81d35f90c0a2ee16b05/google/api/servicemanagement/v1/servicemanager.proto). I'm leaning towards this being an issue with gapic-generator.

It affects the auto-generated unitTest getServiceConfigTest found at:

The Service.java implementation:
https://github.com/googleapis/java-common-protos/blob/c2cde010a89123375518340819b420358e192302/proto-google-common-protos/src/main/java/com/google/api/Service.java

doesn't have this publisher field and I'm not sure why this is being included.

Can you help us take a look at this?

@lqiu96
Copy link
Contributor

lqiu96 commented Nov 21, 2022

We are missing this PR in java-common-protos: googleapis/java-common-protos#481. Path to resolve this PR:

  • Merged into java-common-protos and release
  • Update the java-common-protos version in shared-deps and release
  • Updated shared-deps version in this repo and then merge this PR

@gcf-owl-bot gcf-owl-bot bot changed the title feat: [servicemanagement] added google.api.Service.publishing and client libraries settings chore: [servicemanagement] Enable requesting numeric enums in "transport=rest" responses for services supporting this (Java, Go, Python, PHP, TypeScript, C#, and Ruby), even if they do not yet turn on REST transport Dec 6, 2022
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Dec 6, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 6, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 6, 2022
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Dec 6, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 6, 2022
@yoshi-kokoro yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Dec 6, 2022
@ddixit14 ddixit14 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 6, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 6, 2022
@suztomo
Copy link
Member

suztomo commented Dec 6, 2022

#8876 Java shared dependencies BOM 3.1.0 has the new common-protos library.

@gcf-owl-bot
Copy link
Contributor Author

gcf-owl-bot bot commented Dec 6, 2022

Owl bot is regenerating pull request 8785...
Build name: NThkZDRhMzctY2I1NC00OWUxLWFmYmQtODk1MDU1MTViYjYw

…for services supporting this (Java, Go, Python, PHP, TypeScript, C#, and Ruby), even if they do not yet turn on REST transport

chore: disallow "transport=rest" for services where numeric enums are not confirmed to be supported (except in PHP and Java)
PiperOrigin-RevId: 493113566

Source-Link: googleapis/googleapis@758f0d1

Source-Link: https://github.com/googleapis/googleapis-gen/commit/78bd8f05e1276363eb14eae70e91fe4bc20703ab
Copy-Tag: eyJwIjoiamF2YS1zZXJ2aWNlLW1hbmFnZW1lbnQvLk93bEJvdC55YW1sIiwiaCI6Ijc4YmQ4ZjA1ZTEyNzYzNjNlYjE0ZWFlNzBlOTFmZTRiYzIwNzAzYWIifQ==

feat: added google.api.Service.publishing and client libraries settings
feat: added google.api.JwtLocation.cookie
feat: new fields in enum google.api.ErrorReason
fix: deprecate google.api.Endpoint.aliases
fix: deprecate google.api.BackendRule.min_deadline
docs: minor updates to comments

PiperOrigin-RevId: 488484261

Source-Link: googleapis/googleapis@bd9aa78

Source-Link: https://github.com/googleapis/googleapis-gen/commit/019a6095f9c08c339a15b88088bf9625c2cd1de0
Copy-Tag: eyJwIjoiamF2YS1zZXJ2aWNlLW1hbmFnZW1lbnQvLk93bEJvdC55YW1sIiwiaCI6IjAxOWE2MDk1ZjljMDhjMzM5YTE1Yjg4MDg4YmY5NjI1YzJjZDFkZTAifQ==
@gcf-owl-bot gcf-owl-bot bot force-pushed the owl-bot-copy-java-service-management branch from 1ab6422 to 4286eb7 Compare December 6, 2022 20:04
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Dec 6, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 6, 2022
@yoshi-kokoro yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Dec 6, 2022
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Dec 6, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 6, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 6, 2022
@ddixit14 ddixit14 merged commit 3334870 into main Dec 6, 2022
@ddixit14 ddixit14 deleted the owl-bot-copy-java-service-management branch December 6, 2022 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants