-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: [servicemanagement] Enable requesting numeric enums in "transport=rest" responses for services supporting this (Java, Go, Python, PHP, TypeScript, C#, and Ruby), even if they do not yet turn on REST transport #8785
Conversation
Owl bot is regenerating pull request 8785... |
58c358e
to
ae80636
Compare
Owl bot is regenerating pull request 8785... |
f4bbb31
to
cd8ff5a
Compare
|
@blakeli0 I took a look at the protos and I don't think this is an issue with the protos in this module: (https://github.com/googleapis/googleapis/blob/b6b751420f6b055d9445e81d35f90c0a2ee16b05/google/api/servicemanagement/v1/servicemanager.proto). I'm leaning towards this being an issue with gapic-generator. It affects the auto-generated unitTest
The Service.java implementation: doesn't have this Can you help us take a look at this? |
We are missing this PR in java-common-protos: googleapis/java-common-protos#481. Path to resolve this PR:
|
#8876 Java shared dependencies BOM 3.1.0 has the new common-protos library. |
Owl bot is regenerating pull request 8785... |
…for services supporting this (Java, Go, Python, PHP, TypeScript, C#, and Ruby), even if they do not yet turn on REST transport chore: disallow "transport=rest" for services where numeric enums are not confirmed to be supported (except in PHP and Java) PiperOrigin-RevId: 493113566 Source-Link: googleapis/googleapis@758f0d1 Source-Link: https://github.com/googleapis/googleapis-gen/commit/78bd8f05e1276363eb14eae70e91fe4bc20703ab Copy-Tag: eyJwIjoiamF2YS1zZXJ2aWNlLW1hbmFnZW1lbnQvLk93bEJvdC55YW1sIiwiaCI6Ijc4YmQ4ZjA1ZTEyNzYzNjNlYjE0ZWFlNzBlOTFmZTRiYzIwNzAzYWIifQ== feat: added google.api.Service.publishing and client libraries settings feat: added google.api.JwtLocation.cookie feat: new fields in enum google.api.ErrorReason fix: deprecate google.api.Endpoint.aliases fix: deprecate google.api.BackendRule.min_deadline docs: minor updates to comments PiperOrigin-RevId: 488484261 Source-Link: googleapis/googleapis@bd9aa78 Source-Link: https://github.com/googleapis/googleapis-gen/commit/019a6095f9c08c339a15b88088bf9625c2cd1de0 Copy-Tag: eyJwIjoiamF2YS1zZXJ2aWNlLW1hbmFnZW1lbnQvLk93bEJvdC55YW1sIiwiaCI6IjAxOWE2MDk1ZjljMDhjMzM5YTE1Yjg4MDg4YmY5NjI1YzJjZDFkZTAifQ==
1ab6422
to
4286eb7
Compare
chore: disallow "transport=rest" for services where numeric enums are not confirmed to be supported (except in PHP and Java)
PiperOrigin-RevId: 493113566
Source-Link: googleapis/googleapis@758f0d1
Source-Link: https://github.com/googleapis/googleapis-gen/commit/78bd8f05e1276363eb14eae70e91fe4bc20703ab
Copy-Tag: eyJwIjoiamF2YS1zZXJ2aWNlLW1hbmFnZW1lbnQvLk93bEJvdC55YW1sIiwiaCI6Ijc4YmQ4ZjA1ZTEyNzYzNjNlYjE0ZWFlNzBlOTFmZTRiYzIwNzAzYWIifQ==
feat: added google.api.Service.publishing and client libraries settings
feat: added google.api.JwtLocation.cookie
feat: new fields in enum google.api.ErrorReason
fix: deprecate google.api.Endpoint.aliases
fix: deprecate google.api.BackendRule.min_deadline
docs: minor updates to comments
PiperOrigin-RevId: 488484261
Source-Link: googleapis/googleapis@bd9aa78
Source-Link: https://github.com/googleapis/googleapis-gen/commit/019a6095f9c08c339a15b88088bf9625c2cd1de0
Copy-Tag: eyJwIjoiamF2YS1zZXJ2aWNlLW1hbmFnZW1lbnQvLk93bEJvdC55YW1sIiwiaCI6IjAxOWE2MDk1ZjljMDhjMzM5YTE1Yjg4MDg4YmY5NjI1YzJjZDFkZTAifQ==