Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Fix update_versions.sh to include beyondcorp #8619

Merged
merged 5 commits into from
Oct 17, 2022
Merged

chore: Fix update_versions.sh to include beyondcorp #8619

merged 5 commits into from
Oct 17, 2022

Conversation

lqiu96
Copy link
Contributor

@lqiu96 lqiu96 commented Oct 17, 2022 •
edited
Loading

This PR resets only the beyondcorp-* module's version.txt

suztomo
suztomo reviewed Oct 17, 2022
View reviewed changes
.release-please-manifest.json
"java-websecurityscanner": "2.4.0",
"java-workflow-executions": "2.4.0",
"java-workflows": "2.4.0"
"java-bigqueryconnection": "2.5.6",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems downgrading. But 2.6.0 release didn't go. So it's reasonable.

suztomo
suztomo requested changes Oct 17, 2022
View reviewed changes
Copy link
Member

@suztomo suztomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you regenerate GAPIC BOM as well? The merged committish should be releasable.

@lqiu96
Copy link
Contributor Author

lqiu96 commented Oct 17, 2022

Waiting for Mike's PR: #8621 before I make any further changes

@lqiu96
Copy link
Contributor Author

lqiu96 commented Oct 17, 2022

I might have accidentally merged the old main commit in: bd889c0

Going to remove that commit. If any issues, I'll create a new PR.

@suztomo
Copy link
Member

suztomo commented Oct 17, 2022

@lqiu96 You have to regenerate BOM and release please config files.

Generated Files Sync / gapic-libraries-bom does not have diff from generated one

@lqiu96
Copy link
Contributor Author

lqiu96 commented Oct 17, 2022 •
edited
Loading

@lqiu96 You have to regenerate BOM and release please config files.

Generated Files Sync / gapic-libraries-bom does not have diff from generated one

It should be ./generation/generate_gapic_bom.sh, right? I ran this earlier and there were no diffs.

Oh, do I also need to run ./generation/apply_current_versions.sh?

@suztomo
Copy link
Member

suztomo commented Oct 17, 2022

apply_current_versions.sh

Right. I see the checks are green now.

@lqiu96 lqiu96 added the automerge Merge the pull request once unit tests and other checks pass. label Oct 17, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit 50afbb7 into main Oct 17, 2022
@gcf-merge-on-green gcf-merge-on-green bot deleted the main-release_fix branch October 17, 2022 16:30
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suztomo suztomo suztomo approved these changes

@meltsufin meltsufin Awaiting requested review from meltsufin

@ddixit14 ddixit14 Awaiting requested review from ddixit14

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lqiu96 @suztomo