Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Run samples in every module #8424

Merged
merged 7 commits into from
Sep 20, 2022
Merged

chore: Run samples in every module #8424

merged 7 commits into from
Sep 20, 2022

Conversation

lqiu96
Copy link
Contributor

@lqiu96 lqiu96 commented Sep 19, 2022

Samples kokoro job should run in the monorepo until they're migrated over to java-doc-samples. This should run the samples in every module.

From Mike's changes at #8425, all the samples/pom.xml and samples/snapshot/pom.xml were deleted. For GAPIC generated libraries, there are no samples to run.

Samples job can be run on presubmit (not required). We'll run the samples in handwritten libraries when they are moved over to the monorepo.

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Sep 19, 2022
@snippet-bot
Copy link

snippet-bot bot commented Sep 20, 2022

No region tags are edited in this PR.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@lqiu96 lqiu96 added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 20, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 20, 2022
@lqiu96 lqiu96 marked this pull request as ready for review September 20, 2022 16:17
@lqiu96 lqiu96 added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 20, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 20, 2022
@lqiu96 lqiu96 merged commit 1b2c275 into main Sep 20, 2022
@lqiu96 lqiu96 deleted the samples_kokoro branch September 20, 2022 16:57
suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Oct 4, 2022
* chore: Run samples in every module

* chore: Add ai-platform secrets

* chore: Get all secrets

* chore: Source missing secrets

* chore: Remove the extra echo

* chore: Remove unused secrets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants