-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Run samples in every module #8424
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
samples
Issues that are directly related to samples.
label
Sep 19, 2022
No region tags are edited in this PR.This comment is generated by snippet-bot.
|
lqiu96
force-pushed
the
samples_kokoro
branch
from
September 20, 2022 14:50
f9bee83
to
e4c8e60
Compare
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Sep 20, 2022
meltsufin
approved these changes
Sep 20, 2022
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Sep 20, 2022
suztomo
pushed a commit
to suztomo/google-cloud-java
that referenced
this pull request
Oct 4, 2022
* chore: Run samples in every module * chore: Add ai-platform secrets * chore: Get all secrets * chore: Source missing secrets * chore: Remove the extra echo * chore: Remove unused secrets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Samples kokoro job should run in the monorepo until they're migrated over to java-doc-samples. This should run the samples in every module.From Mike's changes at #8425, all the samples/pom.xml and samples/snapshot/pom.xml were deleted. For GAPIC generated libraries, there are no samples to run.
Samples job can be run on presubmit (not required). We'll run the samples in handwritten libraries when they are moved over to the monorepo.