Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [container] added High Throughput Logging API for Google Kubernetes Engine #8413

Merged
merged 4 commits into from
Sep 20, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion java-container/.github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
# https://help.github.com/en/github/creating-cloning-and-archiving-repositories/about-code-owners#codeowners-syntax

# The @googleapis/yoshi-java is the default owner for changes in this repo
* @googleapis/yoshi-java
* @googleapis/yoshi-java @googleapis/yoshi-java


# The java-samples-reviewers team is the default owner for samples changes
Expand Down
4 changes: 2 additions & 2 deletions java-container/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -56,13 +56,13 @@ implementation 'com.google.cloud:google-cloud-container'
If you are using Gradle without BOM, add this to your dependencies:

```Groovy
implementation 'com.google.cloud:google-cloud-container:2.5.1'
implementation 'com.google.cloud:google-cloud-container:2.5.2'
```

If you are using SBT, add this to your dependencies:

```Scala
libraryDependencies += "com.google.cloud" % "google-cloud-container" % "2.5.1"
libraryDependencies += "com.google.cloud" % "google-cloud-container" % "2.5.2"
```

## Authentication
Expand Down

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -95,17 +95,17 @@
* <p>For example, to set the total timeout of listClusters to 30 seconds:
*
* <pre>{@code
* // This snippet has been automatically generated for illustrative purposes only.
* // It may require modifications to work in your environment.
* // This snippet has been automatically generated and should be regarded as a code template only.
* // It will require modifications to work:
* // - It may require correct/in-range values for request initialization.
* // - It may require specifying regional endpoints when creating the service client as shown in
* // https://cloud.google.com/java/docs/setup#configure_endpoints_for_the_client_library
* ClusterManagerSettings.Builder clusterManagerSettingsBuilder =
* ClusterManagerSettings.newBuilder();
* clusterManagerSettingsBuilder
* .listClustersSettings()
* .setRetrySettings(
* clusterManagerSettingsBuilder
* .listClustersSettings()
* .getRetrySettings()
* .toBuilder()
* clusterManagerSettingsBuilder.listClustersSettings().getRetrySettings().toBuilder()
* .setTotalTimeout(Duration.ofSeconds(30))
* .build());
* ClusterManagerSettings clusterManagerSettings = clusterManagerSettingsBuilder.build();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,11 @@
* <p>Sample for ClusterManagerClient:
*
* <pre>{@code
* // This snippet has been automatically generated for illustrative purposes only.
* // It may require modifications to work in your environment.
* // This snippet has been automatically generated and should be regarded as a code template only.
* // It will require modifications to work:
* // - It may require correct/in-range values for request initialization.
* // - It may require specifying regional endpoints when creating the service client as shown in
* // https://cloud.google.com/java/docs/setup#configure_endpoints_for_the_client_library
* try (ClusterManagerClient clusterManagerClient = ClusterManagerClient.create()) {
* String parent = "parent-995424086";
* ListClustersResponse response = clusterManagerClient.listClusters(parent);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -111,17 +111,17 @@
* <p>For example, to set the total timeout of listClusters to 30 seconds:
*
* <pre>{@code
* // This snippet has been automatically generated for illustrative purposes only.
* // It may require modifications to work in your environment.
* // This snippet has been automatically generated and should be regarded as a code template only.
* // It will require modifications to work:
* // - It may require correct/in-range values for request initialization.
* // - It may require specifying regional endpoints when creating the service client as shown in
* // https://cloud.google.com/java/docs/setup#configure_endpoints_for_the_client_library
* ClusterManagerStubSettings.Builder clusterManagerSettingsBuilder =
* ClusterManagerStubSettings.newBuilder();
* clusterManagerSettingsBuilder
* .listClustersSettings()
* .setRetrySettings(
* clusterManagerSettingsBuilder
* .listClustersSettings()
* .getRetrySettings()
* .toBuilder()
* clusterManagerSettingsBuilder.listClustersSettings().getRetrySettings().toBuilder()
* .setTotalTimeout(Duration.ofSeconds(30))
* .build());
* ClusterManagerStubSettings clusterManagerSettings = clusterManagerSettingsBuilder.build();
Expand Down

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -97,17 +97,17 @@
* <p>For example, to set the total timeout of listClusters to 30 seconds:
*
* <pre>{@code
* // This snippet has been automatically generated for illustrative purposes only.
* // It may require modifications to work in your environment.
* // This snippet has been automatically generated and should be regarded as a code template only.
* // It will require modifications to work:
* // - It may require correct/in-range values for request initialization.
* // - It may require specifying regional endpoints when creating the service client as shown in
* // https://cloud.google.com/java/docs/setup#configure_endpoints_for_the_client_library
* ClusterManagerSettings.Builder clusterManagerSettingsBuilder =
* ClusterManagerSettings.newBuilder();
* clusterManagerSettingsBuilder
* .listClustersSettings()
* .setRetrySettings(
* clusterManagerSettingsBuilder
* .listClustersSettings()
* .getRetrySettings()
* .toBuilder()
* clusterManagerSettingsBuilder.listClustersSettings().getRetrySettings().toBuilder()
* .setTotalTimeout(Duration.ofSeconds(30))
* .build());
* ClusterManagerSettings clusterManagerSettings = clusterManagerSettingsBuilder.build();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,11 @@
* <p>Sample for ClusterManagerClient:
*
* <pre>{@code
* // This snippet has been automatically generated for illustrative purposes only.
* // It may require modifications to work in your environment.
* // This snippet has been automatically generated and should be regarded as a code template only.
* // It will require modifications to work:
* // - It may require correct/in-range values for request initialization.
* // - It may require specifying regional endpoints when creating the service client as shown in
* // https://cloud.google.com/java/docs/setup#configure_endpoints_for_the_client_library
* try (ClusterManagerClient clusterManagerClient = ClusterManagerClient.create()) {
* String projectId = "projectId-894832108";
* String zone = "zone3744684";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -113,17 +113,17 @@
* <p>For example, to set the total timeout of listClusters to 30 seconds:
*
* <pre>{@code
* // This snippet has been automatically generated for illustrative purposes only.
* // It may require modifications to work in your environment.
* // This snippet has been automatically generated and should be regarded as a code template only.
* // It will require modifications to work:
* // - It may require correct/in-range values for request initialization.
* // - It may require specifying regional endpoints when creating the service client as shown in
* // https://cloud.google.com/java/docs/setup#configure_endpoints_for_the_client_library
* ClusterManagerStubSettings.Builder clusterManagerSettingsBuilder =
* ClusterManagerStubSettings.newBuilder();
* clusterManagerSettingsBuilder
* .listClustersSettings()
* .setRetrySettings(
* clusterManagerSettingsBuilder
* .listClustersSettings()
* .getRetrySettings()
* .toBuilder()
* clusterManagerSettingsBuilder.listClustersSettings().getRetrySettings().toBuilder()
* .setTotalTimeout(Duration.ofSeconds(30))
* .build());
* ClusterManagerStubSettings clusterManagerSettings = clusterManagerSettingsBuilder.build();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@
import com.google.container.v1.NodePoolAutoConfig;
import com.google.container.v1.NodePoolAutoscaling;
import com.google.container.v1.NodePoolDefaults;
import com.google.container.v1.NodePoolLoggingConfig;
import com.google.container.v1.NodeTaints;
import com.google.container.v1.NotificationConfig;
import com.google.container.v1.Operation;
Expand Down Expand Up @@ -712,6 +713,7 @@ public void updateNodePoolTest() throws Exception {
.setGcfsConfig(GcfsConfig.newBuilder().build())
.setConfidentialNodes(ConfidentialNodes.newBuilder().build())
.setGvnic(VirtualNIC.newBuilder().build())
.setLoggingConfig(NodePoolLoggingConfig.newBuilder().build())
.build();

Operation actualResponse = client.updateNodePool(request);
Expand Down Expand Up @@ -741,6 +743,7 @@ public void updateNodePoolTest() throws Exception {
Assert.assertEquals(request.getGcfsConfig(), actualRequest.getGcfsConfig());
Assert.assertEquals(request.getConfidentialNodes(), actualRequest.getConfidentialNodes());
Assert.assertEquals(request.getGvnic(), actualRequest.getGvnic());
Assert.assertEquals(request.getLoggingConfig(), actualRequest.getLoggingConfig());
Assert.assertTrue(
channelProvider.isHeaderSent(
ApiClientHeaderProvider.getDefaultApiClientHeaderKey(),
Expand Down Expand Up @@ -774,6 +777,7 @@ public void updateNodePoolExceptionTest() throws Exception {
.setGcfsConfig(GcfsConfig.newBuilder().build())
.setConfidentialNodes(ConfidentialNodes.newBuilder().build())
.setGvnic(VirtualNIC.newBuilder().build())
.setLoggingConfig(NodePoolLoggingConfig.newBuilder().build())
.build();
client.updateNodePool(request);
Assert.fail("No exception raised");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@
import com.google.container.v1beta1.NodePoolAutoConfig;
import com.google.container.v1beta1.NodePoolAutoscaling;
import com.google.container.v1beta1.NodePoolDefaults;
import com.google.container.v1beta1.NodePoolLoggingConfig;
import com.google.container.v1beta1.NodeTaints;
import com.google.container.v1beta1.NotificationConfig;
import com.google.container.v1beta1.Operation;
Expand Down Expand Up @@ -493,6 +494,7 @@ public void updateNodePoolTest() throws Exception {
.setGcfsConfig(GcfsConfig.newBuilder().build())
.setConfidentialNodes(ConfidentialNodes.newBuilder().build())
.setGvnic(VirtualNIC.newBuilder().build())
.setLoggingConfig(NodePoolLoggingConfig.newBuilder().build())
.build();

Operation actualResponse = client.updateNodePool(request);
Expand Down Expand Up @@ -522,6 +524,7 @@ public void updateNodePoolTest() throws Exception {
Assert.assertEquals(request.getGcfsConfig(), actualRequest.getGcfsConfig());
Assert.assertEquals(request.getConfidentialNodes(), actualRequest.getConfidentialNodes());
Assert.assertEquals(request.getGvnic(), actualRequest.getGvnic());
Assert.assertEquals(request.getLoggingConfig(), actualRequest.getLoggingConfig());
Assert.assertTrue(
channelProvider.isHeaderSent(
ApiClientHeaderProvider.getDefaultApiClientHeaderKey(),
Expand Down Expand Up @@ -555,6 +558,7 @@ public void updateNodePoolExceptionTest() throws Exception {
.setGcfsConfig(GcfsConfig.newBuilder().build())
.setConfidentialNodes(ConfidentialNodes.newBuilder().build())
.setGvnic(VirtualNIC.newBuilder().build())
.setLoggingConfig(NodePoolLoggingConfig.newBuilder().build())
.build();
client.updateNodePool(request);
Assert.fail("No exception raised");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -374,7 +374,7 @@ public com.google.container.v1.HorizontalPodAutoscaling getHorizontalPodAutoscal
* </code>
*
* @deprecated google.container.v1.AddonsConfig.kubernetes_dashboard is deprecated. See
* google/container/v1/cluster_service.proto;l=1005
* google/container/v1/cluster_service.proto;l=1009
* @return Whether the kubernetesDashboard field is set.
*/
@java.lang.Override
Expand All @@ -397,7 +397,7 @@ public boolean hasKubernetesDashboard() {
* </code>
*
* @deprecated google.container.v1.AddonsConfig.kubernetes_dashboard is deprecated. See
* google/container/v1/cluster_service.proto;l=1005
* google/container/v1/cluster_service.proto;l=1009
* @return The kubernetesDashboard.
*/
@java.lang.Override
Expand Down Expand Up @@ -1725,7 +1725,7 @@ public Builder clearHorizontalPodAutoscaling() {
* </code>
*
* @deprecated google.container.v1.AddonsConfig.kubernetes_dashboard is deprecated. See
* google/container/v1/cluster_service.proto;l=1005
* google/container/v1/cluster_service.proto;l=1009
* @return Whether the kubernetesDashboard field is set.
*/
@java.lang.Deprecated
Expand All @@ -1747,7 +1747,7 @@ public boolean hasKubernetesDashboard() {
* </code>
*
* @deprecated google.container.v1.AddonsConfig.kubernetes_dashboard is deprecated. See
* google/container/v1/cluster_service.proto;l=1005
* google/container/v1/cluster_service.proto;l=1009
* @return The kubernetesDashboard.
*/
@java.lang.Deprecated
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ public interface AddonsConfigOrBuilder
* </code>
*
* @deprecated google.container.v1.AddonsConfig.kubernetes_dashboard is deprecated. See
* google/container/v1/cluster_service.proto;l=1005
* google/container/v1/cluster_service.proto;l=1009
* @return Whether the kubernetesDashboard field is set.
*/
@java.lang.Deprecated
Expand All @@ -137,7 +137,7 @@ public interface AddonsConfigOrBuilder
* </code>
*
* @deprecated google.container.v1.AddonsConfig.kubernetes_dashboard is deprecated. See
* google/container/v1/cluster_service.proto;l=1005
* google/container/v1/cluster_service.proto;l=1009
* @return The kubernetesDashboard.
*/
@java.lang.Deprecated
Expand Down
Loading