Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added batch concept supporting list zones calls only. #765

Closed
wants to merge 1 commit into from
Closed

Added batch concept supporting list zones calls only. #765

wants to merge 1 commit into from

Conversation

mderka
Copy link

@mderka mderka commented Mar 18, 2016

This commit contains a concept of batches. It currently supports a single operation (list zones) only, but it is functional and contains the entire stack including tests. If this gets approved, I will proceed by implementing the remaining methods.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 18, 2016
@mderka mderka added the api: dns Issues related to the Cloud DNS API. label Mar 18, 2016
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 84.23% when pulling 1855733 on mderka:batch-concept into 17442b0 on GoogleCloudPlatform:dns-alpha-batch.

mziccard
mziccard reviewed Mar 21, 2016
View reviewed changes
gcloud-java-dns/src/main/java/com/google/gcloud/dns/ZoneInfo.java
@@ -18,6 +18,8 @@

import static com.google.common.base.Preconditions.checkNotNull;

import com.google.api.services.dns.model.ManagedZone;
import com.google.common.base.Function;

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@mziccard
Copy link
Contributor

I did a first pass. There are a couple of comments that are worth discussing.

I know that we already discussed this but seeing it done makes me think whether implementing batch with callbacks could give users the wrong idea that something is happening asynchronously. It feels slightly confusing to me.

@mderka
Copy link
Author

mderka commented Mar 22, 2016

I think that we need to make a joint decision on what should be done with the DnsRpc and DnsImpl. In the mean time, I will fix the clear things and commit them tomorrow.

As far as the callbacks go, would you do instead? I think that futures also make the hint to asynchronous processing. I agree that we should specifically say that no asynchronous processing is happening in the docs, but I still like the callbacks. (Check the design doc for our initial discussion.)

Do you maybe want to schedule a meeting about it?

@mderka mderka added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 22, 2016
@mderka
Copy link
Author

mderka commented Apr 6, 2016

We decided to go for a different concept. Closing.

@mderka mderka closed this Apr 6, 2016
github-actions bot pushed a commit to suztomo/google-cloud-java that referenced this pull request Jun 29, 2022
@renovate-bot
build(deps): update dependency org.apache.maven.plugins:maven-javadoc…
0c4167e 
…-plugin to v3.4.0 (googleapis#765)

[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [org.apache.maven.plugins:maven-javadoc-plugin](https://maven.apache.org/plugins/) | `3.3.2` -> `3.4.0` | [![age](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-javadoc-plugin/3.4.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-javadoc-plugin/3.4.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-javadoc-plugin/3.4.0/compatibility-slim/3.3.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-javadoc-plugin/3.4.0/confidence-slim/3.3.2)](https://docs.renovatebot.com/merge-confidence/) |

---

### Configuration

📅 **Schedule**: At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-resourcemanager).
github-actions bot pushed a commit that referenced this pull request Jun 30, 2022
@suztomo
ci: removing clirr from required checks (#765)
b5c50c6 
Making CLIRR not required. The version bumps are now controlled by the Release Please and OwlBot. The CL authors create appropriate change description to control major version bumps.
github-actions bot pushed a commit that referenced this pull request Jul 14, 2022
@renovate-bot @gcf-owl-bot
build(deps): update dependency com.google.cloud:google-cloud-shared-c…
791cd64 
…onfig to v1.5.1 (#765)

* build(deps): update dependency com.google.cloud:google-cloud-shared-config to v1.5.1

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
github-actions bot pushed a commit that referenced this pull request Jul 18, 2022
@renovate-bot
build(deps): update dependency org.apache.maven.plugins:maven-project…
bc34a29 
…-info-reports-plugin to v3.4.0 (#765)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [org.apache.maven.plugins:maven-project-info-reports-plugin](https://maven.apache.org/plugins/) | `3.3.0` -> `3.4.0` | [![age](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-project-info-reports-plugin/3.4.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-project-info-reports-plugin/3.4.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-project-info-reports-plugin/3.4.0/compatibility-slim/3.3.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-project-info-reports-plugin/3.4.0/confidence-slim/3.3.0)](https://docs.renovatebot.com/merge-confidence/) |

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-datalabeling).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xMTcuNCIsInVwZGF0ZWRJblZlciI6IjMyLjExNy40In0=-->
github-actions bot pushed a commit that referenced this pull request Aug 9, 2022
@gcf-owl-bot
ci: adjust owlbot-java for monorepo (#1500) (#765)
53f896a 
Source-Link: googleapis/synthtool@48f8857
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:b47e411068ffc6e6990cb4e0802fbac9a4488dec7f5f424553518ba21abea208
github-actions bot pushed a commit that referenced this pull request Sep 15, 2022
@release-please
chore(main): release 2.3.3 (#765)
949daa0 
🤖 I have created a release *beep* *boop*
---


## [2.3.3](googleapis/java-iot@v2.3.2...v2.3.3) (2022-09-09)


### Dependencies

* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.2 ([#764](googleapis/java-iot#764)) ([88648c1](googleapis/java-iot@88648c1))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot pushed a commit that referenced this pull request Oct 4, 2022
@release-please
chore(main): release 2.5.5 (#780)
91415a4 
🤖 I have created a release *beep* *boop*
---


## [2.5.5](https://togithub.com/googleapis/java-bigqueryconnection/compare/v2.5.4...v2.5.5) (2022-10-03)


### Dependencies

* Update dependency certifi to v2022.9.24 ([#758](https://togithub.com/googleapis/java-bigqueryconnection/issues/758)) ([8b12153](https://togithub.com/googleapis/java-bigqueryconnection/commit/8b12153365780e57dae0bb5254b9fd36f313d51d))
* Update dependency charset-normalizer to v2.1.1 ([#762](https://togithub.com/googleapis/java-bigqueryconnection/issues/762)) ([c912d0a](https://togithub.com/googleapis/java-bigqueryconnection/commit/c912d0a9b466c33d3fe2dc51e04a8f3f560391e1))
* Update dependency click to v8.1.3 ([#763](https://togithub.com/googleapis/java-bigqueryconnection/issues/763)) ([3270445](https://togithub.com/googleapis/java-bigqueryconnection/commit/3270445bfe9ece2a737cb40768b5613ce730af35))
* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.4 ([#784](https://togithub.com/googleapis/java-bigqueryconnection/issues/784)) ([5e41cd8](https://togithub.com/googleapis/java-bigqueryconnection/commit/5e41cd883f1a1a37b5ad93b76d3c4c7685056787))
* Update dependency com.google.protobuf:protobuf-java-util to v3.21.7 ([#782](https://togithub.com/googleapis/java-bigqueryconnection/issues/782)) ([9d0fe12](https://togithub.com/googleapis/java-bigqueryconnection/commit/9d0fe12996d6e401ed94a759af80bb1950278e39))
* Update dependency gcp-releasetool to v1.8.8 ([#759](https://togithub.com/googleapis/java-bigqueryconnection/issues/759)) ([9955b8f](https://togithub.com/googleapis/java-bigqueryconnection/commit/9955b8f5b4fbcdfc0636c8bd7a14aeae9807363c))
* Update dependency google-api-core to v2.10.1 ([#764](https://togithub.com/googleapis/java-bigqueryconnection/issues/764)) ([aa07e7f](https://togithub.com/googleapis/java-bigqueryconnection/commit/aa07e7faa6618cc644681b0bba7c2c3d7cac3e07))
* Update dependency google-auth to v2.12.0 ([#765](https://togithub.com/googleapis/java-bigqueryconnection/issues/765)) ([b896e86](https://togithub.com/googleapis/java-bigqueryconnection/commit/b896e863a92b5fd07395b8064b990c96a0d29ddd))
* Update dependency google-cloud-core to v2.3.2 ([#760](https://togithub.com/googleapis/java-bigqueryconnection/issues/760)) ([0241ee4](https://togithub.com/googleapis/java-bigqueryconnection/commit/0241ee4ed6db5e6a83db1229fec89305f4168811))
* Update dependency google-cloud-storage to v2.5.0 ([#766](https://togithub.com/googleapis/java-bigqueryconnection/issues/766)) ([7064657](https://togithub.com/googleapis/java-bigqueryconnection/commit/7064657a1ceffee5ddb8f0e7b7a7734b48d6b090))
* Update dependency google-crc32c to v1.5.0 ([#767](https://togithub.com/googleapis/java-bigqueryconnection/issues/767)) ([350b87a](https://togithub.com/googleapis/java-bigqueryconnection/commit/350b87a782357097dd28bc7b847c61afb25f90a6))
* Update dependency googleapis-common-protos to v1.56.4 ([#761](https://togithub.com/googleapis/java-bigqueryconnection/issues/761)) ([11824d3](https://togithub.com/googleapis/java-bigqueryconnection/commit/11824d354e6cad62e6c2ee5c500b24bc3659c9d8))
* Update dependency importlib-metadata to v4.12.0 ([#768](https://togithub.com/googleapis/java-bigqueryconnection/issues/768)) ([dfa42e5](https://togithub.com/googleapis/java-bigqueryconnection/commit/dfa42e5d75b698987a86a980a404789ef74c68ce))
* Update dependency jeepney to v0.8.0 ([#769](https://togithub.com/googleapis/java-bigqueryconnection/issues/769)) ([44f5e0c](https://togithub.com/googleapis/java-bigqueryconnection/commit/44f5e0c34a0d2680a9d79bd129061acd6cfd8e4f))
* Update dependency jinja2 to v3.1.2 ([#778](https://togithub.com/googleapis/java-bigqueryconnection/issues/778)) ([192246f](https://togithub.com/googleapis/java-bigqueryconnection/commit/192246f0c33ec126bf3f3739c2dec0fbc05bf83e))
* Update dependency keyring to v23.9.3 ([#779](https://togithub.com/googleapis/java-bigqueryconnection/issues/779)) ([73daa64](https://togithub.com/googleapis/java-bigqueryconnection/commit/73daa64628deaa7542a98dcb6b056b625cca9f86))
* Update dependency markupsafe to v2.1.1 ([#770](https://togithub.com/googleapis/java-bigqueryconnection/issues/770)) ([0b1e0d9](https://togithub.com/googleapis/java-bigqueryconnection/commit/0b1e0d9f3be5f59a1ddb254e065b5c659da6b9b6))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
github-actions bot pushed a commit that referenced this pull request Oct 5, 2022
@release-please
chore(main): release 2.3.0 (#748)
442153c 
🤖 I have created a release *beep* *boop*
---


## [2.3.0](https://togithub.com/googleapis/java-websecurityscanner/compare/v2.2.4...v2.3.0) (2022-10-04)


### Features

* Added NO_STARTING_URL_FOUND_FOR_MANAGED_SCAN to ScanRunWarningTrace.Code ([#741](https://togithub.com/googleapis/java-websecurityscanner/issues/741)) ([bdc4af4](https://togithub.com/googleapis/java-websecurityscanner/commit/bdc4af46ed6d1d690c60b336e9769fc9ad087578))


### Bug Fixes

* Added fix to return a list of the endpoints that encountered errors during crawl, along with the specific error message when the starting URL returns Http errors ([bdc4af4](https://togithub.com/googleapis/java-websecurityscanner/commit/bdc4af46ed6d1d690c60b336e9769fc9ad087578))
* GoogleAccount is deprecated ([bdc4af4](https://togithub.com/googleapis/java-websecurityscanner/commit/bdc4af46ed6d1d690c60b336e9769fc9ad087578))
* update protobuf to v3.21.7 ([607ea93](https://togithub.com/googleapis/java-websecurityscanner/commit/607ea935cee44edf4c744fcf8d1103b7475c7859))


### Dependencies

* Update dependency cachetools to v5 ([#761](https://togithub.com/googleapis/java-websecurityscanner/issues/761)) ([5c48ffb](https://togithub.com/googleapis/java-websecurityscanner/commit/5c48ffba59c9e119ef8aa07ad9eed4e2bc1df8f4))
* Update dependency certifi to v2022.9.24 ([#754](https://togithub.com/googleapis/java-websecurityscanner/issues/754)) ([45a6597](https://togithub.com/googleapis/java-websecurityscanner/commit/45a65974f15738845d223138f908698c204cf702))
* Update dependency charset-normalizer to v2.1.1 ([#763](https://togithub.com/googleapis/java-websecurityscanner/issues/763)) ([e151a7d](https://togithub.com/googleapis/java-websecurityscanner/commit/e151a7dbafec413768861781c8ff3693e5be1e16))
* Update dependency click to v8.1.3 ([#764](https://togithub.com/googleapis/java-websecurityscanner/issues/764)) ([57f034c](https://togithub.com/googleapis/java-websecurityscanner/commit/57f034cc8733502e9cab72ecd4efd72e33a483c4))
* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.4 ([#774](https://togithub.com/googleapis/java-websecurityscanner/issues/774)) ([a4ca862](https://togithub.com/googleapis/java-websecurityscanner/commit/a4ca8621e8b263d69b273770e0674ce2f44c8024))
* Update dependency gcp-releasetool to v1.8.8 ([#755](https://togithub.com/googleapis/java-websecurityscanner/issues/755)) ([88ecda6](https://togithub.com/googleapis/java-websecurityscanner/commit/88ecda6da20ad542fc2ad3360eee1864e9bdf95b))
* Update dependency google-api-core to v2.10.1 ([#765](https://togithub.com/googleapis/java-websecurityscanner/issues/765)) ([e5e3f7b](https://togithub.com/googleapis/java-websecurityscanner/commit/e5e3f7b50c8c8b9691716557a960d7f10a49dbd5))
* Update dependency google-auth to v2.11.1 ([#756](https://togithub.com/googleapis/java-websecurityscanner/issues/756)) ([26d68c6](https://togithub.com/googleapis/java-websecurityscanner/commit/26d68c63c6804c8d16c3f37b69de1c46efb92f34))
* Update dependency google-cloud-core to v2.3.2 ([#757](https://togithub.com/googleapis/java-websecurityscanner/issues/757)) ([625a1da](https://togithub.com/googleapis/java-websecurityscanner/commit/625a1da75640ee857c63bc6ad652bc4b07215438))
* Update dependency google-cloud-storage to v2.5.0 ([#766](https://togithub.com/googleapis/java-websecurityscanner/issues/766)) ([ec32fb7](https://togithub.com/googleapis/java-websecurityscanner/commit/ec32fb7d4909301d8db8c15c66ac6f8039bef1bb))
* Update dependency googleapis-common-protos to v1.56.4 ([#758](https://togithub.com/googleapis/java-websecurityscanner/issues/758)) ([48a2f9a](https://togithub.com/googleapis/java-websecurityscanner/commit/48a2f9a0fcf1cedc2e77c9ee301f89d69dcf199c))
* Update dependency joda-time:joda-time to v2.11.2 ([#751](https://togithub.com/googleapis/java-websecurityscanner/issues/751)) ([ccabb8e](https://togithub.com/googleapis/java-websecurityscanner/commit/ccabb8ef52ad1459c51ced253a4091c479684609))
* Update dependency protobuf to v4 ([#762](https://togithub.com/googleapis/java-websecurityscanner/issues/762)) ([50d6147](https://togithub.com/googleapis/java-websecurityscanner/commit/50d6147d2ff53de31d8fd3b7248d4d0be62f58e5))
* Update dependency zipp to v3.8.1 ([#760](https://togithub.com/googleapis/java-websecurityscanner/issues/760)) ([f6f5547](https://togithub.com/googleapis/java-websecurityscanner/commit/f6f55472157b78d1b1acfe48b9f067922230bbb8))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
github-actions bot pushed a commit that referenced this pull request Oct 10, 2022
@gcf-owl-bot
chore: [java] generation with shared deps 3.0.4 (#1641) (#765)
34db8a9 
* chore: [java] generation with shared deps 3.0.4

* fix for tests
Source-Link: https://togithub.com/googleapis/synthtool/commit/c3ad3cc9d876a3dd897cc511cf5ef921784851ae
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:5643a4e1b729803e67ddceee450e87052527b37cac394bf900b4f8e3d1bb3e9b
github-actions bot pushed a commit that referenced this pull request Nov 9, 2022
@gcf-owl-bot
chore: Set rest_numeric_enums = False for all gapic rules explicitly (
a84cf24 
#765)

- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 485623855

Source-Link: https://togithub.com/googleapis/googleapis/commit/807125e7953e32535710924fe4bf0362ac93754d

Source-Link: https://togithub.com/googleapis/googleapis-gen/commit/c4ddd6d651da69658a4762c5eafff5cd8f0e25c5
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYzRkZGQ2ZDY1MWRhNjk2NThhNDc2MmM1ZWFmZmY1Y2Q4ZjBlMjVjNSJ9
suztomo pushed a commit that referenced this pull request Feb 1, 2023
@renovate-bot
deps: update dependency com.google.auth:google-auth-library-bom to v1…
aba35a3 
….6.0 (#765)

[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.auth:google-auth-library-bom](https://togithub.com/googleapis/google-auth-library-java) | `1.5.3` -> `1.6.0` | [![age](https://badges.renovateapi.com/packages/maven/com.google.auth:google-auth-library-bom/1.6.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.auth:google-auth-library-bom/1.6.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.auth:google-auth-library-bom/1.6.0/compatibility-slim/1.5.3)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.auth:google-auth-library-bom/1.6.0/confidence-slim/1.5.3)](https://docs.renovatebot.com/merge-confidence/) |

---

### Configuration

📅 **Schedule**: At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-core).
suztomo pushed a commit that referenced this pull request Feb 1, 2023
@release-please
chore(main): release 3.0.1-SNAPSHOT (#765)
e3e5842 
🤖 I have created a release *beep* *boop*
---


### Updating meta-information for bleeding-edge SNAPSHOT release.

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: dns Issues related to the Cloud DNS API. cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mderka @coveralls @mziccard @googlebot