Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make bigquery functional classes extend info classes #609

Merged
merged 5 commits into from
Feb 4, 2016
Merged

Make bigquery functional classes extend info classes #609

merged 5 commits into from
Feb 4, 2016

Conversation

mziccard
Copy link
Contributor

@mziccard mziccard commented Feb 2, 2016

This PR performs the following changes

  • Make Dataset extend DatasetInfo
  • Make Table extend TableInfo
  • Make Job extend JobInfo
  • Update READMEs and snippets
  • Update BigQueryExample
  • Update and add more tests

@mziccard
Make bigquery functional classes extend info classes
b0c0bb7 
- Dataset extends DatasetInfo
- Table extends TableInfo
- Job extends JobInfo
- Update READMEs and snippets
- Update BigQueryExample
- Update and add more tests
@mziccard mziccard added the api: bigquery Issues related to the BigQuery API. label Feb 2, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 2, 2016
@ajkannan
Copy link

ajkannan commented Feb 3, 2016

Since the functional objects should now be serializable, we should add them to SerializationTest

ajkannan
ajkannan reviewed Feb 3, 2016
View reviewed changes
gcloud-java-bigquery/src/main/java/com/google/gcloud/bigquery/Dataset.java
@@ -235,4 +233,42 @@ public Table create(String table, TableDefinition definition, BigQuery.TableOpti
public BigQuery bigquery() {
return bigquery;
}

public static Builder builder(BigQuery bigquery, DatasetId datasetId) {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@ajkannan
Copy link

ajkannan commented Feb 3, 2016

@mziccard took a first pass, looks good! Just some minor comments from me.

aozarov
aozarov reviewed Feb 3, 2016
View reviewed changes
gcloud-java-bigquery/src/main/java/com/google/gcloud/bigquery/DatasetInfo.java
}

/**
* Returns a builder for the DatasetInfo object given it's identity.
* Returns a builder for the DatasetInfo object given it's project and user-defined id.

This comment was marked as spam.

Sign in to view

@mziccard
Minor refactoring bigquery functional objects
94533b2 
- Make Builder public
- Make Dataset.builder package scope
- Add toAndFromPb test
- Remove static get methods
@mziccard
Add functional classes to SerializationTest
5829d81
@mziccard mziccard force-pushed the bigquery-hierachies branch from 9428a03 to 5829d81 Compare February 3, 2016 16:00
@mziccard
Copy link
Contributor Author

mziccard commented Feb 3, 2016

Comments addressed

@ajkannan
Copy link

ajkannan commented Feb 3, 2016

Looks good, one comment from me about removing the functional class builder() methods entirely. I also think we should manually test the snippets in the READMEs/package-info to make sure that there aren't any access issues, missing imports, or typos.

I'll take care of comments that referenced Resource Manager (ie removing the package scope builder() methods from Resource Manager's Project class and making sure any Project.staticMethods() are removed as appropriate).

aozarov
aozarov reviewed Feb 4, 2016
View reviewed changes
gcloud-java-bigquery/src/main/java/com/google/gcloud/bigquery/JobInfo.java
private final String userEmail;
private final JobConfiguration configuration;
/**
* Base class for a {@code JobInfo} builder.

This comment was marked as spam.

Sign in to view

@aozarov
Copy link
Contributor

aozarov commented Feb 4, 2016

Looks great! I really like this change.
Few nits and suggestions.
Also, unrelated:

Missing some @Override annotation
WriteChannelConfiguration
TableDataWriteChannel
QueryJobConfiguration
LoadJobConfiguration
ExtractJobConfiguration
CopyJobConfiguration
BigQueryImpl

Missing servialVersionUID
Acl.View

@ajkannan ajkannan mentioned this pull request Feb 4, 2016
Merged
@mziccard
Refactor bigquery function objects builders
b6ad451 
- Remove static builder methods
- Add builder methods params to builder constructors
- Better javadoc for builder classes
@mziccard
Add missing override annotation and serialVersionUID
fbcbfb4
@mziccard
Copy link
Contributor Author

mziccard commented Feb 4, 2016

Comments fixed and opened #618

aozarov added a commit that referenced this pull request Feb 4, 2016
@aozarov
Merge pull request #609 from mziccard/bigquery-hierachies
4bf3796 
Make bigquery functional classes extend info classes
@aozarov aozarov merged commit 4bf3796 into googleapis:master Feb 4, 2016
github-actions bot pushed a commit that referenced this pull request Jun 21, 2022
@renovate-bot
build(deps): update dependency com.google.cloud:google-cloud-shared-c…
a5f40b1 
…onfig to v1.5.0 (#609)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.cloud:google-cloud-shared-config](https://togithub.com/googleapis/java-shared-config) | `1.4.0` -> `1.5.0` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.5.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.5.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.5.0/compatibility-slim/1.4.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.5.0/confidence-slim/1.4.0)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>googleapis/java-shared-config</summary>

### [`v1.5.0`](https://togithub.com/googleapis/java-shared-config/blob/HEAD/CHANGELOG.md#&#8203;150-httpsgithubcomgoogleapisjava-shared-configcomparev140v150-2022-06-10)

[Compare Source](https://togithub.com/googleapis/java-shared-config/compare/v1.4.0...v1.5.0)

##### Features

-   add build scripts for native image testing in Java 17 ([#&#8203;1440](https://togithub.com/googleapis/java-shared-config/issues/1440)) ([#&#8203;475](https://togithub.com/googleapis/java-shared-config/issues/475)) ([e4dfc1b](https://togithub.com/googleapis/java-shared-config/commit/e4dfc1ba29295158c78c8fcf94467d2a6a33538a))
-   to produce Java 8 compatible bytecode when using JDK 9+ ([2468276](https://togithub.com/googleapis/java-shared-config/commit/2468276145cdfe1ca911b52f765e026e77661a09))

##### Dependencies

-   update surefire.version to v3.0.0-m7 ([bbfe663](https://togithub.com/googleapis/java-shared-config/commit/bbfe66393af3e49612c9c1e4334ba39c133ea1d0))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-monitoring-dashboards).
github-actions bot pushed a commit to suztomo/google-cloud-java that referenced this pull request Jun 29, 2022
@gcf-owl-bot
chore: enable release-trigger bot (googleapis#1192) (googleapis#609)
c743b5a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mziccard @ajkannan @aozarov @googlebot