ManagedZoneInfo class added #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
| import java.util.Objects; | ||
|
|
||
| /** | ||
| * This class is a container for the managed zone metainformation. Managed zone is a resource that |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
I finished processing the comments. The PR is ready for another review pass. |
| } | ||
|
|
||
| @Test | ||
| public void testValidCreationTime() { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Looks good! Just few more nits |
|
I finished the processing the feedback. This is ready for another pass. |
mderka
force-pushed
the
dns-managed-zone
branch
from
c09799e to
dacea19
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Oct 5, 2022
🤖 I have created a release *beep* *boop* --- ## [0.6.6](https://togithub.com/googleapis/java-securitycenter-settings/compare/v0.6.5...v0.6.6) (2022-10-05) ### Dependencies * Update dependency certifi to v2022.9.24 ([#566](https://togithub.com/googleapis/java-securitycenter-settings/issues/566)) ([f9c5954](https://togithub.com/googleapis/java-securitycenter-settings/commit/f9c59549ce924c3d11e3e97c435981ea2e45fdf0)) * Update dependency charset-normalizer to v2.1.1 ([#570](https://togithub.com/googleapis/java-securitycenter-settings/issues/570)) ([1a67981](https://togithub.com/googleapis/java-securitycenter-settings/commit/1a67981fbc19320fbca4abc35b4e6da4a3561b0f)) * Update dependency click to v8.1.3 ([#571](https://togithub.com/googleapis/java-securitycenter-settings/issues/571)) ([a8f784e](https://togithub.com/googleapis/java-securitycenter-settings/commit/a8f784efe83cb56d8ea68a07c3aae2c6a3c7d003)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.4 ([#577](https://togithub.com/googleapis/java-securitycenter-settings/issues/577)) ([1f98eed](https://togithub.com/googleapis/java-securitycenter-settings/commit/1f98eed175c141b30b06a97e5a7834583b1b9f40)) * Update dependency gcp-releasetool to v1.8.8 ([#567](https://togithub.com/googleapis/java-securitycenter-settings/issues/567)) ([663ab9f](https://togithub.com/googleapis/java-securitycenter-settings/commit/663ab9f0f3ce00f34b5b8fcf0c21f696b0fdf455)) * Update dependency google-api-core to v2.10.1 ([#572](https://togithub.com/googleapis/java-securitycenter-settings/issues/572)) ([8dcd58c](https://togithub.com/googleapis/java-securitycenter-settings/commit/8dcd58c2c65d7d64cbb1b4502f5b53eb7b11777c)) * Update dependency google-auth to v2.12.0 ([#573](https://togithub.com/googleapis/java-securitycenter-settings/issues/573)) ([26df30b](https://togithub.com/googleapis/java-securitycenter-settings/commit/26df30bf335aecb286d92195d6ec44c5f2d52f16)) * Update dependency google-cloud-core to v2.3.2 ([#568](https://togithub.com/googleapis/java-securitycenter-settings/issues/568)) ([dd01a84](https://togithub.com/googleapis/java-securitycenter-settings/commit/dd01a84cbf89b05330ce9f05c5a786c6f40ab03f)) * Update dependency google-cloud-storage to v2.5.0 ([#574](https://togithub.com/googleapis/java-securitycenter-settings/issues/574)) ([4b2b3f5](https://togithub.com/googleapis/java-securitycenter-settings/commit/4b2b3f5625c9be96c788ebcda38093d616beb805)) * Update dependency googleapis-common-protos to v1.56.4 ([#569](https://togithub.com/googleapis/java-securitycenter-settings/issues/569)) ([248ad71](https://togithub.com/googleapis/java-securitycenter-settings/commit/248ad71bfb348cdac2e8ea2091a311a1b97eedba)) * Update dependency jinja2 to v3.1.2 ([#575](https://togithub.com/googleapis/java-securitycenter-settings/issues/575)) ([098d82a](https://togithub.com/googleapis/java-securitycenter-settings/commit/098d82ab1cdbc575c075dcde35baecc1f6778a82)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
github-actions bot
pushed a commit
that referenced
this pull request
Oct 5, 2022
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure to open an issue as a [bug/issue](https://togithub.com/googleapis/java-retail/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) Fixes #<issue_number_goes_here> ☕️ If you write sample code, please follow the [samples format]( https://togithub.com/GoogleCloudPlatform/java-docs-samples/blob/main/SAMPLE_FORMAT.md).
suztomo
pushed a commit
that referenced
this pull request
Feb 1, 2023
…2.0 (#575) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:libraries-bom](https://cloud.google.com/java/docs/bom) ([source](https://togithub.com/googleapis/java-cloud-bom)) | `26.1.5` -> `26.2.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-iam). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4yNC4wIiwidXBkYXRlZEluVmVyIjoiMzQuMjQuMCJ9-->
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.