FireStore:deprecated warnings removed #5247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
ajaaym
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Codecov Report
@@ Coverage Diff @@
## master #5247 +/- ##
============================================
+ Coverage 50.48% 50.48% +<.01%
Complexity 23875 23875
============================================
Files 2258 2258
Lines 227482 227483 +1
Branches 24978 24978
============================================
+ Hits 114834 114835 +1
Misses 104029 104029
Partials 8619 8619
Continue to review full report at Codecov.
|
sduskis
reviewed
May 31, 2019
| @@ -339,9 +339,11 @@ public void onSuccess(List<WriteResult> writeResults) { | |||
| span.end(); | |||
| resultFuture.set(userResult); | |||
| } | |||
| }); | |||
There was a problem hiding this comment.
This should be MoreExecutors.directExecutor()
There was a problem hiding this comment.
All callbacks that didn't have an explicit executor should use MoreExecutors.directExecutor()
pmakani
added
the
kokoro:force-run
yoshi-kokoro
removed
kokoro:force-run
Codecov Report
@@ Coverage Diff @@
## master #5247 +/- ##
============================================
+ Coverage 50.48% 50.48% +<.01%
Complexity 23875 23875
============================================
Files 2258 2258
Lines 227482 227483 +1
Branches 24978 24978
============================================
+ Hits 114834 114835 +1
Misses 104029 104029
Partials 8619 8619
Continue to review full report at Codecov.
|
sduskis
approved these changes
Jun 3, 2019
sduskis
added
the
kokoro:force-run
yoshi-kokoro
removed
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works towards #4384