Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nio:Fix deprecated warnings removed #5241

Merged
merged 1 commit into from
May 30, 2019

Conversation

abhinav-qlogic
Copy link

@abhinav-qlogic abhinav-qlogic commented May 30, 2019

Works towards #4384

@abhinav-qlogic abhinav-qlogic requested a review from a team as a code owner May 30, 2019 14:13
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 30, 2019
@sduskis sduskis added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 30, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 30, 2019
@sduskis
Copy link
Contributor

sduskis commented May 30, 2019

@abhinav-qlogic, please be careful not to use "Fixes #..." for these series of PRs, since they only partially fix the issue. Adding the word "Fixes" will close the issue, despite the fact that the work isn't complete. Please see the wording I used for future reference.

@sduskis sduskis merged commit 4ffdda3 into googleapis:master May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants