Update NIO to understand new directory stand-ins #5204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The web interface has a "create folder" button, and that creates a file ending in '/' that is used to pretend the folder exists. The web interface maintains the illusion but of course this is still only a file, so all clients (this one included) has to play along and pretend the directory exists (or users get confused). Those fake folders used to be 0-byte, but no longer. This pull request updates our code so it just looks at the trailing slash, ignoring the size of the file. It also adds a test, and in order to write the test we had to add the ability to create files whose name ends in '/', for test purpose only.
googlebot
added
the
cla: yes
pmakani
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
pmakani
reviewed
May 21, 2019
...e-cloud-nio/src/main/java/com/google/cloud/storage/contrib/nio/OptionAllowTrailingSlash.java
Outdated
Show resolved
Hide resolved
pmakani
reviewed
May 21, 2019
...d-nio/src/main/java/com/google/cloud/storage/contrib/nio/CloudStorageFileSystemProvider.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #5204 +/- ##
============================================
+ Coverage 50.42% 50.42% +<.01%
- Complexity 23796 23816 +20
============================================
Files 2251 2252 +1
Lines 226836 226841 +5
Branches 24966 24961 -5
============================================
+ Hits 114371 114380 +9
+ Misses 103858 103855 -3
+ Partials 8607 8606 -1
Continue to review full report at Codecov.
|
pmakani
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
|
Please run |
|
@sduskis done. |
chingor13
requested changes
May 22, 2019
...e-cloud-nio/src/main/java/com/google/cloud/storage/contrib/nio/OptionAllowTrailingSlash.java
Outdated
Show resolved
Hide resolved
...d-nio/src/main/java/com/google/cloud/storage/contrib/nio/CloudStorageFileSystemProvider.java
Outdated
Show resolved
Hide resolved
chingor13
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
|
I hope everyone had a good weekend! @chingor13 the code should be ready, let me know in case there's still a ball in my camp! |
chingor13
approved these changes
May 28, 2019
|
Thank you very much! |
jean-philippe-martin
deleted the
jp_update_to_latest_fake_folder_convention
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The web interface has a "create folder" button, and that creates
a file ending in '/' that is used to pretend the folder exists.
The web interface maintains the illusion but of course this is still only a file,
so all clients (this one included) has to play along and pretend the directory
exists (or users get confused).
Those fake folders used to be 0-byte, but no longer. This pull request
updates our code so it just looks at the trailing slash, ignoring the size
of the file.
It also adds a test, and in order to write the test we had to add the ability
to create files whose name ends in '/', for test purpose only.
Fixes #5203