Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VPCSC test. #5006

Merged
merged 2 commits into from
Apr 24, 2019
Merged

Add VPCSC test. #5006

merged 2 commits into from
Apr 24, 2019

Conversation

steinwaywhw
Copy link
Contributor

This new file is added in order to test client lib compatibility of VPC SC. The tests are auto-generated from the service definition of the monitoring API. The tests can be run inside or outside of VPC service perimeter. The input to the script should be the following environment variables.

PROJECT_ID: a project that is inside the VPC perimeter.
GOOGLE_CLOUD_TESTS_VPCSC_OUTSIDE_PERIMETER_PROJECT: a project that is outside the VPC perimeter.

@steinwaywhw steinwaywhw requested a review from a team as a code owner April 23, 2019 22:01
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 23, 2019
@codecov
Copy link

codecov bot commented Apr 24, 2019

Codecov Report

Merging #5006 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5006      +/-   ##
============================================
- Coverage     50.32%   50.31%   -0.01%     
  Complexity    23668    23668              
============================================
  Files          2238     2238              
  Lines        226059   226059              
  Branches      24959    24959              
============================================
- Hits         113754   113751       -3     
- Misses       103704   103707       +3     
  Partials       8601     8601
Impacted Files Coverage Δ Complexity Δ
...om/google/cloud/logging/MonitoredResourceUtil.java 50% <0%> (-0.93%) 8% <0%> (ø)
...src/main/java/com/google/cloud/ServiceOptions.java 40.61% <0%> (-0.88%) 27% <0%> (ø)
...e/cloud/datacatalog/v1beta1/DataCatalogClient.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...om/google/cloud/vision/v1/ProductSearchClient.java 61.39% <0%> (ø) 76% <0%> (ø) ⬇️
...atalabeling/v1beta1/DataLabelingServiceClient.java 83.52% <0%> (ø) 83% <0%> (ø) ⬇️
...ud/translate/v3beta1/TranslationServiceClient.java 67.92% <0%> (ø) 24% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c95a223...608717f. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants